From 0db86ef2f14e67255262b22012f586503d778dc6 Mon Sep 17 00:00:00 2001 From: jacobshandling <61553566+jacobshandling@users.noreply.github.com> Date: Tue, 10 Mar 2026 15:30:55 -0700 Subject: [PATCH] UI housekeeping: Update `Modal.children` from `JSX.Element` to `React.ReactNode`, remove empty fragment wrappers (#41394) ## Summary by CodeRabbit * **Refactor** * Simplified modal structures across multiple dialog components for improved code maintainability. * Enhanced modal component's flexibility to support broader content types. --- .../SoftwareInstallDetailsModal.tsx | 18 +- .../SoftwareIpaInstallDetailsModal.tsx | 18 +- .../SoftwareScriptDetailsModal.tsx | 18 +- .../SoftwareUninstallDetailsModal.tsx | 18 +- .../VppInstallDetailsModal.tsx | 18 +- frontend/components/Modal/Modal.tsx | 2 +- frontend/pages/AccountPage/AccountPage.tsx | 60 ++- .../AppStoreDetailsModal.tsx | 78 ++-- .../LibrarySoftwareDetailsModal.tsx | 64 ++-- .../RunScriptDetailsModal.tsx | 6 +- .../MdmSolutionModal/MdmSolutionModal.tsx | 44 ++- .../DeleteCertificateModal.tsx | 36 +- .../ConfigProfileStatusModal.tsx | 10 +- .../AddProfileModal/AddProfileModal.tsx | 82 ++--- .../ResendConfigProfileModal.tsx | 36 +- .../CancelScriptBatchModal.tsx | 48 ++- .../EditScriptModal/EditScriptModal.tsx | 46 ++- .../ScriptUploadModal/ScriptUploadModal.tsx | 40 +- .../DeleteSecretModal/DeleteSecretModal.tsx | 56 ++- .../DeleteSetupExperienceScriptModal.tsx | 46 ++- .../DeleteAutoEnrollmentProfile.tsx | 28 +- .../AddFleetAppSoftwareModal.tsx | 12 +- .../FleetAppDetailsModal.tsx | 94 +++-- .../AdvancedOptionsModal.tsx | 112 +++--- .../DeleteSoftwareModal.tsx | 42 +-- .../EditAutoUpdateConfigModal.tsx | 228 ++++++------ .../EditConfigurationModal.tsx | 44 ++- .../EditIconModal/EditIconModal.tsx | 36 +- .../ViewYamlModal/ViewYamlModal.tsx | 68 ++-- .../CategoriesEndUserExperienceModal.tsx | 54 ++- .../PreviewTicketModal/PreviewTicketModal.tsx | 26 +- .../AddCertAuthorityModal.tsx | 18 +- .../DeleteCertificateAuthorityModal.tsx | 36 +- .../ConditionalAccess/ConditionalAccess.tsx | 40 +- .../EntraConditionalAccessModal.tsx | 66 ++-- .../OktaConditionalAccessModal.tsx | 198 +++++----- .../TurnOffAndroidMdmModal.tsx | 48 ++- .../components/AddAbmModal/AddAbmModal.tsx | 174 +++++---- .../DeleteAbmModal/DeleteAbmModal.tsx | 54 ++- .../EditTeamsAbmModal/EditTeamsAbmModal.tsx | 126 ++++--- .../components/AddVppModal/AddVppModal.tsx | 46 ++- .../DeleteVppModal/DeleteVppModal.tsx | 56 ++- .../EditTeamsVppModal/EditTeamsVppModal.tsx | 108 +++--- .../RenewVppModal/RenewVppModal.tsx | 48 ++- .../AddEntraTenantModal.tsx | 66 ++-- .../DeleteEntraTenantModal.tsx | 32 +- .../ExampleWebhookUrlPayloadModal.tsx | 38 +- .../RemoveUserModal/RemoveUserModal.tsx | 47 ++- .../DeleteTeamModal/DeleteTeamModal.tsx | 46 ++- .../HostStatusWebhookPreviewModal.tsx | 32 +- .../DeleteLabelModal/DeleteLabelModal.tsx | 54 ++- .../RunScriptBatchModal.tsx | 68 ++-- .../CommandDetailsModal.tsx | 6 +- .../DeleteHostModal/DeleteHostModal.tsx | 78 ++-- .../ScriptDetailsModal/ScriptDetailsModal.tsx | 6 +- .../TransferHostModal/TransferHostModal.tsx | 73 ++-- .../BitLockerPinModal/BitLockerPinModal.tsx | 74 ++-- .../BypassModal/BypassModal.tsx | 36 +- .../BootstrapPackageModal.tsx | 20 +- .../CancelActivityModal.tsx | 54 ++- .../modals/LockModal/LockModal.tsx | 62 ++-- .../RecoveryLockPasswordModal.tsx | 50 ++- .../modals/RunScriptModal/RunScriptModal.tsx | 72 ++-- .../SelectQueryModal/SelectQueryModal.tsx | 6 +- .../modals/UnlockModal/UnlockModal.tsx | 10 +- .../modals/WipeModal/WipeModal.tsx | 72 ++-- .../OSSettingsModal/OSSettingsModal.tsx | 20 +- .../OpenSoftwareModal/OpenSoftwareModal.tsx | 6 +- .../SoftwareUpdateModal.tsx | 58 ++- .../UninstallSoftwareModal.tsx | 35 +- .../CertificateDetailsModal.tsx | 342 +++++++++--------- .../InventoryVersionsModal.tsx | 6 +- .../modals/LocationModal/LocationModal.tsx | 6 +- .../CalendarEventPreviewModal.tsx | 198 +++++----- 74 files changed, 2005 insertions(+), 2174 deletions(-) diff --git a/frontend/components/ActivityDetails/InstallDetails/SoftwareInstallDetailsModal/SoftwareInstallDetailsModal.tsx b/frontend/components/ActivityDetails/InstallDetails/SoftwareInstallDetailsModal/SoftwareInstallDetailsModal.tsx index a80f3d893e..50a9c10d5f 100644 --- a/frontend/components/ActivityDetails/InstallDetails/SoftwareInstallDetailsModal/SoftwareInstallDetailsModal.tsx +++ b/frontend/components/ActivityDetails/InstallDetails/SoftwareInstallDetailsModal/SoftwareInstallDetailsModal.tsx @@ -431,16 +431,14 @@ export const SoftwareInstallDetailsModal = ({ onEnter={onCancel} className={baseClass} > - <> - {renderContent()} - - + {renderContent()} + ); }; diff --git a/frontend/components/ActivityDetails/InstallDetails/SoftwareIpaInstallDetailsModal/SoftwareIpaInstallDetailsModal.tsx b/frontend/components/ActivityDetails/InstallDetails/SoftwareIpaInstallDetailsModal/SoftwareIpaInstallDetailsModal.tsx index 7f711fdeee..da466ad52e 100644 --- a/frontend/components/ActivityDetails/InstallDetails/SoftwareIpaInstallDetailsModal/SoftwareIpaInstallDetailsModal.tsx +++ b/frontend/components/ActivityDetails/InstallDetails/SoftwareIpaInstallDetailsModal/SoftwareIpaInstallDetailsModal.tsx @@ -430,16 +430,14 @@ export const SoftwareIpaInstallDetailsModal = ({ onEnter={onCancel} className={baseClass} > - <> - {renderContent()} - - + {renderContent()} + ); }; diff --git a/frontend/components/ActivityDetails/InstallDetails/SoftwareScriptDetailsModal/SoftwareScriptDetailsModal.tsx b/frontend/components/ActivityDetails/InstallDetails/SoftwareScriptDetailsModal/SoftwareScriptDetailsModal.tsx index 75d4953969..b6dde4f1d8 100644 --- a/frontend/components/ActivityDetails/InstallDetails/SoftwareScriptDetailsModal/SoftwareScriptDetailsModal.tsx +++ b/frontend/components/ActivityDetails/InstallDetails/SoftwareScriptDetailsModal/SoftwareScriptDetailsModal.tsx @@ -327,16 +327,14 @@ export const SoftwareScriptDetailsModal = ({ onEnter={onCancel} className={baseClass} > - <> - {renderContent()} - - + {renderContent()} + ); }; diff --git a/frontend/components/ActivityDetails/InstallDetails/SoftwareUninstallDetailsModal/SoftwareUninstallDetailsModal.tsx b/frontend/components/ActivityDetails/InstallDetails/SoftwareUninstallDetailsModal/SoftwareUninstallDetailsModal.tsx index be2bc81a33..e1bc35bfde 100644 --- a/frontend/components/ActivityDetails/InstallDetails/SoftwareUninstallDetailsModal/SoftwareUninstallDetailsModal.tsx +++ b/frontend/components/ActivityDetails/InstallDetails/SoftwareUninstallDetailsModal/SoftwareUninstallDetailsModal.tsx @@ -271,16 +271,14 @@ const SoftwareUninstallDetailsModal = ({ onEnter={onCancel} className={baseClass} > - <> - {renderContent()} - - + {renderContent()} + ); }; diff --git a/frontend/components/ActivityDetails/InstallDetails/VppInstallDetailsModal/VppInstallDetailsModal.tsx b/frontend/components/ActivityDetails/InstallDetails/VppInstallDetailsModal/VppInstallDetailsModal.tsx index 9923d41a93..0b15fdab3c 100644 --- a/frontend/components/ActivityDetails/InstallDetails/VppInstallDetailsModal/VppInstallDetailsModal.tsx +++ b/frontend/components/ActivityDetails/InstallDetails/VppInstallDetailsModal/VppInstallDetailsModal.tsx @@ -484,16 +484,14 @@ export const VppInstallDetailsModal = ({ onEnter={onCancel} className={baseClass} > - <> - {renderContent()} - - + {renderContent()} + ); }; diff --git a/frontend/components/Modal/Modal.tsx b/frontend/components/Modal/Modal.tsx index 0dee5475a5..80dc1847fa 100644 --- a/frontend/components/Modal/Modal.tsx +++ b/frontend/components/Modal/Modal.tsx @@ -10,7 +10,7 @@ type ModalWidth = "medium" | "large" | "xlarge" | "auto"; export interface IModalProps { title: string | JSX.Element; - children: JSX.Element; + children: React.ReactNode; onExit: () => void; onEnter?: () => void; /** medium 650px, large 800px, xlarge 850px, auto auto-width diff --git a/frontend/pages/AccountPage/AccountPage.tsx b/frontend/pages/AccountPage/AccountPage.tsx index 72793518aa..9c58b63b3b 100644 --- a/frontend/pages/AccountPage/AccountPage.tsx +++ b/frontend/pages/AccountPage/AccountPage.tsx @@ -177,40 +177,38 @@ const AccountPage = ({ router }: IAccountPageProps): JSX.Element | null => { onExit={onToggleApiTokenModal} onEnter={onToggleApiTokenModal} > - <> - -

- This token expires. If you want an API key for a - permanent integration, create an  + +

+ This token expires. If you want an API key for a + permanent integration, create an  + +  instead. +

+
+ + This token is intended for SSO users to authenticate in the + fleetctl CLI. It expires based on the{" "} -  instead. -

- - - This token is intended for SSO users to authenticate in the - fleetctl CLI. It expires based on the{" "} - - - } - /> -
- -
- + + } + /> +
+ +
); }; diff --git a/frontend/pages/DashboardPage/cards/ActivityFeed/components/AppStoreDetailsModal/AppStoreDetailsModal.tsx b/frontend/pages/DashboardPage/cards/ActivityFeed/components/AppStoreDetailsModal/AppStoreDetailsModal.tsx index ee07643083..b356fa3c28 100644 --- a/frontend/pages/DashboardPage/cards/ActivityFeed/components/AppStoreDetailsModal/AppStoreDetailsModal.tsx +++ b/frontend/pages/DashboardPage/cards/ActivityFeed/components/AppStoreDetailsModal/AppStoreDetailsModal.tsx @@ -36,46 +36,44 @@ const AppStoreDetailsModal = ({ onEnter={onCancel} className={baseClass} > - <> -
- - - - - } - value={ - - } - /> -
-
- -
- +
+ + + + + } + value={ + + } + /> +
+
+ +
); }; diff --git a/frontend/pages/DashboardPage/cards/ActivityFeed/components/LibrarySoftwareDetailsModal/LibrarySoftwareDetailsModal.tsx b/frontend/pages/DashboardPage/cards/ActivityFeed/components/LibrarySoftwareDetailsModal/LibrarySoftwareDetailsModal.tsx index 1a2b692b51..c45177e08b 100644 --- a/frontend/pages/DashboardPage/cards/ActivityFeed/components/LibrarySoftwareDetailsModal/LibrarySoftwareDetailsModal.tsx +++ b/frontend/pages/DashboardPage/cards/ActivityFeed/components/LibrarySoftwareDetailsModal/LibrarySoftwareDetailsModal.tsx @@ -87,39 +87,37 @@ const LibrarySoftwareDetailsModal = ({ onEnter={onCancel} className={baseClass} > - <> -
- - - - - } - value={ - - } - /> -
-
- -
- +
+ + + + + } + value={ + + } + /> +
+
+ +
); }; diff --git a/frontend/pages/DashboardPage/cards/ActivityFeed/components/RunScriptDetailsModal/RunScriptDetailsModal.tsx b/frontend/pages/DashboardPage/cards/ActivityFeed/components/RunScriptDetailsModal/RunScriptDetailsModal.tsx index 695ab4f7e7..65db750cba 100644 --- a/frontend/pages/DashboardPage/cards/ActivityFeed/components/RunScriptDetailsModal/RunScriptDetailsModal.tsx +++ b/frontend/pages/DashboardPage/cards/ActivityFeed/components/RunScriptDetailsModal/RunScriptDetailsModal.tsx @@ -241,10 +241,8 @@ const RunScriptDetailsModal = ({ className={baseClass} isHidden={isHidden} > - <> - {renderContent()} - {renderFooter()} - + {renderContent()} + {renderFooter()} ); }; diff --git a/frontend/pages/DashboardPage/components/MdmSolutionModal/MdmSolutionModal.tsx b/frontend/pages/DashboardPage/components/MdmSolutionModal/MdmSolutionModal.tsx index 9c33f13020..567a032986 100644 --- a/frontend/pages/DashboardPage/components/MdmSolutionModal/MdmSolutionModal.tsx +++ b/frontend/pages/DashboardPage/components/MdmSolutionModal/MdmSolutionModal.tsx @@ -47,29 +47,27 @@ const MdmSolutionModal = ({ onExit={onCancel} onEnter={onCancel} > - <> -
- null} // if this modal is shown, this table should never be empty - columnConfigs={solutionsTableHeaders} - data={solutionsDataSet} - defaultSortHeader={SOLUTIONS_DEFAULT_SORT_HEADER} - defaultSortDirection={DEFAULT_SORT_DIRECTION} - resultsTitle="MDM" - showMarkAllPages={false} - isAllPagesSelected={false} - disableCount - disablePagination - disableTableHeader - /> -
-
- -
- +
+ null} // if this modal is shown, this table should never be empty + columnConfigs={solutionsTableHeaders} + data={solutionsDataSet} + defaultSortHeader={SOLUTIONS_DEFAULT_SORT_HEADER} + defaultSortDirection={DEFAULT_SORT_DIRECTION} + resultsTitle="MDM" + showMarkAllPages={false} + isAllPagesSelected={false} + disableCount + disablePagination + disableTableHeader + /> +
+
+ +
); }; diff --git a/frontend/pages/ManageControlsPage/OSSettings/cards/Certificates/components/DeleteCertificateModal/DeleteCertificateModal.tsx b/frontend/pages/ManageControlsPage/OSSettings/cards/Certificates/components/DeleteCertificateModal/DeleteCertificateModal.tsx index c020279450..556509cda6 100644 --- a/frontend/pages/ManageControlsPage/OSSettings/cards/Certificates/components/DeleteCertificateModal/DeleteCertificateModal.tsx +++ b/frontend/pages/ManageControlsPage/OSSettings/cards/Certificates/components/DeleteCertificateModal/DeleteCertificateModal.tsx @@ -40,25 +40,23 @@ const DeleteCertificateModal = ({ return ( - <> -

- This action will remove the {name} certificate from all hosts - assigned to this fleet. -

-
- - -
- +

+ This action will remove the {name} certificate from all hosts + assigned to this fleet. +

+
+ + +
); }; diff --git a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ConfigProfileStatusModal/ConfigProfileStatusModal.tsx b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ConfigProfileStatusModal/ConfigProfileStatusModal.tsx index 42c2112d4b..2750666107 100644 --- a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ConfigProfileStatusModal/ConfigProfileStatusModal.tsx +++ b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ConfigProfileStatusModal/ConfigProfileStatusModal.tsx @@ -59,12 +59,10 @@ const ConfigProfileStatusModal = ({ return ( - <> - {renderContent()} -
- -
- + {renderContent()} +
+ +
); }; diff --git a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/AddProfileModal.tsx b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/AddProfileModal.tsx index 0d4e50a7dd..46258e1161 100644 --- a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/AddProfileModal.tsx +++ b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/AddProfileModal.tsx @@ -212,50 +212,48 @@ const AddProfileModal = ({ return ( - <> - {isPremiumTier && isLoadingLabels && } - {isPremiumTier && !isLoadingLabels && isErrorLabels && } - {(!isPremiumTier || (!isLoadingLabels && !isErrorLabels)) && ( -
- - {!fileDetails ? ( - - ) : ( - - )} - - {isPremiumTier && ( - + {isPremiumTier && isLoadingLabels && } + {isPremiumTier && !isLoadingLabels && isErrorLabels && } + {(!isPremiumTier || (!isLoadingLabels && !isErrorLabels)) && ( +
+ + {!fileDetails ? ( + + ) : ( + )} -
- -
+
+ {isPremiumTier && ( + + )} +
+
- )} - +
+ )} ); }; diff --git a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ResendConfigProfileModal/ResendConfigProfileModal.tsx b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ResendConfigProfileModal/ResendConfigProfileModal.tsx index ff278e90e2..d1e96724a8 100644 --- a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ResendConfigProfileModal/ResendConfigProfileModal.tsx +++ b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ResendConfigProfileModal/ResendConfigProfileModal.tsx @@ -52,25 +52,23 @@ const ResendConfigProfileModal = ({ title="Resend configuration profile" onExit={onExit} > - <> -

- This action will resend the {name} configuration profile to{" "} - {countText}. To cancel after resending, delete and re-add the - profile. -

-
- - -
- +

+ This action will resend the {name} configuration profile to{" "} + {countText}. To cancel after resending, delete and re-add the + profile. +

+
+ + +
); }; diff --git a/frontend/pages/ManageControlsPage/Scripts/components/CancelScriptBatchModal/CancelScriptBatchModal.tsx b/frontend/pages/ManageControlsPage/Scripts/components/CancelScriptBatchModal/CancelScriptBatchModal.tsx index 86093cf510..a876bd13df 100644 --- a/frontend/pages/ManageControlsPage/Scripts/components/CancelScriptBatchModal/CancelScriptBatchModal.tsx +++ b/frontend/pages/ManageControlsPage/Scripts/components/CancelScriptBatchModal/CancelScriptBatchModal.tsx @@ -25,32 +25,30 @@ const CancelScriptBatchModal = ({ onEnter={onSubmit} className={baseClass} > - <> -
-

- This will cancel any pending script runs for{" "} - {scriptName ? {scriptName} : "this batch"}. -

-

- If this script is currently running on a host, it will complete, but - results won’t appear in Fleet. -

-

You cannot undo this action.

-
- - -
+
+

+ This will cancel any pending script runs for{" "} + {scriptName ? {scriptName} : "this batch"}. +

+

+ If this script is currently running on a host, it will complete, but + results won’t appear in Fleet. +

+

You cannot undo this action.

+
+ +
- +
); }; diff --git a/frontend/pages/ManageControlsPage/Scripts/components/EditScriptModal/EditScriptModal.tsx b/frontend/pages/ManageControlsPage/Scripts/components/EditScriptModal/EditScriptModal.tsx index ae1f0aac29..226bf3cb11 100644 --- a/frontend/pages/ManageControlsPage/Scripts/components/EditScriptModal/EditScriptModal.tsx +++ b/frontend/pages/ManageControlsPage/Scripts/components/EditScriptModal/EditScriptModal.tsx @@ -39,30 +39,28 @@ const WarningModal = ({ title="Save changes?" onExit={onExit} > - <> -

- The changes you are making will cancel any pending script runs for{" "} - {scriptName}.
-
- If this script is currently running on a host, it will complete, but - results won't appear in Fleet.
-
- You cannot undo this action. -

-
- - -
- +

+ The changes you are making will cancel any pending script runs for{" "} + {scriptName}.
+
+ If this script is currently running on a host, it will complete, but + results won't appear in Fleet.
+
+ You cannot undo this action. +

+
+ + +
); }; diff --git a/frontend/pages/ManageControlsPage/Scripts/components/ScriptUploadModal/ScriptUploadModal.tsx b/frontend/pages/ManageControlsPage/Scripts/components/ScriptUploadModal/ScriptUploadModal.tsx index 1b1b064295..90c13e06ec 100644 --- a/frontend/pages/ManageControlsPage/Scripts/components/ScriptUploadModal/ScriptUploadModal.tsx +++ b/frontend/pages/ManageControlsPage/Scripts/components/ScriptUploadModal/ScriptUploadModal.tsx @@ -52,27 +52,25 @@ const ScriptUploadModal = ({ onEnter={onSubmit} className={baseClass} > - <> -
- setSelectedFile(file)} - selectedFile={selectedFile} - forModal - /> -
- {additionalInfo && ( -

{additionalInfo}

- )} -
- -
- +
+ setSelectedFile(file)} + selectedFile={selectedFile} + forModal + /> +
+ {additionalInfo && ( +

{additionalInfo}

+ )} +
+ +
); }; diff --git a/frontend/pages/ManageControlsPage/Secrets/components/DeleteSecretModal/DeleteSecretModal.tsx b/frontend/pages/ManageControlsPage/Secrets/components/DeleteSecretModal/DeleteSecretModal.tsx index 6bd3f77abe..6a23993275 100644 --- a/frontend/pages/ManageControlsPage/Secrets/components/DeleteSecretModal/DeleteSecretModal.tsx +++ b/frontend/pages/ManageControlsPage/Secrets/components/DeleteSecretModal/DeleteSecretModal.tsx @@ -56,35 +56,33 @@ const DeleteSecretModal = ({ onExit={onExit} className={baseClass} > - <> -
- - This will delete the - - - - custom variable. - -
-
- If this custom variable is used in any configuration profiles or - scripts, they will fail. To resolve, edit the configuration profile or - script. -
-
- - -
- +
+ + This will delete the + + + + custom variable. + +
+
+ If this custom variable is used in any configuration profiles or + scripts, they will fail. To resolve, edit the configuration profile or + script. +
+
+ + +
); }; diff --git a/frontend/pages/ManageControlsPage/SetupExperience/cards/RunScript/components/DeleteSetupExperienceScriptModal/DeleteSetupExperienceScriptModal.tsx b/frontend/pages/ManageControlsPage/SetupExperience/cards/RunScript/components/DeleteSetupExperienceScriptModal/DeleteSetupExperienceScriptModal.tsx index b9e6cbda86..11d570c9f0 100644 --- a/frontend/pages/ManageControlsPage/SetupExperience/cards/RunScript/components/DeleteSetupExperienceScriptModal/DeleteSetupExperienceScriptModal.tsx +++ b/frontend/pages/ManageControlsPage/SetupExperience/cards/RunScript/components/DeleteSetupExperienceScriptModal/DeleteSetupExperienceScriptModal.tsx @@ -47,30 +47,28 @@ const DeleteSetupExperienceScriptModal = ({ onExit={onExit} isContentDisabled={isDeleting} > - <> -

- This action will cancel any pending script execution for{" "} - {scriptName}. -

-

- If the script is currently running on a host it will still complete, - but results won't appear in Fleet. -

-

You cannot undo this action.

-
- - -
- +

+ This action will cancel any pending script execution for{" "} + {scriptName}. +

+

+ If the script is currently running on a host it will still complete, but + results won't appear in Fleet. +

+

You cannot undo this action.

+
+ + +
); }; diff --git a/frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/components/DeleteAutoEnrollmentProfile/DeleteAutoEnrollmentProfile.tsx b/frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/components/DeleteAutoEnrollmentProfile/DeleteAutoEnrollmentProfile.tsx index 517f2f4f80..0a929d3207 100644 --- a/frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/components/DeleteAutoEnrollmentProfile/DeleteAutoEnrollmentProfile.tsx +++ b/frontend/pages/ManageControlsPage/SetupExperience/cards/SetupAssistant/components/DeleteAutoEnrollmentProfile/DeleteAutoEnrollmentProfile.tsx @@ -37,21 +37,19 @@ const DeleteAutoEnrollProfile = ({ title="Delete automatic enrollment profile" onExit={onCancel} > - <> -

Delete the automatic enrollment profile to upload a new one.

-

- Without an automatic enrollment profile, new macOS hosts will - automatically enroll with the default setup settings. -

-
- - -
- +

Delete the automatic enrollment profile to upload a new one.

+

+ Without an automatic enrollment profile, new macOS hosts will + automatically enroll with the default setup settings. +

+
+ + +
); }; diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/AddFleetAppSoftwareModal/AddFleetAppSoftwareModal.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/AddFleetAppSoftwareModal/AddFleetAppSoftwareModal.tsx index 9a4e3cd4be..f1cc6ddc19 100644 --- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/AddFleetAppSoftwareModal/AddFleetAppSoftwareModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/AddFleetAppSoftwareModal/AddFleetAppSoftwareModal.tsx @@ -15,13 +15,11 @@ const AddFleetAppSoftwareModal = () => { onExit={noop} disableClosingModal > - <> - -

- Uploading software so that it's available for install. This may - take a few minutes. -

- + +

+ Uploading software so that it's available for install. This may + take a few minutes. +

); }; diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetAppDetailsModal/FleetAppDetailsModal.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetAppDetailsModal/FleetAppDetailsModal.tsx index 96980dcb5c..fd630330da 100644 --- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetAppDetailsModal/FleetAppDetailsModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetAppDetailsModal/FleetAppDetailsModal.tsx @@ -87,55 +87,53 @@ const FleetAppDetailsModal = ({ return ( - <> -
- - - {slug && ( - - Fleet-maintained app slug - - } - value={ - <> - {slug}{" "} -
- {copyMessage && ( -
{`${copyMessage} `}
- )} -
- - - } - /> - )} - +
+ + + {slug && ( + + Fleet-maintained app slug + + } + value={ + <> + {slug}{" "} +
+ {copyMessage && ( +
{`${copyMessage} `}
+ )} +
+ + + } + /> + )} + - {url && ( - - URL - - } - value={} - /> - )} -
-
- -
- + {url && ( + + URL + + } + value={} + /> + )} +
+
+ +
); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/AdvancedOptionsModal/AdvancedOptionsModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/AdvancedOptionsModal/AdvancedOptionsModal.tsx index 8f17704cfd..0b0a3da3c7 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/AdvancedOptionsModal/AdvancedOptionsModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/AdvancedOptionsModal/AdvancedOptionsModal.tsx @@ -23,63 +23,61 @@ const AdvancedOptionsModal = ({ }: IAdvancedOptionsModalProps) => { return ( - <> -

- Advanced options are read-only. To change options, delete software and - add again. -

-
- - {preInstallQuery && ( -
- Pre-install condition: - - Software will be installed only if the{" "} - - - } - /> -
- )} - {postInstallScript && ( -
- Post-install script: - -
- )} -
-
- -
- +

+ Advanced options are read-only. To change options, delete software and + add again. +

+
+ + {preInstallQuery && ( +
+ Pre-install condition: + + Software will be installed only if the{" "} + + + } + /> +
+ )} + {postInstallScript && ( +
+ Post-install script: + +
+ )} +
+
+ +
); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/DeleteSoftwareModal/DeleteSoftwareModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/DeleteSoftwareModal/DeleteSoftwareModal.tsx index 0ab96d3cc8..011d132a56 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/DeleteSoftwareModal/DeleteSoftwareModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/DeleteSoftwareModal/DeleteSoftwareModal.tsx @@ -109,28 +109,26 @@ const DeleteSoftwareModal = ({ onExit={onExit} isContentDisabled={isDeleting} > - <> - {gitOpsModeEnabled && ( - - You are currently in GitOps mode. If the package is defined in - GitOps, it will reappear when GitOps runs. - - )} - {getPlatformMessage(isAppStoreApp, isAndroidApp)} -

Custom icon and display name will be deleted.

-
- - -
- + {gitOpsModeEnabled && ( + + You are currently in GitOps mode. If the package is defined in GitOps, + it will reappear when GitOps runs. + + )} + {getPlatformMessage(isAppStoreApp, isAndroidApp)} +

Custom icon and display name will be deleted.

+
+ + +
); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditAutoUpdateConfigModal/EditAutoUpdateConfigModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditAutoUpdateConfigModal/EditAutoUpdateConfigModal.tsx index edf0ffda4e..18edab9a66 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditAutoUpdateConfigModal/EditAutoUpdateConfigModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditAutoUpdateConfigModal/EditAutoUpdateConfigModal.tsx @@ -208,126 +208,122 @@ const EditAutoUpdateConfigModal = ({ return ( - <> -
-
- -
-
-
Auto updates
-
- Automatically update{" "} - - {getDisplayedSoftwareName( - softwareTitle.name, - softwareTitle.display_name - )} - {" "} - on all targeted hosts when a new version is available. +
+
+ +
+
+
Auto updates
+
+ Automatically update{" "} + + {getDisplayedSoftwareName( + softwareTitle.name, + softwareTitle.display_name + )} + {" "} + on all targeted hosts when a new version is available. +
+
+ onToggleEnabled(newVal)} + > + Enable auto updates + +
+
+ {formData.autoUpdateEnabled && ( + <> +
+
+
+ {updateWindowLabel} +
+
+ Times are formatted as HH:MM in 24 hour time (e.g., + "13:37"). +
+
- onToggleEnabled(newVal)} - > - Enable auto updates - +
+ + + setFormValidation(validateFormData(formData)) + } + label="Earliest start time" + name="autoUpdateStartTime" + parseTarget + error={earliestStartTimeError} + /> + + setFormValidation(validateFormData(formData)) + } + label="Latest start time" + name="autoUpdateEndTime" + parseTarget + error={latestStartTimeError} + /> + +
-
- {formData.autoUpdateEnabled && ( - <> -
-
-
- {updateWindowLabel} -
-
- Times are formatted as HH:MM in 24 hour time (e.g., - "13:37"). -
-
-
-
-
- - - setFormValidation(validateFormData(formData)) - } - label="Earliest start time" - name="autoUpdateStartTime" - parseTarget - error={earliestStartTimeError} - /> - - setFormValidation(validateFormData(formData)) - } - label="Latest start time" - name="autoUpdateEndTime" - parseTarget - error={latestStartTimeError} - /> - -
-
- - )} -
- - - - -
+ + )} +
+ + + +
- - - ( - - )} - /> - - } - /> - +
+ + + ( + + )} + /> + + } + /> ); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx index 5e93406bbd..b38d4e271e 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx @@ -144,29 +144,27 @@ const EditConfigurationModal = ({ return ( - <> - - {renderForm()} - - Save - - } - /> - + + {renderForm()} + + Save + + } + /> ); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx index 336e54c755..942dfead5a 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx @@ -739,25 +739,23 @@ const EditIconModal = ({ title="Edit appearance" onExit={onExitEditIconModal} > - <> - {isFirstLoadWithCustomIcon ? ( - - ) : ( - renderForm() - )} - - Save - - } - /> - + {isFirstLoadWithCustomIcon ? ( + + ) : ( + renderForm() + )} + + Save + + } + /> ); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/ViewYamlModal/ViewYamlModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/ViewYamlModal/ViewYamlModal.tsx index 1420601ea6..09d7955e65 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/ViewYamlModal/ViewYamlModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/ViewYamlModal/ViewYamlModal.tsx @@ -56,41 +56,39 @@ const ViewYamlModal = ({ return ( - <> - {repositoryUrl && ( -

- Manage in . -

- )} -
- - - If you added advanced options, learn how to{" "} - - . - - } - /> -
-
- -
- + {repositoryUrl && ( +

+ Manage in . +

+ )} +
+ + + If you added advanced options, learn how to{" "} + + . + + } + /> +
+
+ +
); }; diff --git a/frontend/pages/SoftwarePage/components/modals/CategoriesEndUserExperienceModal/CategoriesEndUserExperienceModal.tsx b/frontend/pages/SoftwarePage/components/modals/CategoriesEndUserExperienceModal/CategoriesEndUserExperienceModal.tsx index 7461a6575b..372e0e64e4 100644 --- a/frontend/pages/SoftwarePage/components/modals/CategoriesEndUserExperienceModal/CategoriesEndUserExperienceModal.tsx +++ b/frontend/pages/SoftwarePage/components/modals/CategoriesEndUserExperienceModal/CategoriesEndUserExperienceModal.tsx @@ -142,34 +142,32 @@ const CategoriesEndUserExperienceModal = ({ const { config } = useContext(AppContext); return ( - <> - What end users see: - ( - - )} - renderTable={() => ( - - )} - /> -
- -
- + What end users see: + ( + + )} + renderTable={() => ( + + )} + /> +
+ +
); }; diff --git a/frontend/pages/SoftwarePage/components/modals/PreviewTicketModal/PreviewTicketModal.tsx b/frontend/pages/SoftwarePage/components/modals/PreviewTicketModal/PreviewTicketModal.tsx index 087b08b499..49e0c6a055 100644 --- a/frontend/pages/SoftwarePage/components/modals/PreviewTicketModal/PreviewTicketModal.tsx +++ b/frontend/pages/SoftwarePage/components/modals/PreviewTicketModal/PreviewTicketModal.tsx @@ -46,20 +46,18 @@ const PreviewTicketModal = ({ className={baseClass} width="large" > - <> -

- Want to learn more about how automations in Fleet work?{" "} - -

-
{screenshot}
-
- -
- +

+ Want to learn more about how automations in Fleet work?{" "} + +

+
{screenshot}
+
+ +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/AddCertAuthorityModal/AddCertAuthorityModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/AddCertAuthorityModal/AddCertAuthorityModal.tsx index cdf8764643..25175d52a1 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/AddCertAuthorityModal/AddCertAuthorityModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/AddCertAuthorityModal/AddCertAuthorityModal.tsx @@ -289,16 +289,14 @@ const AddCertAuthorityModal = ({ onExit={onExit} isContentDisabled={isAdding} > - <> - - {renderForm()} - + + {renderForm()} ); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/DeleteCertificateAuthorityModal/DeleteCertificateAuthorityModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/DeleteCertificateAuthorityModal/DeleteCertificateAuthorityModal.tsx index f71ff505ec..144b678a48 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/DeleteCertificateAuthorityModal/DeleteCertificateAuthorityModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/CertificateAuthorities/components/DeleteCertificateAuthorityModal/DeleteCertificateAuthorityModal.tsx @@ -46,25 +46,23 @@ const DeleteCertificateAuthorityModal = ({ title="Delete certificate authority (CA)" onExit={onExit} > - <> -

- Fleet won't remove certificates from the certificate authority ( - {certAuthority.name}) on existing hosts. -

-
- - -
- +

+ Fleet won't remove certificates from the certificate authority ( + {certAuthority.name}) on existing hosts. +

+
+ + +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/ConditionalAccess.tsx b/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/ConditionalAccess.tsx index 6f8bafc8f7..6264fda0f4 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/ConditionalAccess.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/ConditionalAccess.tsx @@ -130,27 +130,25 @@ const DeleteConditionalAccessModal = ({ onExit={toggleDeleteConditionalAccessModal} onEnter={handleDelete} > - <> - {copy} -
- - -
- + {copy} +
+ + +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/EntraConditionalAccessModal/EntraConditionalAccessModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/EntraConditionalAccessModal/EntraConditionalAccessModal.tsx index 4df47a3ffc..c19c808cbe 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/EntraConditionalAccessModal/EntraConditionalAccessModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/EntraConditionalAccessModal/EntraConditionalAccessModal.tsx @@ -93,41 +93,39 @@ const EntraConditionalAccessModal = ({ className={baseClass} width="large" > - <> -
-

- To configure Microsoft Entra conditional access, follow the - instructions in the{" "} - -

- +

+ To configure Microsoft Entra conditional access, follow the + instructions in the{" "} + -

- - -
- - +

+ +
+ + +
+ ); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/OktaConditionalAccessModal/OktaConditionalAccessModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/OktaConditionalAccessModal/OktaConditionalAccessModal.tsx index 529852b2d2..c43dec0f64 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/OktaConditionalAccessModal/OktaConditionalAccessModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/components/OktaConditionalAccessModal/OktaConditionalAccessModal.tsx @@ -287,110 +287,108 @@ const OktaConditionalAccessModal = ({ className={baseClass} width="xlarge" > - <> -
-

- To configure Okta conditional access, follow the instructions in the{" "} - -

+ +

+ To configure Okta conditional access, follow the instructions in the{" "} + +

- {/* IdP Signature Certificate Section */} -
- - Identity provider (IdP) signature certificate - -
- -
+ {/* IdP Signature Certificate Section */} +
+ + Identity provider (IdP) signature certificate + +
+ +
- {/* User Scope Profile */} - + {/* User Scope Profile */} + - {/* Help text */} -

- You can find the following fields in Okta after creating an IdP in{" "} - Security > Identity Providers{" "} - > SAML 2.0 IdP. -

+ {/* Help text */} +

+ You can find the following fields in Okta after creating an IdP in{" "} + Security > Identity Providers{" "} + > SAML 2.0 IdP. +

- - - - - Upload the certificate provided by Okta during the{" "} - Set Up Authenticator workflow - - } - internalError={formErrors[OKTA_CERTIFICATE]} - onFileUpload={onSelectFile} - buttonType="brand-inverse-icon" - buttonMessage="Upload" - accept=".pem,.crt,.cer,.cert" - fileDetails={certFile ? { name: certFile.name } : undefined} - onDeleteFile={onDeleteFile} - /> -
- - -
- - + + + + + Upload the certificate provided by Okta during the{" "} + Set Up Authenticator workflow + + } + internalError={formErrors[OKTA_CERTIFICATE]} + onFileUpload={onSelectFile} + buttonType="brand-inverse-icon" + buttonMessage="Upload" + accept=".pem,.crt,.cer,.cert" + fileDetails={certFile ? { name: certFile.name } : undefined} + onDeleteFile={onDeleteFile} + /> +
+ + +
+ ); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AndroidMdmPage/components/TurnOffAndroidMdmModal/TurnOffAndroidMdmModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AndroidMdmPage/components/TurnOffAndroidMdmModal/TurnOffAndroidMdmModal.tsx index d9f031c049..22a0bafacf 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AndroidMdmPage/components/TurnOffAndroidMdmModal/TurnOffAndroidMdmModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AndroidMdmPage/components/TurnOffAndroidMdmModal/TurnOffAndroidMdmModal.tsx @@ -39,33 +39,27 @@ const TurnOffAndroidMdmModal = ({ return ( - <> -

- If you want to use MDM features again, you'll have to reconnect - Android Enterprise. -

-

- End users will lose access to organization resources and all data in - their Android work partition. -

-
- - -
- +

+ If you want to use MDM features again, you'll have to reconnect + Android Enterprise. +

+

+ End users will lose access to organization resources and all data in + their Android work partition. +

+
+ + +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AddAbmModal/AddAbmModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AddAbmModal/AddAbmModal.tsx index fd62e7eb6c..d3f3d99786 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AddAbmModal/AddAbmModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AddAbmModal/AddAbmModal.tsx @@ -57,96 +57,94 @@ const AddAbmModal = ({ onCancel, onAdded }: IAddAbmModalProps) => { onExit={onCancel} width="large" > - <> -
    -
  1. - 1. -

    - Download your public key. -

    -
  2. -
  3. - 2. +
      +
    1. + 1. +

      + Download your public key. +

      +
    2. +
    3. + 2. + - - Sign in to{" "} - -
      - If your organization doesn't have an account, select{" "} - Enroll now. -
      + Sign in to{" "} + +
      + If your organization doesn't have an account, select{" "} + Enroll now.
      -
    4. -
    5. - 3. - - Select your account name at the bottom left of the screen, - then select Preferences. - -
    6. -
    7. - 4. - - In the Your MDM Servers section, select Add. - -
    8. -
    9. - 5. - Enter a name for the server such as “Fleet”. -
    10. -
    11. - 6. - - Under MDM Server Settings, upload the public key downloaded - in the first step and select Save. - -
    12. -
    13. - 7. - - In the Default Device Assignment section, select{" "} - Change, then assign the newly created server as the default - for your Macs, iPhones, and iPads. Then select Done. - -
    14. -
    15. - 8. - - Select newly created server in the sidebar, then select{" "} - Download MDM Server Token on the top. - -
    16. -
    17. - 9. - Upload the downloaded token (.p7m file). -
    18. -
    - -
    - -
    - + +
  4. +
  5. + 3. + + Select your account name at the bottom left of the screen, + then select Preferences. + +
  6. +
  7. + 4. + + In the Your MDM Servers section, select Add. + +
  8. +
  9. + 5. + Enter a name for the server such as "Fleet". +
  10. +
  11. + 6. + + Under MDM Server Settings, upload the public key downloaded + in the first step and select Save. + +
  12. +
  13. + 7. + + In the Default Device Assignment section, select{" "} + Change, then assign the newly created server as the default + for your Macs, iPhones, and iPads. Then select Done. + +
  14. +
  15. + 8. + + Select newly created server in the sidebar, then select{" "} + Download MDM Server Token on the top. + +
  16. +
  17. + 9. + Upload the downloaded token (.p7m file). +
  18. +
+ +
+ +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/DeleteAbmModal/DeleteAbmModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/DeleteAbmModal/DeleteAbmModal.tsx index 7efec7377c..4ed4be1db2 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/DeleteAbmModal/DeleteAbmModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/DeleteAbmModal/DeleteAbmModal.tsx @@ -49,35 +49,33 @@ const DeleteAbmModal = ({ onExit={onCancel} isContentDisabled={isDeleting} > - <> -

- New hosts purchased in the {tokenOrgName} won't - automatically enroll to Fleet.{" "} -

-

- If you want to re-enable automatic enrollment, you'll have to - upload a new ABM token. -

+

+ New hosts purchased in the {tokenOrgName} won't + automatically enroll to Fleet.{" "} +

+

+ If you want to re-enable automatic enrollment, you'll have to + upload a new ABM token. +

-
- - -
- +
+ + +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/EditTeamsAbmModal/EditTeamsAbmModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/EditTeamsAbmModal/EditTeamsAbmModal.tsx index a5662b0249..8910cb31c6 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/EditTeamsAbmModal/EditTeamsAbmModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/EditTeamsAbmModal/EditTeamsAbmModal.tsx @@ -132,70 +132,68 @@ const EditTeamsAbmModal = ({ width="large" isContentDisabled={isSaving} > - <> -

- Edit fleets for {token.org_name}. -

-
- { - setSelectedTeamNames((prev) => ({ ...prev, macos_team: value })); - }} - value={selectedTeamNames.macos_team} - label="macOS fleet" - wrapperClassName={`${baseClass}__form-field form-field--macos`} - tooltip={ - <> - macOS hosts are automatically added to this fleet in Fleet when - they appear in Apple Business Manager. - - } - /> - { - setSelectedTeamNames((prev) => ({ ...prev, ios_team: value })); - }} - value={selectedTeamNames.ios_team} - label="iOS fleet" - wrapperClassName={`${baseClass}__form-field form-field--ios`} - tooltip={ - <> - iOS hosts are automatically added to this fleet in Fleet when - they appear in Apple Business Manager. - - } - /> - - setSelectedTeamNames((prev) => ({ ...prev, ipados_team: value })) - } - value={selectedTeamNames.ipados_team} - label="iPadOS fleet" - wrapperClassName={`${baseClass}__form-field form-field--ipados`} - tooltip={ - <> - iPadOS hosts are automatically added to this fleet in Fleet when - they appear in Apple Business Manager. - - } - /> -
- -
- - +

+ Edit fleets for {token.org_name}. +

+
+ { + setSelectedTeamNames((prev) => ({ ...prev, macos_team: value })); + }} + value={selectedTeamNames.macos_team} + label="macOS fleet" + wrapperClassName={`${baseClass}__form-field form-field--macos`} + tooltip={ + <> + macOS hosts are automatically added to this fleet in Fleet when + they appear in Apple Business Manager. + + } + /> + { + setSelectedTeamNames((prev) => ({ ...prev, ios_team: value })); + }} + value={selectedTeamNames.ios_team} + label="iOS fleet" + wrapperClassName={`${baseClass}__form-field form-field--ios`} + tooltip={ + <> + iOS hosts are automatically added to this fleet in Fleet when they + appear in Apple Business Manager. + + } + /> + + setSelectedTeamNames((prev) => ({ ...prev, ipados_team: value })) + } + value={selectedTeamNames.ipados_team} + label="iPadOS fleet" + wrapperClassName={`${baseClass}__form-field form-field--ipados`} + tooltip={ + <> + iPadOS hosts are automatically added to this fleet in Fleet when + they appear in Apple Business Manager. + + } + /> +
+ +
+ ); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/AddVppModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/AddVppModal.tsx index 7bd1e70deb..a86cc78ee2 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/AddVppModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/AddVppModal/AddVppModal.tsx @@ -57,30 +57,28 @@ const AddVppModal = ({ onCancel, onAdded }: IAddVppModalProps) => { onExit={onCancel} width="large" > - <> - - -
- -
- + + +
+ +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx index 7c2700d11c..f2e07a676a 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/DeleteVppModal/DeleteVppModal.tsx @@ -46,36 +46,34 @@ const DeleteVppModal = ({ onExit={onCancel} isContentDisabled={isDeleting} > - <> -

- Apps purchased for the {orgName} location won't appear in - Fleet, and policies that trigger automatic install of these apps will - be deleted. Apps won't be uninstalled from hosts. -

-

- If you want to enable VPP integration again, you'll have to - upload a new token. -

+

+ Apps purchased for the {orgName} location won't appear in + Fleet, and policies that trigger automatic install of these apps will be + deleted. Apps won't be uninstalled from hosts. +

+

+ If you want to enable VPP integration again, you'll have to upload + a new token. +

-
- - -
- +
+ + +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx index a11e123401..d17f2e631d 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/EditTeamsVppModal/EditTeamsVppModal.tsx @@ -246,63 +246,61 @@ const EditTeamsVppModal = ({ width="large" isContentDisabled={isSaving} > - <> -

- Edit fleets for {currentToken.org_name}. -

-

- If you delete a fleet, App Store apps will be deleted from that fleet. - Installed apps won't be uninstalled from hosts. -

-
- - You can't choose fleets because you already have a VPP - token assigned to all fleets. First, edit fleets for that VPP - token to choose fleets here. -
+

+ Edit fleets for {currentToken.org_name}. +

+

+ If you delete a fleet, App Store apps will be deleted from that fleet. + Installed apps won't be uninstalled from hosts. +

+ + + You can't choose fleets because you already have a VPP token + assigned to all fleets. First, edit fleets for that VPP token to + choose fleets here. +
+ } + disableTooltip={!isDropdownDisabled} + > + + Each fleet can have only one VPP token. Fleets that already + have a VPP token won't show up here. + + ) } - disableTooltip={!isDropdownDisabled} + helpText="App Store apps in this VPP token's Apple Business Manager (ABM) will only be available to install on hosts in these fleets." + disabled={isDropdownDisabled} + /> + +
+ -
- - + Save + +
+ ); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsx index 477d9c1863..bed9ba1fef 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/VppPage/components/RenewVppModal/RenewVppModal.tsx @@ -67,31 +67,29 @@ const RenewVppModal = ({ isContentDisabled={isRenewing} width="large" > - <> -

- Renew Volume Purchasing Program for {orgName} location. -

- - -
- -
- +

+ Renew Volume Purchasing Program for {orgName} location. +

+ + +
+ +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/AddEntraTenantModal/AddEntraTenantModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/AddEntraTenantModal/AddEntraTenantModal.tsx index 3de2f36237..3520b67b94 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/AddEntraTenantModal/AddEntraTenantModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/AddEntraTenantModal/AddEntraTenantModal.tsx @@ -88,40 +88,38 @@ const AddEntraTenantModal = ({ onExit }: IAddEntraTenantModalProps) => { onExit={onExit} isContentDisabled={isAdding} > - <> -
- - Find your Tenant ID, on{" "} - - - } - /> -
-
- - -
- +
+ + Find your Tenant ID, on{" "} + + + } + /> +
+
+ + +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/DeleteEntraTenantModal/DeleteEntraTenantModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/DeleteEntraTenantModal/DeleteEntraTenantModal.tsx index 1e6f28b116..12289d9501 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/DeleteEntraTenantModal/DeleteEntraTenantModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/DeleteEntraTenantModal/DeleteEntraTenantModal.tsx @@ -52,25 +52,19 @@ const DeleteEntraTenantModal = ({ width="medium" isContentDisabled={isDeleting} > - <> -

- This will stop both automatic (Autopilot) and manual enrollment by end - users (Settings > Accounts > Access work or school on - Windows) from this tenant. -

-
- - -
- +

+ This will stop both automatic (Autopilot) and manual enrollment by end + users (Settings > Accounts > Access work or school on + Windows) from this tenant. +

+
+ + +
); }; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/ExampleWebhookUrlPayloadModal/ExampleWebhookUrlPayloadModal.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/ExampleWebhookUrlPayloadModal/ExampleWebhookUrlPayloadModal.tsx index ff39a6d667..bcf8fb5768 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/ExampleWebhookUrlPayloadModal/ExampleWebhookUrlPayloadModal.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/ExampleWebhookUrlPayloadModal/ExampleWebhookUrlPayloadModal.tsx @@ -24,26 +24,24 @@ const ExampleWebhookUrlPayloadModal = ({ }: IExampleWebhookUrlPayloadModalProps) => { return ( - <> -

- An example request sent to your configured Webhook URL. -

-
-          POST https://organization.com/send-request-here
-        
-
-
-        
-
- -
- +

+ An example request sent to your configured Webhook URL. +

+
+        POST https://organization.com/send-request-here
+      
+
+
+      
+
+ +
); }; diff --git a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/components/RemoveUserModal/RemoveUserModal.tsx b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/components/RemoveUserModal/RemoveUserModal.tsx index fb4f8b0d46..62fd798050 100644 --- a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/components/RemoveUserModal/RemoveUserModal.tsx +++ b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/components/RemoveUserModal/RemoveUserModal.tsx @@ -27,31 +27,28 @@ const RemoveUserModal = ({ onEnter={onSubmit} className={baseClass} > - <> -

- You are about to remove{" "} - {userName} from{" "} - {teamName}. -

-

- If {userName} is not assigned to any other fleet, they will lose - access. -

-
- - -
- +

+ You are about to remove{" "} + {userName} from{" "} + {teamName}. +

+

+ If {userName} is not assigned to any other fleet, they will lose access. +

+
+ + +
); }; diff --git a/frontend/pages/admin/TeamManagementPage/components/DeleteTeamModal/DeleteTeamModal.tsx b/frontend/pages/admin/TeamManagementPage/components/DeleteTeamModal/DeleteTeamModal.tsx index 69ecdc4310..ecc9a199a7 100644 --- a/frontend/pages/admin/TeamManagementPage/components/DeleteTeamModal/DeleteTeamModal.tsx +++ b/frontend/pages/admin/TeamManagementPage/components/DeleteTeamModal/DeleteTeamModal.tsx @@ -25,30 +25,28 @@ const DeleteTeamModal = ({ onEnter={onSubmit} className={baseClass} > - <> -

- This will delete the{" "} - {name} fleet. -

-

- Users on this fleet who are not assigned to other fleets won't be - able to log in. -

-
- - -
- +

+ This will delete the{" "} + {name} fleet. +

+

+ Users on this fleet who are not assigned to other fleets won't be + able to log in. +

+
+ + +
); }; diff --git a/frontend/pages/admin/components/HostStatusWebhookPreviewModal/HostStatusWebhookPreviewModal.tsx b/frontend/pages/admin/components/HostStatusWebhookPreviewModal/HostStatusWebhookPreviewModal.tsx index f46dfaf4ae..c060e37721 100644 --- a/frontend/pages/admin/components/HostStatusWebhookPreviewModal/HostStatusWebhookPreviewModal.tsx +++ b/frontend/pages/admin/components/HostStatusWebhookPreviewModal/HostStatusWebhookPreviewModal.tsx @@ -42,23 +42,21 @@ const HostStatusWebhookPreviewModal = ({ onEnter={toggleModal} className={baseClass} > - <> -

- An example request sent to your configured Destination URL. -

-
-
-        
-
- -
- +

+ An example request sent to your configured Destination URL. +

+
+
+      
+
+ +
); }; diff --git a/frontend/pages/hosts/ManageHostsPage/components/DeleteLabelModal/DeleteLabelModal.tsx b/frontend/pages/hosts/ManageHostsPage/components/DeleteLabelModal/DeleteLabelModal.tsx index 5e6b8751f4..a340127b91 100644 --- a/frontend/pages/hosts/ManageHostsPage/components/DeleteLabelModal/DeleteLabelModal.tsx +++ b/frontend/pages/hosts/ManageHostsPage/components/DeleteLabelModal/DeleteLabelModal.tsx @@ -26,34 +26,32 @@ const DeleteLabelModal = ({ onEnter={onSubmit} className={baseClass} > - <> -

Are you sure you wish to delete this label?

- {isPremiumTier && ( -
    -
  • - Configuration profiles that target this label will not be applied - to new hosts. -
  • -
  • - Reports and policies that target this label will continue to run, - but may target different hosts. -
  • -
- )} -
- - -
- +

Are you sure you wish to delete this label?

+ {isPremiumTier && ( +
    +
  • + Configuration profiles that target this label will not be applied to + new hosts. +
  • +
  • + Reports and policies that target this label will continue to run, + but may target different hosts. +
  • +
+ )} +
+ + +
); }; diff --git a/frontend/pages/hosts/ManageHostsPage/components/RunScriptBatchModal/RunScriptBatchModal.tsx b/frontend/pages/hosts/ManageHostsPage/components/RunScriptBatchModal/RunScriptBatchModal.tsx index 7517816388..47cfcc48e5 100644 --- a/frontend/pages/hosts/ManageHostsPage/components/RunScriptBatchModal/RunScriptBatchModal.tsx +++ b/frontend/pages/hosts/ManageHostsPage/components/RunScriptBatchModal/RunScriptBatchModal.tsx @@ -336,44 +336,42 @@ const RunScriptBatchModal = ({ className={classes} disableClosingModal={isUpdating} > - <> - {renderModalContent()} - {!selectedScript && !scriptForDetails && ( -
- -
- )} - {selectedScript && ( -
- - - + {renderModalContent()} + {!selectedScript && !scriptForDetails && ( +
+ +
+ )} + {selectedScript && ( +
+ -
- )} - + + +
+ )} {!!scriptForDetails && !selectedScript && ( - <> - - Done} /> - + + Done} /> ); }; diff --git a/frontend/pages/hosts/components/DeleteHostModal/DeleteHostModal.tsx b/frontend/pages/hosts/components/DeleteHostModal/DeleteHostModal.tsx index 0c93b80615..dee89851c9 100644 --- a/frontend/pages/hosts/components/DeleteHostModal/DeleteHostModal.tsx +++ b/frontend/pages/hosts/components/DeleteHostModal/DeleteHostModal.tsx @@ -56,48 +56,46 @@ const DeleteHostModal = ({ return ( - <> +

+ This will remove the record of {hostText()} and associated data + such as unlock PINs and disk encryption keys. +

+ {hasManyHosts && (

- This will remove the record of {hostText()} and associated data - such as unlock PINs and disk encryption keys. + When deleting a large volume of hosts, it may take some time for this + change to be reflected in the UI.

- {hasManyHosts && ( -

- When deleting a large volume of hosts, it may take some time for - this change to be reflected in the UI. -

- )} -
    -
  • - macOS, Windows, or Linux hosts will re-appear unless Fleet's - agent is uninstalled.{" "} - -
  • -
  • - iOS, iPadOS, and Android hosts will re-appear unless MDM is turned - off. For iOS and iPadOS it may take up to an hour and for Android it - may take up to 24 hours to re-appear. -
  • -
-
- - -
- + )} +
    +
  • + macOS, Windows, or Linux hosts will re-appear unless Fleet's + agent is uninstalled.{" "} + +
  • +
  • + iOS, iPadOS, and Android hosts will re-appear unless MDM is turned + off. For iOS and iPadOS it may take up to an hour and for Android it + may take up to 24 hours to re-appear. +
  • +
+
+ + +
); }; diff --git a/frontend/pages/hosts/components/ScriptDetailsModal/ScriptDetailsModal.tsx b/frontend/pages/hosts/components/ScriptDetailsModal/ScriptDetailsModal.tsx index 0a3aebc7b8..251a475090 100644 --- a/frontend/pages/hosts/components/ScriptDetailsModal/ScriptDetailsModal.tsx +++ b/frontend/pages/hosts/components/ScriptDetailsModal/ScriptDetailsModal.tsx @@ -290,10 +290,8 @@ const ScriptDetailsModal = ({ onExit={onClose ?? onCancel} isHidden={isHidden} > - <> - {renderContent()} - {shouldShowFooter && renderFooter()} - + {renderContent()} + {shouldShowFooter && renderFooter()} ); }; diff --git a/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tsx b/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tsx index d1e5f166ee..b4b3192962 100644 --- a/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tsx +++ b/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tsx @@ -76,45 +76,40 @@ const TransferHostModal = ({ return ( - <> -
- - {isGlobalAdmin ? ( -

- Fleet not here?{" "} - - Create a fleet - -

- ) : null} -
- - -
- - +
+ + {isGlobalAdmin ? ( +

+ Fleet not here?{" "} + + Create a fleet + +

+ ) : null} +
+ + +
+
); }; diff --git a/frontend/pages/hosts/details/DeviceUserPage/BitLockerPinModal/BitLockerPinModal.tsx b/frontend/pages/hosts/details/DeviceUserPage/BitLockerPinModal/BitLockerPinModal.tsx index 9b95058825..0115d8784c 100644 --- a/frontend/pages/hosts/details/DeviceUserPage/BitLockerPinModal/BitLockerPinModal.tsx +++ b/frontend/pages/hosts/details/DeviceUserPage/BitLockerPinModal/BitLockerPinModal.tsx @@ -22,45 +22,41 @@ const BitLockerPinModal = ({ className={baseClass} width="large" > - <> -
-

-

    -
  1. -

    - Open the Start menu. -

    -
  2. -
  3. -

    Type “Manage BitLocker” and launch.

    -
  4. -
  5. -

    - Click Change how the drive is unlocked at startup. If - this option doesn't show up, wait a minute and relaunch{" "} - Manage BitLocker. -

    -
  6. -
  7. -

    - Choose Enter a PIN (recommended) and follow the prompts - to create a PIN. -

    -
  8. -
  9. -

    - Close this window and select Refetch on your{" "} - My device page. This informs your organization that you - have set a BitLocker PIN. -

    -
  10. -
-

-
- Done} - /> - +
+

+

    +
  1. +

    + Open the Start menu. +

    +
  2. +
  3. +

    Type “Manage BitLocker” and launch.

    +
  4. +
  5. +

    + Click Change how the drive is unlocked at startup. If + this option doesn't show up, wait a minute and relaunch{" "} + Manage BitLocker. +

    +
  6. +
  7. +

    + Choose Enter a PIN (recommended) and follow the prompts + to create a PIN. +

    +
  8. +
  9. +

    + Close this window and select Refetch on your{" "} + My device page. This informs your organization that you + have set a BitLocker PIN. +

    +
  10. +
+

+
+ Done} /> ); }; diff --git a/frontend/pages/hosts/details/DeviceUserPage/BypassModal/BypassModal.tsx b/frontend/pages/hosts/details/DeviceUserPage/BypassModal/BypassModal.tsx index 5fda91a380..2c14e29d81 100644 --- a/frontend/pages/hosts/details/DeviceUserPage/BypassModal/BypassModal.tsx +++ b/frontend/pages/hosts/details/DeviceUserPage/BypassModal/BypassModal.tsx @@ -13,25 +13,23 @@ interface IBypassModal { const BypassModal = ({ onCancel, onResolveLater, isLoading }: IBypassModal) => { return ( - <> -

- This will allow you to log in with Okta once. -
-
- Please resolve all policies marked "Action required" to - restore access for subsequent logins. -

-
- -
- +

+ This will allow you to log in with Okta once. +
+
+ Please resolve all policies marked "Action required" to + restore access for subsequent logins. +

+
+ +
); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/BootstrapPackageModal/BootstrapPackageModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/BootstrapPackageModal/BootstrapPackageModal.tsx index 9078998192..e70f9fe8a0 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/BootstrapPackageModal/BootstrapPackageModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/BootstrapPackageModal/BootstrapPackageModal.tsx @@ -23,18 +23,16 @@ const BootstrapPackageModal = ({ onEnter={onClose} className={baseClass} > - <> -

- {packageName} failed to install with the following error: -

-

{details}

+

+ {packageName} failed to install with the following error: +

+

{details}

-
- -
- +
+ +
); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/CancelActivityModal/CancelActivityModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/CancelActivityModal/CancelActivityModal.tsx index ed9419e52e..bc34f9f967 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/CancelActivityModal/CancelActivityModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/CancelActivityModal/CancelActivityModal.tsx @@ -54,34 +54,32 @@ const CancelActivityModal = ({ onExit={onExit} isContentDisabled={isCanceling} > - <> -
-

- If the activity is happening on the host it will still complete. - Results won't appear in Fleet. -

- -
-
- - -
- +
+

+ If the activity is happening on the host it will still complete. + Results won't appear in Fleet. +

+ +
+
+ + +
); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/LockModal/LockModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/LockModal/LockModal.tsx index 41889d6db9..bf27536275 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/LockModal/LockModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/LockModal/LockModal.tsx @@ -119,42 +119,36 @@ const LockModal = ({ return ( - <> -
-
- {renderDescription()} -
-
- - Confirm: - - setLockChecked(value)} - > - I wish to lock {hostName} - -
-
- {isIPadOrIPhone(platform) && ( - - )} -
- - + I wish to lock {hostName} +
- +
+ {isIPadOrIPhone(platform) && } +
+ + +
); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/RecoveryLockPasswordModal/RecoveryLockPasswordModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/RecoveryLockPasswordModal/RecoveryLockPasswordModal.tsx index 95948f08c6..ed4a578a9e 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/RecoveryLockPasswordModal/RecoveryLockPasswordModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/RecoveryLockPasswordModal/RecoveryLockPasswordModal.tsx @@ -49,32 +49,30 @@ const RecoveryLockPasswordModal = ({ onEnter={onCancel} className={baseClass} > - <> - {isLoading && } - {recoveryLockPasswordError ? ( - - ) : ( - !isLoading && ( - <> - -

- Use this to unlock and regain access to the host if the end user - forgets their local password.{" "} - -

-
- -
- - ) - )} - + {isLoading && } + {recoveryLockPasswordError ? ( + + ) : ( + !isLoading && ( + <> + +

+ Use this to unlock and regain access to the host if the end user + forgets their local password.{" "} + +

+
+ +
+ + ) + )} ); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/RunScriptModal/RunScriptModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/RunScriptModal/RunScriptModal.tsx index fa7943de60..e43147713f 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/RunScriptModal/RunScriptModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/RunScriptModal/RunScriptModal.tsx @@ -112,43 +112,41 @@ const RunScriptModal = ({ isLoading={isFetchingHostScripts || isLoadingHostScripts} isHidden={isHidden} > - <> -
- {isLoadingHostScripts && } - {!isLoadingHostScripts && isError && } - {!isLoadingHostScripts && - !isError && - (!tableData || tableData.length === 0) && ( - - )} - {!isLoadingHostScripts && - !isError && - tableData && - tableData.length > 0 && ( - - )} -
-
- -
- +
+ {isLoadingHostScripts && } + {!isLoadingHostScripts && isError && } + {!isLoadingHostScripts && + !isError && + (!tableData || tableData.length === 0) && ( + + )} + {!isLoadingHostScripts && + !isError && + tableData && + tableData.length > 0 && ( + + )} +
+
+ +
); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/SelectQueryModal/SelectQueryModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/SelectQueryModal/SelectQueryModal.tsx index 5f6a52dfcc..106c88d33f 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/SelectQueryModal/SelectQueryModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/SelectQueryModal/SelectQueryModal.tsx @@ -245,10 +245,8 @@ const SelectQueryModal = ({ className={baseClass} width="large" > - <> - {renderDescription()} - {renderQueries()} - + {renderDescription()} + {renderQueries()} ); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/UnlockModal/UnlockModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/UnlockModal/UnlockModal.tsx index 0eccaeb96a..dc94349d3f 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/UnlockModal/UnlockModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/UnlockModal/UnlockModal.tsx @@ -131,13 +131,11 @@ const UnlockModal = ({ return ( - <> -
- {renderModalContent()} -
+
+ {renderModalContent()} +
-
{renderModalButtons()}
- +
{renderModalButtons()}
); }; diff --git a/frontend/pages/hosts/details/HostDetailsPage/modals/WipeModal/WipeModal.tsx b/frontend/pages/hosts/details/HostDetailsPage/modals/WipeModal/WipeModal.tsx index bf78266cc9..5f96f8cd09 100644 --- a/frontend/pages/hosts/details/HostDetailsPage/modals/WipeModal/WipeModal.tsx +++ b/frontend/pages/hosts/details/HostDetailsPage/modals/WipeModal/WipeModal.tsx @@ -47,45 +47,43 @@ const WipeModal = ({ return ( - <> -
-

All content will be erased on this host.

- {isWindowsHost && ( -

- To use the host again, you will have to do a Windows reinstall - from a USB drive. -

- )} -
- - Please check to confirm: - - setLockChecked(value)} - > - I wish to wipe {hostName} - -
-
- -
- - + I wish to wipe {hostName} +
- + + +
+ + +
); }; diff --git a/frontend/pages/hosts/details/OSSettingsModal/OSSettingsModal.tsx b/frontend/pages/hosts/details/OSSettingsModal/OSSettingsModal.tsx index a738dbb2ed..025bd2a341 100644 --- a/frontend/pages/hosts/details/OSSettingsModal/OSSettingsModal.tsx +++ b/frontend/pages/hosts/details/OSSettingsModal/OSSettingsModal.tsx @@ -47,17 +47,15 @@ const OSSettingsModal = ({ className={baseClass} width="xlarge" > - <> - -
- -
- + +
+ +
); }; diff --git a/frontend/pages/hosts/details/cards/Software/SelfService/components/OpenSoftwareModal/OpenSoftwareModal.tsx b/frontend/pages/hosts/details/cards/Software/SelfService/components/OpenSoftwareModal/OpenSoftwareModal.tsx index f83b45390e..4e0e1fec61 100644 --- a/frontend/pages/hosts/details/cards/Software/SelfService/components/OpenSoftwareModal/OpenSoftwareModal.tsx +++ b/frontend/pages/hosts/details/cards/Software/SelfService/components/OpenSoftwareModal/OpenSoftwareModal.tsx @@ -40,10 +40,8 @@ const OpenSoftwareModal = ({ }: ISoftwareInstructionsModalProps) => { return ( - <> - {getOpenSoftwareInstructions(softwareName, softwareSource)} - Done} /> - + {getOpenSoftwareInstructions(softwareName, softwareSource)} + Done} /> ); }; diff --git a/frontend/pages/hosts/details/cards/Software/SelfService/components/SoftwareUpdateModal/SoftwareUpdateModal.tsx b/frontend/pages/hosts/details/cards/Software/SelfService/components/SoftwareUpdateModal/SoftwareUpdateModal.tsx index 9e8f77cc1d..63122b26c1 100644 --- a/frontend/pages/hosts/details/cards/Software/SelfService/components/SoftwareUpdateModal/SoftwareUpdateModal.tsx +++ b/frontend/pages/hosts/details/cards/Software/SelfService/components/SoftwareUpdateModal/SoftwareUpdateModal.tsx @@ -111,37 +111,35 @@ const SoftwareUpdateModal = ({ return ( - <> -
- - {showCurrentVersions && } -
- - Done - - ) : ( - <> - - - - ) - } +
+ - + {showCurrentVersions && } +
+ + Done + + ) : ( + <> + + + + ) + } + />
); }; diff --git a/frontend/pages/hosts/details/cards/Software/SelfService/components/UninstallSoftwareModal/UninstallSoftwareModal.tsx b/frontend/pages/hosts/details/cards/Software/SelfService/components/UninstallSoftwareModal/UninstallSoftwareModal.tsx index 662943c869..bf63d8971b 100644 --- a/frontend/pages/hosts/details/cards/Software/SelfService/components/UninstallSoftwareModal/UninstallSoftwareModal.tsx +++ b/frontend/pages/hosts/details/cards/Software/SelfService/components/UninstallSoftwareModal/UninstallSoftwareModal.tsx @@ -48,25 +48,22 @@ const UninstallSoftwareModal = ({ onExit={onExit} isContentDisabled={isUninstalling} > - <> -

- Uninstalling this software will remove it and may remove{" "} - {softwareName} data from your device. You can always reinstall it - again later. -

-
- - -
- +

+ Uninstalling this software will remove it and may remove {softwareName}{" "} + data from your device. You can always reinstall it again later. +

+
+ + +
); }; diff --git a/frontend/pages/hosts/details/modals/CertificateDetailsModal/CertificateDetailsModal.tsx b/frontend/pages/hosts/details/modals/CertificateDetailsModal/CertificateDetailsModal.tsx index ee8d33d987..cd84ffbe8e 100644 --- a/frontend/pages/hosts/details/modals/CertificateDetailsModal/CertificateDetailsModal.tsx +++ b/frontend/pages/hosts/details/modals/CertificateDetailsModal/CertificateDetailsModal.tsx @@ -80,185 +80,183 @@ const CertificateDetailsModal = ({ return ( - <> -
- {showSubjectSection && ( -
-

Subject name

-
- {subjectCountry && ( - } - orientation="horizontal" - /> - )} - {subjectOrganization && ( - } - orientation="horizontal" - /> - )} - {subjectOrganizationalUnit && ( - - } - orientation="horizontal" - /> - )} - {subjectCommonName && ( - } - orientation="horizontal" - /> - )} -
-
- )} - {showIssuerNameSection && ( -
-

Issuer name

-
- {issuerCountry && ( - } - orientation="horizontal" - /> - )} - {issuerOrganization && ( - } - orientation="horizontal" - /> - )} - {issuerOrganizationalUnit && ( - - } - orientation="horizontal" - /> - )} - {issuerCommonName && ( - } - orientation="horizontal" - /> - )} -
-
- )} - {showValidityPeriodSection && ( -
-

Validity period

-
- {not_valid_before && ( - - } - orientation="horizontal" - /> - )} - {not_valid_after && ( - - } - orientation="horizontal" - /> - )} -
-
- )} - {showKeyInfoSection && ( -
-

Key info

-
- {key_algorithm && ( - } - orientation="horizontal" - /> - )} - {!!key_strength && ( - } - orientation="horizontal" - /> - )} - {key_usage && ( - } - orientation="horizontal" - /> - )} - {serial && ( - } - orientation="horizontal" - /> - )} - {serialDecimal && ( - } - orientation="horizontal" - /> - )} -
-
- )} - {/* will always show this section */} +
+ {showSubjectSection && (
-

Basic constraints

+

Subject name

+
+ {subjectCountry && ( + } + orientation="horizontal" + /> + )} + {subjectOrganization && ( + } + orientation="horizontal" + /> + )} + {subjectOrganizationalUnit && ( + + } + orientation="horizontal" + /> + )} + {subjectCommonName && ( + } + orientation="horizontal" + /> + )} +
+
+ )} + {showIssuerNameSection && ( +
+

Issuer name

+
+ {issuerCountry && ( + } + orientation="horizontal" + /> + )} + {issuerOrganization && ( + } + orientation="horizontal" + /> + )} + {issuerOrganizationalUnit && ( + + } + orientation="horizontal" + /> + )} + {issuerCommonName && ( + } + orientation="horizontal" + /> + )} +
+
+ )} + {showValidityPeriodSection && ( +
+

Validity period

+
+ {not_valid_before && ( + + } + orientation="horizontal" + /> + )} + {not_valid_after && ( + + } + orientation="horizontal" + /> + )} +
+
+ )} + {showKeyInfoSection && ( +
+

Key info

+
+ {key_algorithm && ( + } + orientation="horizontal" + /> + )} + {!!key_strength && ( + } + orientation="horizontal" + /> + )} + {key_usage && ( + } + orientation="horizontal" + /> + )} + {serial && ( + } + orientation="horizontal" + /> + )} + {serialDecimal && ( + } + orientation="horizontal" + /> + )} +
+
+ )} + {/* will always show this section */} +
+

Basic constraints

+
+ + } + orientation="horizontal" + /> +
+
+ {showSignatureSection && ( +
+

Signature

- } + title="Algorithm" + value={} orientation="horizontal" />
- {showSignatureSection && ( -
-

Signature

-
- } - orientation="horizontal" - /> -
-
- )} -
-
- -
- + )} +
+
+ +
); }; diff --git a/frontend/pages/hosts/details/modals/InventoryVersionsModal/InventoryVersionsModal.tsx b/frontend/pages/hosts/details/modals/InventoryVersionsModal/InventoryVersionsModal.tsx index 15e6c6948a..5113a7e2e0 100644 --- a/frontend/pages/hosts/details/modals/InventoryVersionsModal/InventoryVersionsModal.tsx +++ b/frontend/pages/hosts/details/modals/InventoryVersionsModal/InventoryVersionsModal.tsx @@ -66,10 +66,8 @@ const InventoryVersionsModal = ({ onExit={onExit} width="large" > - <> - {renderScrollableContent()} - {renderFooter()} - + {renderScrollableContent()} + {renderFooter()} ); }; diff --git a/frontend/pages/hosts/details/modals/LocationModal/LocationModal.tsx b/frontend/pages/hosts/details/modals/LocationModal/LocationModal.tsx index 67b65b472f..cb95c72c53 100644 --- a/frontend/pages/hosts/details/modals/LocationModal/LocationModal.tsx +++ b/frontend/pages/hosts/details/modals/LocationModal/LocationModal.tsx @@ -196,10 +196,8 @@ const LocationModal = ({ return ( - <> - {renderContent()} - {renderFooter()} - + {renderContent()} + {renderFooter()} ); }; diff --git a/frontend/pages/policies/ManagePoliciesPage/components/CalendarEventPreviewModal/CalendarEventPreviewModal.tsx b/frontend/pages/policies/ManagePoliciesPage/components/CalendarEventPreviewModal/CalendarEventPreviewModal.tsx index 21a94d16ca..d6f12b247e 100644 --- a/frontend/pages/policies/ManagePoliciesPage/components/CalendarEventPreviewModal/CalendarEventPreviewModal.tsx +++ b/frontend/pages/policies/ManagePoliciesPage/components/CalendarEventPreviewModal/CalendarEventPreviewModal.tsx @@ -32,114 +32,110 @@ const CalendarEventPreviewModal = ({ onExit={onCancel} className={baseClass} > - <> - - {showGenericPreview ? ( - "What end users see:" - ) : ( - <> - End users failing only {policy.name} policy will - see: - - )} - -
-
-
-
-
-
-
- 💻 🚫 Scheduled maintenance -
-
- Tuesday, June 18 - - 5-5:30pm -
-
+ + {showGenericPreview ? ( + "What end users see:" + ) : ( + <> + End users failing only {policy.name} policy will + see: + + )} + +
+
+
+
-
-
- +
+
+ 💻 🚫 Scheduled maintenance
-
- {orgName} reserved this time to make some changes to your work - computer (Anna's MacBook Pro). -
-
- Please leave your device on and connected to power. -

- Why it matters -
-
- {showGenericPreview - ? `${orgName} needs to make sure your device meets the organization's requirements.` - : policy.description} -
-

- Maintenance required -
-
- {showGenericPreview ? ( -
    -
  • - Click the{" "} - - Fleet - {" "} - icon in your computer's menu and select{" "} - My device -
  • -
  • - Navigate to the Policies tab -
  • -
  • - Follow instructions to resolve any policies marked{" "} - {`"Fail"`} -
  • -
  • - Click Refetch -
  • -
- ) : ( - policy.resolution - )} -
-
-
-
-
- -
-
- Anna Chao +
+ Tuesday, June 18 + + 5-5:30pm
-
- {showGenericPreview ? ( - <> - Users failing only a single policy will see a more specific - explanation. - - ) : ( - <> - Why it matters and{" "} - Maintenance required are populated by the - policy's Description and{" "} - Resolution respectively. - - )} +
+
+ +
+
+ {orgName} reserved this time to make some changes to your work + computer (Anna's MacBook Pro). +
+
+ Please leave your device on and connected to power. +

+ Why it matters +
+
+ {showGenericPreview + ? `${orgName} needs to make sure your device meets the organization's requirements.` + : policy.description} +
+

+ Maintenance required +
+
+ {showGenericPreview ? ( +
    +
  • + Click the{" "} + + Fleet + {" "} + icon in your computer's menu and select{" "} + My device +
  • +
  • + Navigate to the Policies tab +
  • +
  • + Follow instructions to resolve any policies marked{" "} + {`"Fail"`} +
  • +
  • + Click Refetch +
  • +
+ ) : ( + policy.resolution + )} +
+
-
- +
+
+ +
+
Anna Chao
- +
+
+ {showGenericPreview ? ( + <> + Users failing only a single policy will see a more specific + explanation. + + ) : ( + <> + Why it matters and{" "} + Maintenance required are populated by the + policy's Description and{" "} + Resolution respectively. + + )} +
+
+ +
); };