From 0e0ae68b3f0af2eed13fe5fe41e1052397176cde Mon Sep 17 00:00:00 2001 From: Magnus Jensen Date: Fri, 1 May 2026 11:02:12 -0600 Subject: [PATCH] remove activity details list (#44513) This is no longer used, but gets flagged by AI. https://github.com/fleetdm/fleet/pull/44511#discussion_r3169700014 ## Summary by CodeRabbit * **Refactor** * Removed a now-redundant exported activity list from the codebase, simplifying internal activity declarations. This streamlines internal structures without changing user-visible behavior or altering existing activity types. --- server/fleet/activities.go | 189 ------------------------------------- 1 file changed, 189 deletions(-) diff --git a/server/fleet/activities.go b/server/fleet/activities.go index cf4a66d8a3..a2b857cae7 100644 --- a/server/fleet/activities.go +++ b/server/fleet/activities.go @@ -60,195 +60,6 @@ type UpcomingActivityMeta struct { WellKnownAction WellKnownActionType `db:"well_known_action"` } -// ActivityDetailsList is used to generate documentation. -var ActivityDetailsList = []ActivityDetails{ - ActivityTypeCreatedPack{}, - ActivityTypeEditedPack{}, - ActivityTypeDeletedPack{}, - ActivityTypeAppliedSpecPack{}, - - ActivityTypeCreatedPolicy{}, - ActivityTypeEditedPolicy{}, - ActivityTypeDeletedPolicy{}, - ActivityTypeAppliedSpecPolicy{}, - ActivityTypeCreatedSavedQuery{}, - ActivityTypeEditedSavedQuery{}, - ActivityTypeDeletedSavedQuery{}, - ActivityTypeDeletedMultipleSavedQuery{}, - ActivityTypeAppliedSpecSavedQuery{}, - - ActivityTypeCreatedTeam{}, - ActivityTypeDeletedTeam{}, - ActivityTypeAppliedSpecTeam{}, - ActivityTypeTransferredHostsToTeam{}, - - ActivityTypeEditedAgentOptions{}, - - ActivityTypeLiveQuery{}, - - ActivityTypeUserAddedBySSO{}, - - ActivityTypeUserLoggedIn{}, - ActivityTypeUserFailedLogin{}, - - ActivityTypeCreatedUser{}, - ActivityTypeDeletedUser{}, - ActivityTypeDeletedHost{}, - ActivityTypeChangedUserGlobalRole{}, - ActivityTypeDeletedUserGlobalRole{}, - ActivityTypeChangedUserTeamRole{}, - ActivityTypeDeletedUserTeamRole{}, - - ActivityTypeFleetEnrolled{}, - ActivityTypeMDMEnrolled{}, - ActivityTypeMDMUnenrolled{}, - - ActivityTypeEditedMacOSMinVersion{}, - ActivityTypeEditedIOSMinVersion{}, - ActivityTypeEditedIPadOSMinVersion{}, - ActivityTypeEditedWindowsUpdates{}, - ActivityTypeEnabledMacosUpdateNewHosts{}, - ActivityTypeDisabledMacosUpdateNewHosts{}, - - ActivityTypeReadHostDiskEncryptionKey{}, - ActivityTypeViewedHostRecoveryLockPassword{}, - - ActivityTypeCreatedMacosProfile{}, - ActivityTypeDeletedMacosProfile{}, - ActivityTypeEditedMacosProfile{}, - - ActivityTypeChangedMacosSetupAssistant{}, - ActivityTypeDeletedMacosSetupAssistant{}, - - ActivityTypeEnabledMacosDiskEncryption{}, - ActivityTypeDisabledMacosDiskEncryption{}, - - ActivityTypeSetHostRecoveryLockPassword{}, - ActivityTypeEnabledRecoveryLockPasswords{}, - ActivityTypeDisabledRecoveryLockPasswords{}, - - ActivityTypeEnabledGitOpsMode{}, - ActivityTypeDisabledGitOpsMode{}, - ActivityTypeEnabledGitOpsException{}, - ActivityTypeDisabledGitOpsException{}, - - ActivityTypeAddedBootstrapPackage{}, - ActivityTypeDeletedBootstrapPackage{}, - - ActivityTypeEnabledMacosSetupEndUserAuth{}, - ActivityTypeDisabledMacosSetupEndUserAuth{}, - - ActivityTypeEnabledWindowsMDM{}, - ActivityTypeDisabledWindowsMDM{}, - ActivityTypeEnabledAndroidMDM{}, - ActivityTypeDisabledAndroidMDM{}, - ActivityTypeEnabledWindowsMDMMigration{}, - ActivityTypeDisabledWindowsMDMMigration{}, - - ActivityTypeRanScript{}, - ActivityTypeAddedScript{}, - ActivityTypeDeletedScript{}, - ActivityTypeEditedScript{}, // via GitOps - ActivityTypeUpdatedScript{}, // via individual script update endpoint - - ActivityTypeCreatedWindowsProfile{}, - ActivityTypeDeletedWindowsProfile{}, - ActivityTypeEditedWindowsProfile{}, - - ActivityTypeLockedHost{}, - ActivityTypeUnlockedHost{}, - ActivityTypeWipedHost{}, - ActivityTypeWipeFailedHost{}, - ActivityTypeRotatedHostRecoveryLockPassword{}, - - ActivityTypeCreatedDeclarationProfile{}, - ActivityTypeDeletedDeclarationProfile{}, - ActivityTypeEditedDeclarationProfile{}, - - ActivityTypeCreatedAndroidProfile{}, - ActivityTypeDeletedAndroidProfile{}, - ActivityTypeEditedAndroidProfile{}, - ActivityTypeEditedAndroidCertificate{}, - ActivityTypeResentCertificate{}, - ActivityTypeInstalledCertificate{}, - - ActivityTypeResentConfigurationProfile{}, - ActivityTypeResentConfigurationProfileBatch{}, - - ActivityTypeInstalledSoftware{}, - ActivityTypeUninstalledSoftware{}, - ActivityTypeAddedSoftware{}, - ActivityTypeEditedSoftware{}, - ActivityTypeDeletedSoftware{}, - ActivityEnabledVPP{}, - ActivityDisabledVPP{}, - ActivityAddedAppStoreApp{}, - ActivityDeletedAppStoreApp{}, - ActivityInstalledAppStoreApp{}, - ActivityEditedAppStoreApp{}, - - ActivityAddedNDESSCEPProxy{}, - ActivityDeletedNDESSCEPProxy{}, - ActivityEditedNDESSCEPProxy{}, - ActivityAddedCustomSCEPProxy{}, - ActivityDeletedCustomSCEPProxy{}, - ActivityEditedCustomSCEPProxy{}, - ActivityAddedDigiCert{}, - ActivityDeletedDigiCert{}, - ActivityEditedDigiCert{}, - ActivityAddedHydrant{}, - ActivityDeletedHydrant{}, - ActivityEditedHydrant{}, - ActivityAddedCustomESTProxy{}, - ActivityDeletedCustomESTProxy{}, - ActivityEditedCustomESTProxy{}, - ActivityAddedSmallstep{}, - ActivityDeletedSmallstep{}, - ActivityEditedSmallstep{}, - - ActivityTypeEnabledActivityAutomations{}, - ActivityTypeEditedActivityAutomations{}, - ActivityTypeDisabledActivityAutomations{}, - - ActivityTypeCanceledRunScript{}, - ActivityTypeCanceledInstallSoftware{}, - ActivityTypeCanceledUninstallSoftware{}, - ActivityTypeCanceledInstallAppStoreApp{}, - - ActivityTypeRanScriptBatch{}, - ActivityTypeBatchScriptScheduled{}, - ActivityTypeBatchScriptCanceled{}, - - ActivityTypeAddedConditionalAccessIntegrationMicrosoft{}, - ActivityTypeDeletedConditionalAccessIntegrationMicrosoft{}, - ActivityTypeAddedConditionalAccessOkta{}, - ActivityTypeDeletedConditionalAccessOkta{}, - ActivityTypeEnabledConditionalAccessAutomations{}, - ActivityTypeDisabledConditionalAccessAutomations{}, - - ActivityTypeEscrowedDiskEncryptionKey{}, - - ActivityCreatedCustomVariable{}, - ActivityDeletedCustomVariable{}, - - ActivityEditedSetupExperienceSoftware{}, - - ActivityTypeEditedHostIdpData{}, - - ActivityTypeEditedEnrollSecrets{}, - - ActivityTypeCreatedManagedLocalAccount{}, - ActivityTypeViewedManagedLocalAccount{}, - ActivityTypeEnabledManagedLocalAccount{}, - ActivityTypeDisabledManagedLocalAccount{}, - - ActivityTypeCanceledSetupExperience{}, - - ActivityTypeCreatedLabel{}, - ActivityTypeEditedLabel{}, - ActivityTypeDeletedLabel{}, -} - // ActivityDetails is an alias for the canonical ActivityDetails interface defined in server/activity/api. type ActivityDetails = api.ActivityDetails