Contributing Fleet-maintained apps (#35235)
- Simplify steps. Why? Fewer handoffs / approvals - #g-software EM reviews all PRs within 3 business days - Commit to automated tests. No need to do manual testing because the CI already installs the app and checks, via osquery, if the install/uninstalls worked - Remove issue template Why now? - https://github.com/fleetdm/confidential/issues/12844 --------- Co-authored-by: Martin Angers <martin.n.angers@gmail.com> Co-authored-by: George Karr <georgekarrv@users.noreply.github.com>
This commit is contained in:
co-authored by
Martin Angers
George Karr
parent
b7742c9c20
commit
1c1e19197c
@@ -1,37 +0,0 @@
|
||||
---
|
||||
name: 📦 New Fleet-maintained app
|
||||
about: Request to add an app to the Fleet-maintained app catalog
|
||||
title: 'New FMA: <App Name>'
|
||||
labels: ':release,#g-software,fma'
|
||||
assignees: 'marko-lisica'
|
||||
|
||||
---
|
||||
|
||||
### Requestor
|
||||
|
||||
- Application name: TODO
|
||||
- Application platform: TODO (macOS/Windows)
|
||||
|
||||
---
|
||||
|
||||
### Validation
|
||||
|
||||
- [ ] The following outputs are generated
|
||||
- `/outputs/<app-name>/darwin.json` created
|
||||
- `/outputs/apps.json` updated
|
||||
- [ ] Manifest name matches osquery `app.name` (macOS) or `programs.name` (Windows)
|
||||
- [ ] Manifest version scheme matches osquery `app.short_bundle_version` (macOS) or `programs.version` (Windows) version scheme
|
||||
- [ ] Manifest `unique_identifier` matches osquery `app.bundle_identifier` (macOS only)
|
||||
|
||||
### QA
|
||||
|
||||
- [ ] App adds successfully to team's library
|
||||
- [ ] App installs successfully on host
|
||||
- [ ] App opens successfully on host
|
||||
- [ ] App uninstalls successfully on host
|
||||
|
||||
### Icon
|
||||
|
||||
- [ ] Icon added to Figma
|
||||
- [ ] Icon added to Fleet
|
||||
- [ ] Correct icon appears in the app catalog
|
||||
Reference in New Issue
Block a user