From 31cd1e89d3f0e97de5dd97796bca007ffc4a866f Mon Sep 17 00:00:00 2001
From: Jacob Shandling <61553566+jacobshandling@users.noreply.github.com>
Date: Tue, 20 Feb 2024 11:49:34 -0800
Subject: [PATCH] =?UTF-8?q?UI=20=E2=80=93=20Uncover=20the=20"Done"=20butto?=
=?UTF-8?q?n=20on=20Add=20hosts=20>=20advanced=20>=20plain=20osquery=20(#1?=
=?UTF-8?q?7002)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
## –> #16998
- [x] Changes file added for user-visible changes in `changes/`
- [x] Manual QA for all new/changed functionality
---------
Co-authored-by: Jacob Shandling
---
changes/16998-covered-done-button | 1 +
.../AddHostsModal/PlatformWrapper/_styles.scss | 11 ++++++++---
2 files changed, 9 insertions(+), 3 deletions(-)
create mode 100644 changes/16998-covered-done-button
diff --git a/changes/16998-covered-done-button b/changes/16998-covered-done-button
new file mode 100644
index 0000000000..92849e7ebe
--- /dev/null
+++ b/changes/16998-covered-done-button
@@ -0,0 +1 @@
+- Fix a bug where the "Done" button on the add hosts modal for plain osquery could be covered.
diff --git a/frontend/components/AddHostsModal/PlatformWrapper/_styles.scss b/frontend/components/AddHostsModal/PlatformWrapper/_styles.scss
index dfc0fe2703..7182a6968b 100644
--- a/frontend/components/AddHostsModal/PlatformWrapper/_styles.scss
+++ b/frontend/components/AddHostsModal/PlatformWrapper/_styles.scss
@@ -2,9 +2,14 @@
.platform-wrapper {
padding: 0; // different to pad sticky subnav properly
- .react-tabs {
- &__tab-list {
- margin: 0 0 1.25rem;
+
+ .component__tabs-wrapper {
+ // negate problematic sticky positioning
+ position: initial;
+ .react-tabs {
+ &__tab-list {
+ margin: 0 0 1.25rem;
+ }
}
}