diff --git a/changes/34984-spinner-elevated-background b/changes/34984-spinner-elevated-background new file mode 100644 index 0000000000..fc31d4818e --- /dev/null +++ b/changes/34984-spinner-elevated-background @@ -0,0 +1 @@ +- Removed the elevated white background container from the loading spinner for a flatter, more consistent look. diff --git a/frontend/components/LiveQuery/SelectTargets.tsx b/frontend/components/LiveQuery/SelectTargets.tsx index c6e547b936..39a7e3d78a 100644 --- a/frontend/components/LiveQuery/SelectTargets.tsx +++ b/frontend/components/LiveQuery/SelectTargets.tsx @@ -482,7 +482,6 @@ const SelectTargets = ({ <> diff --git a/frontend/components/Spinner/Spinner.tsx b/frontend/components/Spinner/Spinner.tsx index 5e73b5e4f5..4feb4eba22 100644 --- a/frontend/components/Spinner/Spinner.tsx +++ b/frontend/components/Spinner/Spinner.tsx @@ -12,8 +12,6 @@ interface ISpinnerProps { size?: Size; /** The size of the spinner padding. `"medium"` 120px (default), `"small"` 60px */ verticalPadding?: PaddingSize; - /** Include the background container styling for the spinner. defaults: `true` */ - includeContainer?: boolean; /** Center the spinner in its parent. defaults: `true` */ centered?: boolean; className?: string; @@ -34,7 +32,6 @@ const Spinner = ({ white, size = "medium", verticalPadding = "medium", - includeContainer = true, centered = true, className, variant = undefined, @@ -56,7 +53,6 @@ const Spinner = ({ white, centered, "small-padding": verticalPadding === "small", - "include-container": includeContainer && variant !== "mobile", "mobile-view": variant === "mobile", }); return ( diff --git a/frontend/components/Spinner/_styles.scss b/frontend/components/Spinner/_styles.scss index 61ad4c53dd..a252e23a3e 100644 --- a/frontend/components/Spinner/_styles.scss +++ b/frontend/components/Spinner/_styles.scss @@ -16,14 +16,6 @@ height: 100vh; } - &.include-container { - background-color: $core-fleet-white; - box-shadow: 0px 4px 16px rgba(0, 0, 0, 0.1); - border-radius: 8px; - width: 48px; - height: 48px; - } - .loader { position: relative; margin: 0 auto; diff --git a/frontend/components/TableContainer/DataTable/SetupScriptStatusCell/SetupScriptStatusCell.tsx b/frontend/components/TableContainer/DataTable/SetupScriptStatusCell/SetupScriptStatusCell.tsx index b100d9cfcd..4c6b40e5be 100644 --- a/frontend/components/TableContainer/DataTable/SetupScriptStatusCell/SetupScriptStatusCell.tsx +++ b/frontend/components/TableContainer/DataTable/SetupScriptStatusCell/SetupScriptStatusCell.tsx @@ -36,7 +36,7 @@ const SetupScriptStatusCell = ({ status }: ISetupScriptStatusCell) => {
{icon === "spinner" ? ( - + ) : ( )} diff --git a/frontend/components/TableContainer/DataTable/SetupSoftwareStatusCell/SetupSoftwareStatusCell.tsx b/frontend/components/TableContainer/DataTable/SetupSoftwareStatusCell/SetupSoftwareStatusCell.tsx index cbb65292cb..e5c0c6fe9c 100644 --- a/frontend/components/TableContainer/DataTable/SetupSoftwareStatusCell/SetupSoftwareStatusCell.tsx +++ b/frontend/components/TableContainer/DataTable/SetupSoftwareStatusCell/SetupSoftwareStatusCell.tsx @@ -36,7 +36,7 @@ const SetupSoftwareStatusCell = ({ status }: ISetupSoftwareStatusCell) => {
{icon === "spinner" ? ( - + ) : ( )} diff --git a/frontend/components/queries/LiveResults/LiveResultsHeading/LiveResultsHeading.tsx b/frontend/components/queries/LiveResults/LiveResultsHeading/LiveResultsHeading.tsx index c10d497131..3785bec869 100644 --- a/frontend/components/queries/LiveResults/LiveResultsHeading/LiveResultsHeading.tsx +++ b/frontend/components/queries/LiveResults/LiveResultsHeading/LiveResultsHeading.tsx @@ -142,7 +142,6 @@ const LiveResultsHeading = ({ )} diff --git a/frontend/pages/DashboardPage/DashboardPage.tsx b/frontend/pages/DashboardPage/DashboardPage.tsx index 32bf7e65af..279dc1941d 100644 --- a/frontend/pages/DashboardPage/DashboardPage.tsx +++ b/frontend/pages/DashboardPage/DashboardPage.tsx @@ -968,7 +968,7 @@ const DashboardPage = ({ router, location }: IDashboardProps): JSX.Element => {
{isHostSummaryFetching ? ( - + ) : ( HostCountCards diff --git a/frontend/pages/DashboardPage/cards/ChartCard/ChartCard.tsx b/frontend/pages/DashboardPage/cards/ChartCard/ChartCard.tsx index a57dfbe7d4..2a53651742 100644 --- a/frontend/pages/DashboardPage/cards/ChartCard/ChartCard.tsx +++ b/frontend/pages/DashboardPage/cards/ChartCard/ChartCard.tsx @@ -397,7 +397,7 @@ const ChartCard = ({ ); } if (isLoading) { - return ; + return ; } if (error) { return ; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx index cb6efbe5f9..7fb86442a0 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx @@ -766,11 +766,7 @@ const EditIconModal = ({ title="Edit appearance" onExit={onExitEditIconModal} > - {isFirstLoadWithCustomIcon ? ( - - ) : ( - renderForm() - )} + {isFirstLoadWithCustomIcon ? : renderForm()}
- +
); diff --git a/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx b/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx index f933ad1f0b..27835e06bd 100644 --- a/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx +++ b/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx @@ -951,7 +951,7 @@ const DeviceUserPage = ({
{isLoadingDupDetails ? ( - + ) : ( )} diff --git a/frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx b/frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx index 4facc59297..85860fd964 100644 --- a/frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx +++ b/frontend/pages/hosts/details/cards/Software/InstallStatusCell/InstallStatusCell.tsx @@ -575,12 +575,7 @@ const InstallStatusCell = ({ > {(isSelfService || isHostOnline) && displayConfig.iconName === "pending-outline" ? ( - + ) : ( displayConfig?.iconName && ( { return ( <> - + {getPendingOrRunningLabel(software.ui_status)} ); diff --git a/frontend/pages/hosts/details/cards/Software/SelfService/components/UpdatesCard/UpdateSoftwareItem/UpdateSoftwareItem.tsx b/frontend/pages/hosts/details/cards/Software/SelfService/components/UpdatesCard/UpdateSoftwareItem/UpdateSoftwareItem.tsx index a274ea26fd..2b6dd0be0f 100644 --- a/frontend/pages/hosts/details/cards/Software/SelfService/components/UpdatesCard/UpdateSoftwareItem/UpdateSoftwareItem.tsx +++ b/frontend/pages/hosts/details/cards/Software/SelfService/components/UpdatesCard/UpdateSoftwareItem/UpdateSoftwareItem.tsx @@ -118,12 +118,7 @@ const InstallerStatus = ({ >
{displayConfig.iconName === "pending-outline" && ( - + )} {last_install && displayConfig.displayText === "Failed" && ( @@ -176,13 +171,7 @@ const InstallerStatusAction = ({ if (ui_status === "updating") { return ( <> - {" "} - Updating...{" "} + Updating...{" "} ); }