From 3c2fa3f69cff5fdf8bf770be009d9f92c8a8f9a7 Mon Sep 17 00:00:00 2001 From: John Murphy Date: Wed, 2 Aug 2017 14:02:43 -0500 Subject: [PATCH] attribute shouldn't appear in request if empty (#1541) ProtocolBinding is an optional attribute in the SAML spec, and shouldn't appear in the request xml if it is not populated. --- server/sso/types.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/sso/types.go b/server/sso/types.go index b2469b2721..37b929b7f2 100644 --- a/server/sso/types.go +++ b/server/sso/types.go @@ -12,7 +12,7 @@ type AuthnRequest struct { SAMLSIG string `xml:"xmlns:samlsig,attr,omitempty"` ID string `xml:"ID,attr"` Version string `xml:"Version,attr"` - ProtocolBinding string `xml:"ProtocolBinding,attr"` + ProtocolBinding string `xml:"ProtocolBinding,attr,omitempty"` AssertionConsumerServiceURL string `xml:"AssertionConsumerServiceURL,attr"` Destination string `xml:"Destination,attr"` IssueInstant string `xml:"IssueInstant,attr"`