From 4531a0aa7ad89bc15068e6290cdfd83b26f7b19a Mon Sep 17 00:00:00 2001 From: Mike McNeil Date: Sat, 26 Mar 2022 00:09:30 -0500 Subject: [PATCH] GitHub webhook: fixes #4827 (#4828) followup fix for #4827 (this is what I get for rushing) --- website/api/controllers/webhooks/receive-from-github.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/website/api/controllers/webhooks/receive-from-github.js b/website/api/controllers/webhooks/receive-from-github.js index 9dbd47280c..d7a6b77b31 100644 --- a/website/api/controllers/webhooks/receive-from-github.js +++ b/website/api/controllers/webhooks/receive-from-github.js @@ -243,7 +243,7 @@ module.exports = { require('assert')(sender.login !== undefined); sails.log.verbose(`…checking DRI of changed path "${changedPath}"`); - let selfMergers = DRI_BY_PATH[changedPath] ? [].concat(DRI_BY_PATH[changedPath]) : undefined;// « ensure array + let selfMergers = DRI_BY_PATH[changedPath] ? [].concat(DRI_BY_PATH[changedPath]) : [];// « ensure array if (selfMergers.includes(sender.login) || (isSenderMaintainer && selfMergers.includes('*'))) { return true; }//• @@ -251,7 +251,7 @@ module.exports = { while (numRemainingPathsToCheck > 0) { let ancestralPath = changedPath.split('/').slice(0, -1 * numRemainingPathsToCheck).join('/'); sails.log.verbose(`…checking DRI of ancestral path "${ancestralPath}" for changed path`); - let selfMergers = DRI_BY_PATH[ancestralPath] ? [].concat(DRI_BY_PATH[ancestralPath]) : undefined;// « ensure array + let selfMergers = DRI_BY_PATH[ancestralPath] ? [].concat(DRI_BY_PATH[ancestralPath]) : [];// « ensure array if (selfMergers.includes(sender.login) || (isSenderMaintainer && selfMergers.includes('*'))) { return true; }//•