From 4676042542aa578a69b9926945083a6b41be64e2 Mon Sep 17 00:00:00 2001 From: Steven Palmesano <3100993+spalmesano0@users.noreply.github.com> Date: Mon, 25 May 2026 07:38:05 -0500 Subject: [PATCH] Update note about no-teams -> unassigned (#45486) On my Fleet instance, "No team" was automatically named "Unassigned" in the UI. If this isn't the case for a user, they need to rename the fleet in the UI first, before changing the name in git. Reference: https://github.com/fleetdm/fleet/blob/main/docs/Configuration/yaml-files.md#:~:text=When%20renaming%20a,g.%20software%20packages > When renaming a fleet, first update the name in the UI, then update your YAML. # Checklist for submitter ## Testing - [ ] Added/updated automated tests - [ ] QA'd all new/changed functionality manually ## Summary by CodeRabbit * **Documentation** * Updated deprecation warning message for legacy configuration files to provide clearer migration instructions, guiding users to update fleet names and rename files to align with new naming conventions. [![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/fleetdm/fleet/pull/45486) --- cmd/fleetctl/fleetctl/gitops.go | 2 +- pkg/spec/gitops.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/fleetctl/fleetctl/gitops.go b/cmd/fleetctl/fleetctl/gitops.go index d70d34f87a..9a1e37a08b 100644 --- a/cmd/fleetctl/fleetctl/gitops.go +++ b/cmd/fleetctl/fleetctl/gitops.go @@ -256,7 +256,7 @@ func gitopsCommand() *cli.Command { // Log a deprecation warning if the user is still using no-team.yml if noTeamPresent && noTeamFilename == "no-team.yml" { if logging.TopicEnabled(logging.DeprecatedFieldTopic) { - logf("[!] no-team.yml is deprecated; please rename the file to 'unassigned.yml' and update the team name to 'Unassigned'.\n") + logf("[!] no-team.yml is deprecated; please ensure the fleet name has been updated to 'Unassigned' and rename the file to 'unassigned.yml'.\n") } } diff --git a/pkg/spec/gitops.go b/pkg/spec/gitops.go index 907afb50d6..4f21a2c019 100644 --- a/pkg/spec/gitops.go +++ b/pkg/spec/gitops.go @@ -476,7 +476,7 @@ func GitOpsFromFile(filePath, baseDir string, appConfig *fleet.EnrichedAppConfig return result, multiError.ErrorOrNil() case result.IsNoTeam() && filepath.Base(filePath) != "no-team.yml": multiError = multierror.Append(multiError, fmt.Errorf("file `%s` for No Team must be named `no-team.yml`", filePath)) - multiError = multierror.Append(multiError, errors.New("no-team.yml is deprecated; please rename the file to 'unassigned.yml' and update the team name to 'Unassigned'.")) + multiError = multierror.Append(multiError, errors.New("no-team.yml is deprecated; please ensure the fleet name has been updated to 'Unassigned' and rename the file to 'unassigned.yml'.")) return result, multiError.ErrorOrNil() case result.IsUnassignedTeam() && filepath.Base(filePath) != "unassigned.yml": multiError = multierror.Append(multiError, fmt.Errorf("file `%s` for unassigned hosts must be named `unassigned.yml`", filePath))