diff --git a/frontend/components/DeviceUserError/_styles.scss b/frontend/components/DeviceUserError/_styles.scss
index 2cd30a1901..c0378eadc1 100644
--- a/frontend/components/DeviceUserError/_styles.scss
+++ b/frontend/components/DeviceUserError/_styles.scss
@@ -10,8 +10,14 @@
}
.info {
+ display: flex;
+ flex-direction: column;
+ gap: $pad-large;
+ max-width: 333px;
+
&__header {
display: block;
+ gap: $pad-large;
color: $core-fleet-black;
font-weight: $bold;
font-size: $x-small;
@@ -30,7 +36,7 @@
font-weight: normal;
font-size: $x-small;
text-align: center;
- margin-top: 10px;
+ line-height: 21px; // Matches design
}
}
}
diff --git a/frontend/pages/DashboardPage/DashboardPage.tsx b/frontend/pages/DashboardPage/DashboardPage.tsx
index 73b69b62af..7273ffbdd4 100644
--- a/frontend/pages/DashboardPage/DashboardPage.tsx
+++ b/frontend/pages/DashboardPage/DashboardPage.tsx
@@ -60,6 +60,7 @@ import { CustomOptionType } from "components/forms/fields/DropdownWrapper/Dropdo
import MainContent from "components/MainContent";
import LastUpdatedText from "components/LastUpdatedText";
import Card from "components/Card";
+import DataError from "components/DataError";
import {
LOW_DISK_SPACE_GB,
@@ -556,7 +557,11 @@ const DashboardPage = ({ router, location }: IDashboardProps): JSX.Element => {
]
);
- const HostCountCards = (
+ const HostCountCards = errorHosts ? (
+
+
+
+ ) : (
<>
{
androidCount={androidCount}
builtInLabels={labels}
selectedPlatform={selectedPlatform}
- errorHosts={!!errorHosts}
totalHostCount={
!isHostSummaryFetching && !errorHosts
? hostSummaryData?.totals_hosts_count
@@ -580,7 +584,6 @@ const DashboardPage = ({ router, location }: IDashboardProps): JSX.Element => {
{
- return ;
+ return ;
};
const renderNoActivities = () => {
diff --git a/frontend/pages/DashboardPage/cards/ActivityFeed/_styles.scss b/frontend/pages/DashboardPage/cards/ActivityFeed/_styles.scss
index fba5d1e5fb..9316620e4d 100644
--- a/frontend/pages/DashboardPage/cards/ActivityFeed/_styles.scss
+++ b/frontend/pages/DashboardPage/cards/ActivityFeed/_styles.scss
@@ -55,36 +55,6 @@
}
}
- &__error {
- display: flex;
- flex-direction: column;
- align-items: center;
- margin: $pad-xlarge 0;
-
- &__inner {
- display: flex;
- flex-direction: row;
- }
-
- .info {
- &__header {
- display: block;
- color: $core-fleet-black;
- font-weight: $bold;
- font-size: $x-small;
- text-align: left;
- }
- &__data {
- display: block;
- color: $core-fleet-black;
- font-weight: normal;
- font-size: $x-small;
- text-align: left;
- margin-top: 10px;
- }
- }
- }
-
.spinner {
z-index: 11;
opacity: 1;
diff --git a/frontend/pages/DashboardPage/cards/MDM/MDM.tsx b/frontend/pages/DashboardPage/cards/MDM/MDM.tsx
index b1d85663b6..b7a8196c58 100644
--- a/frontend/pages/DashboardPage/cards/MDM/MDM.tsx
+++ b/frontend/pages/DashboardPage/cards/MDM/MDM.tsx
@@ -8,7 +8,7 @@ import TabNav from "components/TabNav";
import TabText from "components/TabText";
import TableContainer from "components/TableContainer";
import Spinner from "components/Spinner";
-import TableDataError from "components/DataError";
+import DataError from "components/DataError";
import EmptyTable from "components/EmptyTable";
import CustomLink from "components/CustomLink";
@@ -152,7 +152,7 @@ const Mdm = ({
{error ? (
-
+
) : (
className={`${baseClass}__mdm-solutions-table`}
@@ -175,7 +175,7 @@ const Mdm = ({
{error ? (
-
+
) : (
{errorMacAdmins ? (
-
+
) : (
{errorMacAdmins ? (
-
+
) : (
{error?.status && error?.status >= 500 ? (
-
+
) : (
{!isSoftwareFetching && errorSoftware ? (
-
+
) : (
{!isSoftwareFetching && errorSoftware ? (
-
+
) : (
{
- if (errorHosts) {
- return ;
- }
-
const TotalHostsCard = (
{
@@ -252,10 +251,6 @@ const PlatformHostCounts = ({
}
};
- if (errorHosts) {
- return ;
- }
-
return {renderCounts(currentTeamId)}
;
};
diff --git a/frontend/pages/ManageControlsPage/OSUpdates/components/CurrentVersionSection/CurrentVersionSection.tsx b/frontend/pages/ManageControlsPage/OSUpdates/components/CurrentVersionSection/CurrentVersionSection.tsx
index 956048b963..49bae677d0 100644
--- a/frontend/pages/ManageControlsPage/OSUpdates/components/CurrentVersionSection/CurrentVersionSection.tsx
+++ b/frontend/pages/ManageControlsPage/OSUpdates/components/CurrentVersionSection/CurrentVersionSection.tsx
@@ -104,7 +104,7 @@ const CurrentVersionSection = ({
if (isError) {
return (
diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStoreVpp/SoftwareAppStoreVpp.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStoreVpp/SoftwareAppStoreVpp.tsx
index f852cd501f..13d32fc551 100644
--- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStoreVpp/SoftwareAppStoreVpp.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStoreVpp/SoftwareAppStoreVpp.tsx
@@ -196,7 +196,7 @@ const SoftwareAppStoreVpp = ({
}
if (errorVppInfo || errorVppApps || isErrorLabels) {
- return ;
+ return ;
}
if (noVppTokenUploaded) {
diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/SoftwareCustomPackage.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/SoftwareCustomPackage.tsx
index 679bbe9c93..3057c99fb0 100644
--- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/SoftwareCustomPackage.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/SoftwareCustomPackage.tsx
@@ -161,7 +161,7 @@ const SoftwareCustomPackage = ({
}
if (isErrorLabels) {
- return ;
+ return ;
}
return (
diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/_styles.scss b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/_styles.scss
index 0518b00ab8..79d59f0146 100644
--- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/_styles.scss
+++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareCustomPackage/_styles.scss
@@ -2,8 +2,4 @@
&__premium-message {
margin-top: $pad-xxxlarge;
}
-
- &__data-error {
- margin-top: $pad-xxxlarge;
- }
}
diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx
index 095fa769fd..45a6ffd5e5 100644
--- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/FleetMaintainedAppDetailsPage.tsx
@@ -252,7 +252,7 @@ const FleetMaintainedAppDetailsPage = ({
}
if (isErrorFleetApp || isErrorLabels) {
- return ;
+ return ;
}
if (fleetApp) {
diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/_styles.scss b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/_styles.scss
index 606a83e11f..56b01d1b1f 100644
--- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/_styles.scss
+++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppDetailsPage/_styles.scss
@@ -1,8 +1,4 @@
.fleet-maintained-app-details-page {
- &__data-error {
- margin-top: $pad-xxlarge;
- }
-
&__back-to-add-software {
margin-bottom: $pad-medium;
}
diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/SoftwareFleetMaintained.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/SoftwareFleetMaintained.tsx
index c0b3b0c8d8..114c1df3bb 100644
--- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/SoftwareFleetMaintained.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/SoftwareFleetMaintained.tsx
@@ -100,7 +100,7 @@ const SoftwareFleetMaintained = ({
}
if (isError) {
- return ;
+ return ;
}
return (
diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/_styles.scss b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/_styles.scss
index d0b492c842..257bcf928f 100644
--- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/_styles.scss
+++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/_styles.scss
@@ -1,5 +1,5 @@
.software-fleet-maintained {
- &__premium-message, &__table-error {
+ &__premium-message {
margin-top: $pad-xxxlarge;
}
}
diff --git a/frontend/pages/SoftwarePage/SoftwareOS/SoftwareOS.tsx b/frontend/pages/SoftwarePage/SoftwareOS/SoftwareOS.tsx
index 3679577840..3878cd6efb 100644
--- a/frontend/pages/SoftwarePage/SoftwareOS/SoftwareOS.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareOS/SoftwareOS.tsx
@@ -71,7 +71,7 @@ const SoftwareOS = ({
}
if (isError) {
- return ;
+ return ;
}
return (
diff --git a/frontend/pages/SoftwarePage/SoftwareTitles/SoftwareTitles.tsx b/frontend/pages/SoftwarePage/SoftwareTitles/SoftwareTitles.tsx
index dceab84c20..80c76985eb 100644
--- a/frontend/pages/SoftwarePage/SoftwareTitles/SoftwareTitles.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareTitles/SoftwareTitles.tsx
@@ -174,7 +174,7 @@ const SoftwareTitles = ({
}
if (isTitlesError || isVersionsError || isTitlesAFIError) {
- return ;
+ return ;
}
return (
diff --git a/frontend/pages/SoftwarePage/SoftwareTitles/_styles.scss b/frontend/pages/SoftwarePage/SoftwareTitles/_styles.scss
deleted file mode 100644
index 6df9667e4d..0000000000
--- a/frontend/pages/SoftwarePage/SoftwareTitles/_styles.scss
+++ /dev/null
@@ -1,5 +0,0 @@
-.software-titles {
- &__table-error {
- margin-top: $pad-xxxlarge;
- }
-}
diff --git a/frontend/pages/SoftwarePage/SoftwareVulnerabilities/SoftwareVulnerabilities.tsx b/frontend/pages/SoftwarePage/SoftwareVulnerabilities/SoftwareVulnerabilities.tsx
index fd6a2164ca..b4974e3672 100644
--- a/frontend/pages/SoftwarePage/SoftwareVulnerabilities/SoftwareVulnerabilities.tsx
+++ b/frontend/pages/SoftwarePage/SoftwareVulnerabilities/SoftwareVulnerabilities.tsx
@@ -244,7 +244,7 @@ const SoftwareVulnerabilities = ({
}
if (isError) {
- return ;
+ return ;
}
return (
diff --git a/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/debug.test3742931232 b/frontend/pages/admin/IntegrationsPage/cards/ConditionalAccess/debug.test3742931232
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/AppleBusinessManagerPage.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/AppleBusinessManagerPage.tsx
index 2881b8b405..1386f4c185 100644
--- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/AppleBusinessManagerPage.tsx
+++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/AppleBusinessManagerPage.tsx
@@ -159,11 +159,7 @@ const AppleBusinessManagerPage = ({ router }: { router: InjectedRouter }) => {
// TODO: error UI
if (showDataError) {
- return (
-
-
-
- );
+ return ;
}
if (abmTokens?.length === 0) {
diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleMdmPage/AppleMdmPage.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleMdmPage/AppleMdmPage.tsx
index 99c9e78616..e7699ec522 100644
--- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleMdmPage/AppleMdmPage.tsx
+++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleMdmPage/AppleMdmPage.tsx
@@ -100,7 +100,7 @@ const AppleMdmPage = ({ router }: { router: InjectedRouter }) => {
/>
Apple Push Certificate Portal
{showSpinner && }
- {showError && }
+ {showError && }
{showContent &&
(!appleAPNInfo ? (
{
// TODO: error UI
if (showDataError) {
- return (
-
-
-
- );
+ return ;
}
if (vppTokens?.length === 0) {
diff --git a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/TeamSettings/TeamSettings.tsx b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/TeamSettings/TeamSettings.tsx
index ce33765916..82d7b013ca 100644
--- a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/TeamSettings/TeamSettings.tsx
+++ b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/TeamSettings/TeamSettings.tsx
@@ -283,7 +283,7 @@ const TeamSettings = ({ location, router }: ITeamSubnavProps) => {
const renderForm = () => {
if (errorLoadGlobalConfig || errorLoadTeamConfig) {
- return ;
+ return ;
}
if (isLoadingTeamConfig || isLoadingAppConfig) {
return ;
diff --git a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPage.tsx b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPage.tsx
index f13265c05c..cb8b8d5727 100644
--- a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPage.tsx
+++ b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPage.tsx
@@ -397,7 +397,7 @@ const UsersPage = ({ location, router }: ITeamSubnavProps): JSX.Element => {
{loadingUsersError ||
loadingTeamsError ||
(!currentTeamDetails && !isLoadingTeams && !isLoadingUsers) ? (
-
+
) : (
{
return (
<>
{tableDataError ? (
-
+
) : (
;
+ return ;
}
if (maybeEmptyHosts) {
const emptyState = () => {
diff --git a/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx b/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx
index 307e6823e6..04c7268ae9 100644
--- a/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx
+++ b/frontend/pages/hosts/details/DeviceUserPage/DeviceUserPage.tsx
@@ -229,7 +229,7 @@ const DeviceUserPage = ({
const {
data: dupResponse,
isLoading: isLoadingHost,
- error: loadingDeviceUserError,
+ error: isDeviceUserError,
refetch: refetchHostDetails,
} = useQuery(
["host", deviceAuthToken],
@@ -709,7 +709,7 @@ const DeviceUserPage = ({
- {loadingDeviceUserError ?
: renderDeviceUserPage()}
+ {isDeviceUserError ?
: renderDeviceUserPage()}
);
};
diff --git a/frontend/pages/hosts/details/DeviceUserPage/_styles.scss b/frontend/pages/hosts/details/DeviceUserPage/_styles.scss
index 714d1cd08a..f9d56e1b41 100644
--- a/frontend/pages/hosts/details/DeviceUserPage/_styles.scss
+++ b/frontend/pages/hosts/details/DeviceUserPage/_styles.scss
@@ -48,18 +48,6 @@
}
}
- &__error {
- display: flex;
- flex-direction: column;
- align-items: center;
- margin: $pad-xlarge 0;
-
- &__inner {
- display: flex;
- flex-direction: row;
- }
- }
-
&__wrapper {
border: solid 1px $ui-fleet-black-10;
border-radius: 6px;
diff --git a/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/PastActivityFeed.tsx b/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/PastActivityFeed.tsx
index 523520740c..1a88e4c12b 100644
--- a/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/PastActivityFeed.tsx
+++ b/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/PastActivityFeed.tsx
@@ -29,7 +29,7 @@ const PastActivityFeed = ({
onPreviousPage,
}: IPastActivityFeedProps) => {
if (isError) {
- return
;
+ return
;
}
if (!activities) {
diff --git a/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/_styles.scss b/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/_styles.scss
index a317978bc5..64e0943194 100644
--- a/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/_styles.scss
+++ b/frontend/pages/hosts/details/cards/Activity/PastActivityFeed/_styles.scss
@@ -36,8 +36,4 @@
background-color: $ui-vibrant-blue-10;
}
}
-
- &__error {
- margin: $pad-xlarge 0;
- }
}
diff --git a/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/UpcomingActivityFeed.tsx b/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/UpcomingActivityFeed.tsx
index a53b6d144f..f9ecb7ca74 100644
--- a/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/UpcomingActivityFeed.tsx
+++ b/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/UpcomingActivityFeed.tsx
@@ -32,7 +32,7 @@ const UpcomingActivityFeed = ({
onPreviousPage,
}: IUpcomingActivityFeedProps) => {
if (isError) {
- return
;
+ return
;
}
if (!activities) {
diff --git a/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/_styles.scss b/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/_styles.scss
index 5aea33e13b..be1153c83e 100644
--- a/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/_styles.scss
+++ b/frontend/pages/hosts/details/cards/Activity/UpcomingActivityFeed/_styles.scss
@@ -36,8 +36,4 @@
background-color: $ui-vibrant-blue-10;
}
}
-
- &__error {
- margin: $pad-xlarge 0;
- }
}
diff --git a/frontend/pages/hosts/details/cards/Certificates/Certificates.tsx b/frontend/pages/hosts/details/cards/Certificates/Certificates.tsx
index 65127f387c..49c4610c5b 100644
--- a/frontend/pages/hosts/details/cards/Certificates/Certificates.tsx
+++ b/frontend/pages/hosts/details/cards/Certificates/Certificates.tsx
@@ -47,7 +47,7 @@ const CertificatesCard = ({
onSortChange,
}: ICertificatesProps) => {
const renderContent = () => {
- if (isError) return
;
+ if (isError) return
;
return (
- {isError && }
+ {isError && }
{!isError && (
;
+ return ;
}
if (isEmpty || !selfServiceData) {
diff --git a/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx b/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx
index e03a265688..92f9364cd7 100644
--- a/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx
+++ b/frontend/pages/policies/ManagePoliciesPage/ManagePoliciesPage.tsx
@@ -968,7 +968,7 @@ const ManagePolicyPage = ({
// Global policies
if (globalPoliciesError) {
- return ;
+ return ;
}
return (
;
+ return ;
}
return (
diff --git a/frontend/pages/queries/ManageQueriesPage/ManageQueriesPage.tsx b/frontend/pages/queries/ManageQueriesPage/ManageQueriesPage.tsx
index 5c6cbcc503..da8d61fd66 100644
--- a/frontend/pages/queries/ManageQueriesPage/ManageQueriesPage.tsx
+++ b/frontend/pages/queries/ManageQueriesPage/ManageQueriesPage.tsx
@@ -281,7 +281,7 @@ const ManageQueriesPage = ({
const renderQueriesTable = () => {
if (queriesError) {
- return
;
+ return
;
}
return (
;
}
- // Error state
if (isApiError) {
return
;
}