From 68e1585fd9d2ea1b698483ef7afcf1ea88fd9d6a Mon Sep 17 00:00:00 2001 From: RachelElysia <71795832+RachelElysia@users.noreply.github.com> Date: Fri, 24 Apr 2026 17:00:36 -0400 Subject: [PATCH] FE: Clean up lint warnings part III (#44065) --- .../forms/fields/Checkbox/Checkbox.tsx | 1 - .../SoftwareAppStoreAndroid.tsx | 23 ------------------- .../EditConfigurationModal.tsx | 5 +--- .../EditConfigurationModal/helpers.tsx | 6 +---- .../SoftwareAndroidForm.tsx | 2 -- .../SoftwareVulnerabilitiesTable.tsx | 2 +- .../RenameTeamModal/RenameTeamModal.tests.tsx | 2 +- .../TransferHostModal.tests.tsx | 1 - .../HostQueryReport/HostQueryReport.tsx | 2 +- .../details/cards/HostSummary/HostSummary.tsx | 5 +--- .../EditQueryForm/EditQueryForm.tsx | 10 +------- 11 files changed, 7 insertions(+), 52 deletions(-) diff --git a/frontend/components/forms/fields/Checkbox/Checkbox.tsx b/frontend/components/forms/fields/Checkbox/Checkbox.tsx index 8065d47809..c7df4fb9cb 100644 --- a/frontend/components/forms/fields/Checkbox/Checkbox.tsx +++ b/frontend/components/forms/fields/Checkbox/Checkbox.tsx @@ -53,7 +53,6 @@ const Checkbox = (props: ICheckboxProps) => { labelTooltipClickable = false, iconTooltipContent, isLeftLabel, - helpText, enableEnterToCheck = false, } = props; diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStore/SoftwareAppStoreAndroid/SoftwareAppStoreAndroid.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStore/SoftwareAppStoreAndroid/SoftwareAppStoreAndroid.tsx index fa6b6ce6a3..4fc7b86e8e 100644 --- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStore/SoftwareAppStoreAndroid/SoftwareAppStoreAndroid.tsx +++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareAppStore/SoftwareAppStoreAndroid/SoftwareAppStoreAndroid.tsx @@ -1,6 +1,5 @@ import React, { useContext, useState } from "react"; import { InjectedRouter } from "react-router"; -import axios from "axios"; import PATHS from "router/paths"; import { NotificationContext } from "context/notification"; @@ -8,19 +7,14 @@ import { AppContext } from "context/app"; import softwareAPI from "services/entities/software"; import PremiumFeatureMessage from "components/PremiumFeatureMessage"; -import CategoriesEndUserExperienceModal from "pages/SoftwarePage/components/modals/CategoriesEndUserExperienceModal"; import { ISoftwareAndroidFormData } from "pages/SoftwarePage/components/forms/SoftwareAndroidForm/SoftwareAndroidForm"; import { getPathWithQueryParams } from "utilities/url"; import SoftwareAndroidForm from "pages/SoftwarePage/components/forms/SoftwareAndroidForm"; import { getErrorMessage } from "./helpers"; -import { ADD_SOFTWARE_ERROR_PREFIX } from "../../helpers"; const baseClass = "software-app-store-android"; -const AMAPI_BASE_URL = "https://androidmanagement.googleapis.com/v1/"; -const ENTERPRISE_ID = ""; // Set this appropriately - interface ISoftwareAppStoreProps { currentTeamId: number; router: InjectedRouter; @@ -34,10 +28,6 @@ const SoftwareAppStoreAndroid = ({ const { isPremiumTier } = useContext(AppContext); const [isLoading, setIsLoading] = useState(false); - const [ - showPreviewEndUserExperience, - setShowPreviewEndUserExperience, - ] = useState(false); const goBackToSoftwareTitles = (showAvailableForInstallOnly = false) => { const queryParams = { @@ -48,10 +38,6 @@ const SoftwareAppStoreAndroid = ({ router.push(getPathWithQueryParams(PATHS.SOFTWARE_TITLES, queryParams)); }; - const onClickPreviewEndUserExperience = () => { - setShowPreviewEndUserExperience(!showPreviewEndUserExperience); - }; - const onAddSoftware = async (formData: ISoftwareAndroidFormData) => { if (!formData.applicationID) { return; @@ -62,14 +48,12 @@ const SoftwareAppStoreAndroid = ({ try { const { software_title_id: softwareAppStoreTitleId, - // Maybe this will return name and can render success message with the name? name: softwareTitleName, } = await softwareAPI.addAppStoreApp(currentTeamId, formData); renderFlash( "success", <> - {/* {appApiRes.data.name} successfully added. */} {softwareTitleName || "Android app"} successfully added. , @@ -101,15 +85,8 @@ const SoftwareAppStoreAndroid = ({ - {showPreviewEndUserExperience && ( - - )} ); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx index fc046149e8..dc9de1c6ce 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/EditConfigurationModal.tsx @@ -107,10 +107,7 @@ const EditConfigurationModal = ({ refetchSoftwareTitle(); onExit(); } catch (e) { - renderFlash( - "error", - getErrorMessage(e, softwareInstaller as IAppStoreApp) - ); + renderFlash("error", getErrorMessage(e)); } setIsUpdatingConfiguration(false); }; diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/helpers.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/helpers.tsx index a91288ba4d..b1a0b7e131 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/helpers.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditConfigurationModal/helpers.tsx @@ -1,16 +1,12 @@ import React from "react"; -import { isAxiosError } from "axios"; import { getErrorReason } from "interfaces/errors"; -import { IAppStoreApp, ISoftwarePackage } from "interfaces/software"; - -import { generateSecretErrMsg } from "pages/SoftwarePage/helpers"; const DEFAULT_ERROR_MESSAGE = "Couldn't update configuration. Please try again."; // eslint-disable-next-line import/prefer-default-export -export const getErrorMessage = (err: unknown, software: IAppStoreApp) => { +export const getErrorMessage = (err: unknown) => { const reason = getErrorReason(err); if ( diff --git a/frontend/pages/SoftwarePage/components/forms/SoftwareAndroidForm/SoftwareAndroidForm.tsx b/frontend/pages/SoftwarePage/components/forms/SoftwareAndroidForm/SoftwareAndroidForm.tsx index 05d4a8e0bf..38cbff7dcb 100644 --- a/frontend/pages/SoftwarePage/components/forms/SoftwareAndroidForm/SoftwareAndroidForm.tsx +++ b/frontend/pages/SoftwarePage/components/forms/SoftwareAndroidForm/SoftwareAndroidForm.tsx @@ -45,7 +45,6 @@ interface ISoftwareAndroidFormProps { onSubmit: (formData: ISoftwareAndroidFormData) => void; isLoading?: boolean; onCancel: () => void; - onClickPreviewEndUserExperience: () => void; } const SoftwareAndroidForm = ({ @@ -53,7 +52,6 @@ const SoftwareAndroidForm = ({ onSubmit, isLoading = false, onCancel, - onClickPreviewEndUserExperience, }: ISoftwareAndroidFormProps) => { const { gitOpsModeEnabled } = useGitOpsMode("software"); diff --git a/frontend/pages/SoftwarePage/components/tables/SoftwareVulnerabilitiesTable/SoftwareVulnerabilitiesTable.tsx b/frontend/pages/SoftwarePage/components/tables/SoftwareVulnerabilitiesTable/SoftwareVulnerabilitiesTable.tsx index 1c6230d607..01bb8a59b3 100644 --- a/frontend/pages/SoftwarePage/components/tables/SoftwareVulnerabilitiesTable/SoftwareVulnerabilitiesTable.tsx +++ b/frontend/pages/SoftwarePage/components/tables/SoftwareVulnerabilitiesTable/SoftwareVulnerabilitiesTable.tsx @@ -11,7 +11,7 @@ import PATHS from "router/paths"; import { AppContext } from "context/app"; import { ISoftwareVulnerability } from "interfaces/software"; -import { CONTACT_FLEET_LINK, GITHUB_NEW_ISSUE_LINK } from "utilities/constants"; +import { CONTACT_FLEET_LINK } from "utilities/constants"; import { DisplayPlatform } from "interfaces/platform"; import { getPathWithQueryParams } from "utilities/url"; import TableContainer from "components/TableContainer"; diff --git a/frontend/pages/admin/TeamManagementPage/components/RenameTeamModal/RenameTeamModal.tests.tsx b/frontend/pages/admin/TeamManagementPage/components/RenameTeamModal/RenameTeamModal.tests.tsx index fa6669a880..503addcb0c 100644 --- a/frontend/pages/admin/TeamManagementPage/components/RenameTeamModal/RenameTeamModal.tests.tsx +++ b/frontend/pages/admin/TeamManagementPage/components/RenameTeamModal/RenameTeamModal.tests.tsx @@ -1,5 +1,5 @@ import React from "react"; -import { screen, waitFor } from "@testing-library/react"; +import { screen } from "@testing-library/react"; import { createCustomRenderer } from "test/test-utils"; import userEvent from "@testing-library/user-event"; diff --git a/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tests.tsx b/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tests.tsx index e6d5f5b046..cf8ec4cf26 100644 --- a/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tests.tsx +++ b/frontend/pages/hosts/components/TransferHostModal/TransferHostModal.tests.tsx @@ -2,7 +2,6 @@ import React from "react"; import { render, screen } from "@testing-library/react"; import userEvent from "@testing-library/user-event"; -import paths from "router/paths"; import TransferHostModal from "./TransferHostModal"; diff --git a/frontend/pages/hosts/details/HostQueryReport/HostQueryReport.tsx b/frontend/pages/hosts/details/HostQueryReport/HostQueryReport.tsx index 67371f7f27..386b667720 100644 --- a/frontend/pages/hosts/details/HostQueryReport/HostQueryReport.tsx +++ b/frontend/pages/hosts/details/HostQueryReport/HostQueryReport.tsx @@ -1,6 +1,6 @@ import React, { useCallback, useContext, useState } from "react"; import { useQuery } from "react-query"; -import { browserHistory, InjectedRouter, Link } from "react-router"; +import { browserHistory, InjectedRouter } from "react-router"; import { Params } from "react-router/lib/Router"; import PATHS from "router/paths"; import { AppContext } from "context/app"; diff --git a/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx b/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx index 827e5edd70..a937d8d188 100644 --- a/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx +++ b/frontend/pages/hosts/details/cards/HostSummary/HostSummary.tsx @@ -24,10 +24,7 @@ import DataSet from "components/DataSet"; import StatusIndicator from "components/StatusIndicator"; import IssuesIndicator from "pages/hosts/components/IssuesIndicator"; -import { - DATE_FNS_FORMAT_STRINGS, - DEFAULT_EMPTY_CELL_VALUE, -} from "utilities/constants"; +import { DATE_FNS_FORMAT_STRINGS } from "utilities/constants"; import OSSettingsIndicator from "./OSSettingsIndicator"; import BootstrapPackageIndicator from "./BootstrapPackageIndicator/BootstrapPackageIndicator"; diff --git a/frontend/pages/queries/edit/components/EditQueryForm/EditQueryForm.tsx b/frontend/pages/queries/edit/components/EditQueryForm/EditQueryForm.tsx index 5bfe7dde91..f112919044 100644 --- a/frontend/pages/queries/edit/components/EditQueryForm/EditQueryForm.tsx +++ b/frontend/pages/queries/edit/components/EditQueryForm/EditQueryForm.tsx @@ -18,11 +18,7 @@ import PATHS from "router/paths"; import { AppContext } from "context/app"; import { QueryContext } from "context/query"; -import { - addGravatarUrlToResource, - getCustomDropdownOptions, - secondsToDhms, -} from "utilities/helpers"; +import { getCustomDropdownOptions, secondsToDhms } from "utilities/helpers"; import { FREQUENCY_DROPDOWN_OPTIONS, @@ -47,7 +43,6 @@ import labelsAPI, { ILabelsSummaryResponse, } from "services/entities/labels"; -import Avatar from "components/Avatar"; import SQLEditor from "components/SQLEditor"; import { validateQuery, @@ -58,7 +53,6 @@ import RevealButton from "components/buttons/RevealButton"; import Checkbox from "components/forms/fields/Checkbox"; // @ts-ignore import Dropdown from "components/forms/fields/Dropdown"; -import DataSet from "components/DataSet"; import Slider from "components/forms/fields/Slider"; import TooltipWrapper from "components/TooltipWrapper"; import Spinner from "components/Spinner"; @@ -179,7 +173,6 @@ const EditQueryForm = ({ setEditingExistingQuery, } = useContext(QueryContext); const { - currentUser, isOnlyObserver, isGlobalObserver, isTeamMaintainerOrTeamAdmin, @@ -191,7 +184,6 @@ const EditQueryForm = ({ config, isPremiumTier, isFreeTier, - currentTeam, } = useContext(AppContext); const isExistingQuery = !!queryIdForEdit;