From 7341249025ee4bb23a3f4d208cb6efb4ebd2f6cd Mon Sep 17 00:00:00 2001
From: Lucas Manuel Rodriguez <lucas@fleetdm.com>
Date: Wed, 27 Aug 2025 20:33:22 -0300
Subject: [PATCH] Fix one-off error in secret variable length check (#32386)

For #32381.
---
 frontend/pages/ManageControlsPage/Secrets/Secrets.tests.tsx   | 4 ++--
 .../Secrets/components/AddSecretModal/helpers.ts              | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/frontend/pages/ManageControlsPage/Secrets/Secrets.tests.tsx b/frontend/pages/ManageControlsPage/Secrets/Secrets.tests.tsx
index 1177acbe24..5cf9104498 100644
--- a/frontend/pages/ManageControlsPage/Secrets/Secrets.tests.tsx
+++ b/frontend/pages/ManageControlsPage/Secrets/Secrets.tests.tsx
@@ -305,12 +305,12 @@ describe("Custom variables", () => {
       });
       it("does not allow saving very long name", async () => {
         const { nameInput, valueInput, saveButton } = await getAddSecretUI();
-        await user.type(nameInput, new Array(300).fill("A").join("")); // Invalid name
+        await user.type(nameInput, new Array(256).fill("A").join("")); // Invalid name
         await user.type(valueInput, "a value");
         await user.click(saveButton);
         await waitFor(() => {
           expect(
-            screen.getByText("Name may not exceed 256 characters")
+            screen.getByText("Name may not exceed 255 characters")
           ).toBeInTheDocument();
           expect(saveButton).toBeDisabled();
         });
diff --git a/frontend/pages/ManageControlsPage/Secrets/components/AddSecretModal/helpers.ts b/frontend/pages/ManageControlsPage/Secrets/components/AddSecretModal/helpers.ts
index e8b35a9e63..9c5b841224 100644
--- a/frontend/pages/ManageControlsPage/Secrets/components/AddSecretModal/helpers.ts
+++ b/frontend/pages/ManageControlsPage/Secrets/components/AddSecretModal/helpers.ts
@@ -53,9 +53,9 @@ const FORM_VALIDATIONS: IFormValidations = {
       {
         name: "notTooLong",
         isValid: (formData: IAddSecretModalScheduleFormData) => {
-          return formData.name.length <= 256;
+          return formData.name.length <= 255;
         },
-        message: "Name may not exceed 256 characters",
+        message: "Name may not exceed 255 characters",
       },
       {
         name: "doesNotIncludePrefix",