From 797ea6c707ff9688a7cba039cb11b69ca5e88901 Mon Sep 17 00:00:00 2001 From: RachelElysia <71795832+RachelElysia@users.noreply.github.com> Date: Tue, 1 Nov 2022 15:59:26 -0400 Subject: [PATCH] Fleet UI: Host/Software pages styling fixes (#8474) --- changes/issue-8386-8113-styling | 1 + .../forms/fields/SelectTargetsDropdown/_styles.scss | 4 ++-- .../pages/DashboardPage/cards/HostsSummary/HostsSummary.tsx | 4 ---- frontend/pages/hosts/ManageHostsPage/HostTableConfig.tsx | 2 +- frontend/pages/hosts/ManageHostsPage/_styles.scss | 1 + frontend/pages/packs/ManagePacksPage/_styles.scss | 2 +- frontend/pages/policies/ManagePoliciesPage/_styles.scss | 2 +- .../ManagePoliciesPage/components/PoliciesTable/_styles.scss | 3 +-- .../components/PolicyQueriesErrorsTable/_styles.scss | 5 ----- .../PolicyPage/components/PolicyQueriesTable/_styles.scss | 3 +-- frontend/pages/queries/ManageQueriesPage/_styles.scss | 2 +- frontend/pages/schedule/ManageSchedulePage/_styles.scss | 2 +- frontend/pages/software/ManageSoftwarePage/_styles.scss | 2 +- 13 files changed, 12 insertions(+), 21 deletions(-) create mode 100644 changes/issue-8386-8113-styling diff --git a/changes/issue-8386-8113-styling b/changes/issue-8386-8113-styling new file mode 100644 index 0000000000..83903ebe8b --- /dev/null +++ b/changes/issue-8386-8113-styling @@ -0,0 +1 @@ +* Update colors, issues icon \ No newline at end of file diff --git a/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss b/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss index 0e5b6a7206..b850a618dc 100644 --- a/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss +++ b/frontend/components/forms/fields/SelectTargetsDropdown/_styles.scss @@ -107,7 +107,7 @@ .Select-value { line-height: 34px; - border: 1px solid $core-dark-blue-grey; + border: 1px solid $ui-fleet-black-75; margin-top: 5px; margin-bottom: 0; } @@ -176,7 +176,7 @@ .Select-value-label { font-size: $small; - color: $core-dark-blue-grey; + color: $ui-fleet-black-75; font-size: $x-small; padding: 0 0 0 $pad-medium; line-height: 34px; diff --git a/frontend/pages/DashboardPage/cards/HostsSummary/HostsSummary.tsx b/frontend/pages/DashboardPage/cards/HostsSummary/HostsSummary.tsx index 1e836e935f..dc244b742c 100644 --- a/frontend/pages/DashboardPage/cards/HostsSummary/HostsSummary.tsx +++ b/frontend/pages/DashboardPage/cards/HostsSummary/HostsSummary.tsx @@ -9,10 +9,6 @@ import { buildQueryStringFromParams } from "utilities/url"; import DataError from "components/DataError"; import SummaryTile from "./SummaryTile"; -import WindowsIcon from "../../../../../assets/images/icon-windows-48x48@2x.png"; -import LinuxIcon from "../../../../../assets/images/icon-linux-48x48@2x.png"; -import MacIcon from "../../../../../assets/images/icon-mac-48x48@2x.png"; - const baseClass = "hosts-summary"; interface IHostSummaryProps { diff --git a/frontend/pages/hosts/ManageHostsPage/HostTableConfig.tsx b/frontend/pages/hosts/ManageHostsPage/HostTableConfig.tsx index 6a4d746a56..357534a4b8 100644 --- a/frontend/pages/hosts/ManageHostsPage/HostTableConfig.tsx +++ b/frontend/pages/hosts/ManageHostsPage/HostTableConfig.tsx @@ -205,7 +205,7 @@ const allHostTableHeaders: IDataColumn[] = [ }, { title: "Issues", - Header: () => host issues, + Header: "Issues", disableSortBy: true, accessor: "issues", Cell: (cellProps: ICellProps) => ( diff --git a/frontend/pages/hosts/ManageHostsPage/_styles.scss b/frontend/pages/hosts/ManageHostsPage/_styles.scss index f9c3cb8e72..3a202596a6 100644 --- a/frontend/pages/hosts/ManageHostsPage/_styles.scss +++ b/frontend/pages/hosts/ManageHostsPage/_styles.scss @@ -108,6 +108,7 @@ .manage-hosts__filter-dropdowns { display: flex; + margin-left: $pad-small; } } } diff --git a/frontend/pages/packs/ManagePacksPage/_styles.scss b/frontend/pages/packs/ManagePacksPage/_styles.scss index 075a70800b..53d91c30d9 100644 --- a/frontend/pages/packs/ManagePacksPage/_styles.scss +++ b/frontend/pages/packs/ManagePacksPage/_styles.scss @@ -23,7 +23,7 @@ } p { - color: $core-dark-blue-grey; + color: $ui-fleet-black-75; margin: 0; font-size: $x-small; font-style: italic; diff --git a/frontend/pages/policies/ManagePoliciesPage/_styles.scss b/frontend/pages/policies/ManagePoliciesPage/_styles.scss index db54b5f9e4..c4b86b2967 100644 --- a/frontend/pages/policies/ManagePoliciesPage/_styles.scss +++ b/frontend/pages/policies/ManagePoliciesPage/_styles.scss @@ -59,7 +59,7 @@ } p { - color: $core-dark-blue-grey; + color: $ui-fleet-black-75; margin: 0; font-size: $x-small; font-style: italic; diff --git a/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/_styles.scss b/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/_styles.scss index 5cf17191ff..911c4c78a1 100644 --- a/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/_styles.scss +++ b/frontend/pages/policies/ManagePoliciesPage/components/PoliciesTable/_styles.scss @@ -89,8 +89,7 @@ } &__bullet-text { - width: 455px; - text-align: left; + text-align: center; } } diff --git a/frontend/pages/policies/PolicyPage/components/PolicyQueriesErrorsTable/_styles.scss b/frontend/pages/policies/PolicyPage/components/PolicyQueriesErrorsTable/_styles.scss index af790412d5..1703f16186 100644 --- a/frontend/pages/policies/PolicyPage/components/PolicyQueriesErrorsTable/_styles.scss +++ b/frontend/pages/policies/PolicyPage/components/PolicyQueriesErrorsTable/_styles.scss @@ -101,11 +101,6 @@ width: 500px; padding: $pad-xxlarge 0; } - - &__bullet-text { - width: 455px; - text-align: left; - } } .no-team-policy { diff --git a/frontend/pages/policies/PolicyPage/components/PolicyQueriesTable/_styles.scss b/frontend/pages/policies/PolicyPage/components/PolicyQueriesTable/_styles.scss index ccb82fcbe1..55f3864ac7 100644 --- a/frontend/pages/policies/PolicyPage/components/PolicyQueriesTable/_styles.scss +++ b/frontend/pages/policies/PolicyPage/components/PolicyQueriesTable/_styles.scss @@ -116,8 +116,7 @@ } &__bullet-text { - width: 455px; - text-align: left; + text-align: center; } } diff --git a/frontend/pages/queries/ManageQueriesPage/_styles.scss b/frontend/pages/queries/ManageQueriesPage/_styles.scss index ce3ec4055f..9ea8cafc0f 100644 --- a/frontend/pages/queries/ManageQueriesPage/_styles.scss +++ b/frontend/pages/queries/ManageQueriesPage/_styles.scss @@ -47,7 +47,7 @@ } p { - color: $core-dark-blue-grey; + color: $ui-fleet-black-75; margin: 0; font-size: $x-small; font-style: italic; diff --git a/frontend/pages/schedule/ManageSchedulePage/_styles.scss b/frontend/pages/schedule/ManageSchedulePage/_styles.scss index d7f28ebff6..63f6cce90f 100644 --- a/frontend/pages/schedule/ManageSchedulePage/_styles.scss +++ b/frontend/pages/schedule/ManageSchedulePage/_styles.scss @@ -48,7 +48,7 @@ } p { - color: $core-dark-blue-grey; + color: $ui-fleet-black-75; margin: 0; font-size: $x-small; font-style: italic; diff --git a/frontend/pages/software/ManageSoftwarePage/_styles.scss b/frontend/pages/software/ManageSoftwarePage/_styles.scss index 2da3686087..fd0fbc9936 100644 --- a/frontend/pages/software/ManageSoftwarePage/_styles.scss +++ b/frontend/pages/software/ManageSoftwarePage/_styles.scss @@ -49,7 +49,7 @@ } p { - color: $core-dark-blue-grey; + color: $ui-fleet-black-75; margin: 0; font-size: $x-small; font-style: italic;