From a0b10d4e4995a0a28871eaaddbbf64afa5be2615 Mon Sep 17 00:00:00 2001 From: KanchiMoe <5897898+KanchiMoe@users.noreply.github.com> Date: Mon, 3 Apr 2023 19:53:13 +0100 Subject: [PATCH] acl is deprecated on aws_s3_bucket (#10944) `acl` is a deprecated argument on `aws_s3_bucket`. Identified by this job: https://github.com/fleetdm/fleet/actions/runs/4585758981/jobs/8098079111#step:4:58 --- infrastructure/loadtesting/terraform/firehose.tf | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/infrastructure/loadtesting/terraform/firehose.tf b/infrastructure/loadtesting/terraform/firehose.tf index dd3f89ef44..6476a65460 100644 --- a/infrastructure/loadtesting/terraform/firehose.tf +++ b/infrastructure/loadtesting/terraform/firehose.tf @@ -44,13 +44,17 @@ resource "aws_s3_bucket_public_access_block" "osquery-results" { resource "aws_s3_bucket" "osquery-status" { #tfsec:ignore:aws-s3-encryption-customer-key tfsec:ignore:aws-s3-enable-bucket-logging tfsec:ignore:aws-s3-enable-versioning bucket = "${local.prefix}-loadtest-osquery-status-archive" - acl = "private" #checkov:skip=CKV_AWS_18:dev env #checkov:skip=CKV_AWS_144:dev env #checkov:skip=CKV_AWS_21:dev env } +resource "aws_s3_bucket_acl" "osquery-status" { + bucket = aws_s3_bucket.osquery-status.id + acl = "private" +} + resource "aws_s3_bucket_lifecycle_configuration" "osquery-status" { bucket = aws_s3_bucket.osquery-status.id