diff --git a/frontend/components/AuthenticatedAdminRoutes/AuthenticatedAdminRoutes.jsx b/frontend/components/AuthenticatedAdminRoutes/AuthenticatedAdminRoutes.jsx index ab92993272..c1c86febbc 100644 --- a/frontend/components/AuthenticatedAdminRoutes/AuthenticatedAdminRoutes.jsx +++ b/frontend/components/AuthenticatedAdminRoutes/AuthenticatedAdminRoutes.jsx @@ -32,9 +32,9 @@ export class AuthenticatedAdminRoutes extends Component { } return ( -
+ <> {children} -
+ ); } } diff --git a/frontend/components/forms/admin/AppConfigForm/AppConfigForm.jsx b/frontend/components/forms/admin/AppConfigForm/AppConfigForm.jsx index 2a05c5251d..0eeb8b8e87 100644 --- a/frontend/components/forms/admin/AppConfigForm/AppConfigForm.jsx +++ b/frontend/components/forms/admin/AppConfigForm/AppConfigForm.jsx @@ -158,7 +158,7 @@ class AppConfigForm extends Component { return (
-

Organization Info

+

Organization Info

-

Fleet web address

+

Fleet web address

-

SAML Single Sign On Options

+

SAML Single Sign On Options

-

SMTP Options STATUS: {smtpConfigured ? 'CONFIGURED' : 'NOT CONFIGURED'}

+

+ SMTP Options STATUS: {smtpConfigured ? 'CONFIGURED' : 'NOT CONFIGURED'} +

-

Osquery Enrollment Secrets

+

Osquery Enrollment Secrets

Manage secrets with fleetctl. Active secrets: @@ -325,7 +327,7 @@ class AppConfigForm extends Component {

-

+

{renderAdvancedOptions()}
); } diff --git a/frontend/pages/admin/AppSettingsPage/_styles.scss b/frontend/pages/admin/AppSettingsPage/_styles.scss index f90984b1e3..a9618ec914 100644 --- a/frontend/pages/admin/AppSettingsPage/_styles.scss +++ b/frontend/pages/admin/AppSettingsPage/_styles.scss @@ -4,7 +4,7 @@ &__page-description { font-size: $x-small; color: $core-dark-blue-grey; - margin: 40px 0 54px 0; + @include sticky-settings-description; } h2 { @@ -31,4 +31,31 @@ color: $core-dark-blue-grey; } } + + &__settings-form { + display: flex; + + } + + &__form-nav-list { + position: sticky; + // this is the spacing needed to make the sticky form nav position correctly when scrolling + // TODO: find a way to calculate these sticky positions this and use variables. + // will be tedious to update otherwise. + top: 207px; + width: 178px; + margin: 0; + padding: 0 110px 0 0; + list-style: none; + font-size: $x-small; + + li { + margin-bottom: 16px; + } + + a { + color: $black; + text-decoration: none; + } + } } diff --git a/frontend/pages/admin/OsqueryOptionsPage/OsqueryOptionsPage.jsx b/frontend/pages/admin/OsqueryOptionsPage/OsqueryOptionsPage.jsx index 248f3ada9d..e951b6c64a 100644 --- a/frontend/pages/admin/OsqueryOptionsPage/OsqueryOptionsPage.jsx +++ b/frontend/pages/admin/OsqueryOptionsPage/OsqueryOptionsPage.jsx @@ -63,26 +63,24 @@ export class OsqueryOptionsPage extends Component { const { onSaveOsqueryOptionsFormSubmit } = this; return ( -
-
-

This file describes options returned to osquery when it checks for configuration.

-
-

See Fleet documentation for an example file that includes the overrides option.

- - Go to Fleet docs - open new tab - -
-
- -
+
+

This file describes options returned to osquery when it checks for configuration.

+
+

See Fleet documentation for an example file that includes the overrides option.

+ + Go to Fleet docs + open new tab + +
+
+
); diff --git a/frontend/pages/admin/OsqueryOptionsPage/_styles.scss b/frontend/pages/admin/OsqueryOptionsPage/_styles.scss index 0b94b0c972..cf8b73e984 100644 --- a/frontend/pages/admin/OsqueryOptionsPage/_styles.scss +++ b/frontend/pages/admin/OsqueryOptionsPage/_styles.scss @@ -10,7 +10,8 @@ &__page-description { font-size: $x-small; color: $core-dark-blue-grey; - margin: 40px 0 16px 0; + @include sticky-settings-description; + padding-bottom: $pad-medium; } &__info-banner { diff --git a/frontend/pages/admin/UserManagementPage/UserManagementPage.jsx b/frontend/pages/admin/UserManagementPage/UserManagementPage.jsx index 560a7033a3..663220a197 100644 --- a/frontend/pages/admin/UserManagementPage/UserManagementPage.jsx +++ b/frontend/pages/admin/UserManagementPage/UserManagementPage.jsx @@ -299,9 +299,7 @@ export class UserManagementPage extends Component { return (
-
-

Invite new users, customize user permissions, and disable users in Fleet.

-
+

Invite new users, customize user permissions, and disable users in Fleet.

{renderSmtpWarning()}

{resourcesCount} users

diff --git a/frontend/pages/admin/UserManagementPage/_styles.scss b/frontend/pages/admin/UserManagementPage/_styles.scss index a2ccc67f68..66e832ca9b 100644 --- a/frontend/pages/admin/UserManagementPage/_styles.scss +++ b/frontend/pages/admin/UserManagementPage/_styles.scss @@ -1,11 +1,11 @@ .user-management { - min-height: 90vh; padding: 30px; &__page-description { font-size: $x-small; color: $core-dark-blue-grey; - margin: 40px 0 20px 0; + @include sticky-settings-description; + padding-bottom: $pad-medium; } &__wrapper { @@ -61,7 +61,6 @@ &__heading-wrapper { width: 100%; - margin-bottom: 10px; } &__smtp-warning-wrapper { diff --git a/frontend/styles/var/mixins.scss b/frontend/styles/var/mixins.scss index 7292735aec..b4445a3811 100644 --- a/frontend/styles/var/mixins.scss +++ b/frontend/styles/var/mixins.scss @@ -24,3 +24,15 @@ $max-width: 2560px; @content; } } + +// Used to keep the settings description sticky under the main nav and sub nav. +// TODO: figure out how to calculate these values with variables. Will be tedious to change otherwise +@mixin sticky-settings-description { + position: sticky; + // this is the current spacing needed to keep the description looking correct under the sub nav when scrolling. + top: 97px; + z-index: 2; + background-color: $white; + margin: 0; + padding: 40px 0 54px 0; +}