From a1592259f4ee57c91f7946259ccfbd4e1f59b8bd Mon Sep 17 00:00:00 2001 From: Nico <32375741+nulmete@users.noreply.github.com> Date: Mon, 9 Mar 2026 17:23:44 -0300 Subject: [PATCH] Do not show table footer under Target specific hosts table (#41252) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Related issue:** Resolves #41111 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [x] QA'd all new/changed functionality manually ### Before Screenshot 2026-03-09 at 11 50
49 AM ### After Screenshot 2026-03-09 at 11 50
29 AM --- changes/41111-fix-table-footer-rendering | 1 + frontend/components/TableContainer/DataTable/DataTable.tsx | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changes/41111-fix-table-footer-rendering diff --git a/changes/41111-fix-table-footer-rendering b/changes/41111-fix-table-footer-rendering new file mode 100644 index 0000000000..88442eebcd --- /dev/null +++ b/changes/41111-fix-table-footer-rendering @@ -0,0 +1 @@ +* Fixed table footer rendering unexpectedly in the host targets search dropdown. diff --git a/frontend/components/TableContainer/DataTable/DataTable.tsx b/frontend/components/TableContainer/DataTable/DataTable.tsx index cbad4be430..49e34060c9 100644 --- a/frontend/components/TableContainer/DataTable/DataTable.tsx +++ b/frontend/components/TableContainer/DataTable/DataTable.tsx @@ -574,9 +574,9 @@ const DataTable = ({ // table is client-side paginated with more than 1 page of rows ((isClientSidePagination && (canNextPage || canPreviousPage)) || // table's pagination is externally controlled - renderPagination || + renderPagination?.() != null || // there is help text and at least 1 row of data - (renderTableHelpText && !!rows?.length)); + (renderTableHelpText?.() != null && !!rows?.length)); return (