From ab3047bb39f1e2be331d1ff18b4eb768619033c4 Mon Sep 17 00:00:00 2001 From: Zach Wasserman Date: Wed, 4 Aug 2021 10:04:27 -0700 Subject: [PATCH] Update usage of os.IsNotExist (#29) Per [godoc](https://pkg.go.dev/os#IsNotExist), this is the preferred method. --- pkg/update/filestore/filestore.go | 4 ++-- pkg/update/update.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/update/filestore/filestore.go b/pkg/update/filestore/filestore.go index 0248795411..b94d7ea250 100644 --- a/pkg/update/filestore/filestore.go +++ b/pkg/update/filestore/filestore.go @@ -54,9 +54,9 @@ func (s *fileStore) GetMeta() (map[string]json.RawMessage, error) { func (s *fileStore) readData() error { stat, err := os.Stat(s.filename) - if err != nil && !os.IsNotExist(err) { + if err != nil && !errors.Is(err, os.ErrNotExist) { return errors.Wrap(err, "stat file store") - } else if os.IsNotExist(err) { + } else if errors.Is(err, os.ErrNotExist) { // initialize empty s.metadata = metadataMap{} return nil diff --git a/pkg/update/update.go b/pkg/update/update.go index 5a9176880d..a992db5fe1 100644 --- a/pkg/update/update.go +++ b/pkg/update/update.go @@ -235,7 +235,7 @@ func (u *Updater) Download(repoPath, localPath string) error { if constant.PlatformName == "windows" { // Remove old file first - if err := os.Rename(localPath, localPath+".old"); err != nil && !os.IsNotExist(err) { + if err := os.Rename(localPath, localPath+".old"); err != nil && !errors.Is(err, os.ErrNotExist) { return errors.Wrap(err, "rename old") } }