diff --git a/server/datastore/mysql/microsoft_mdm.go b/server/datastore/mysql/microsoft_mdm.go index 31c4cd3634..81f387bf96 100644 --- a/server/datastore/mysql/microsoft_mdm.go +++ b/server/datastore/mysql/microsoft_mdm.go @@ -468,7 +468,11 @@ func updateMDMWindowsHostProfileStatusFromResponseDB( sb.WriteString("(?, ?, ?, ?, ?, command_uuid, ?),") } - stmt = fmt.Sprintf(updateHostProfilesStmt, strings.TrimSuffix(sb.String(), ",")) + values := strings.TrimSuffix(sb.String(), ",") + if len(values) == 0 { + return nil + } + stmt = fmt.Sprintf(updateHostProfilesStmt, values) _, err = tx.ExecContext(ctx, stmt, args...) return ctxerr.Wrap(ctx, err, "updating host profiles") } diff --git a/server/mdm/microsoft/bitlocker_csp.go b/server/mdm/microsoft/bitlocker_csp.go index 655569266a..b017118af2 100644 --- a/server/mdm/microsoft/bitlocker_csp.go +++ b/server/mdm/microsoft/bitlocker_csp.go @@ -3,8 +3,9 @@ package microsoft_mdm import ( "bytes" "errors" - "github.com/fleetdm/fleet/v4/server/fleet" "text/template" + + "github.com/fleetdm/fleet/v4/server/fleet" ) const ( @@ -24,9 +25,9 @@ var systemDriveRequiresStartupAuthTmpl = template.Must(template.New("cmd").Funcs return *val }}).Parse(` - {{ .CmdUUID }}-1 + {{ .CmdUUID }} - {{ .CmdUUID }}-2 + {{ .CmdUUID }}-1 chr diff --git a/server/mdm/microsoft/bitlocker_csp_test.go b/server/mdm/microsoft/bitlocker_csp_test.go index 88ed286f43..2196b5437e 100644 --- a/server/mdm/microsoft/bitlocker_csp_test.go +++ b/server/mdm/microsoft/bitlocker_csp_test.go @@ -1,10 +1,11 @@ package microsoft_mdm import ( - "github.com/fleetdm/fleet/v4/server/ptr" - "github.com/stretchr/testify/require" "strings" "testing" + + "github.com/fleetdm/fleet/v4/server/ptr" + "github.com/stretchr/testify/require" ) func TestSystemDriveRequiresStartupAuthSpec_validate(t *testing.T) { @@ -105,7 +106,7 @@ func TestSystemDriveRequiresStartupAuthSpec_validate(t *testing.T) { } } -func TestSystemDrRequiresStartupAuthCmd_Template(t *testing.T) { +func TestSystemDriveRequiresStartupAuthCmd_Template(t *testing.T) { tests := []struct { name string spec SystemDriveRequiresStartupAuthSpec @@ -119,9 +120,9 @@ func TestSystemDrRequiresStartupAuthCmd_Template(t *testing.T) { }, expected: ` - uuid-123-1 + uuid-123 - uuid-123-2 + uuid-123-1 chr @@ -150,9 +151,9 @@ func TestSystemDrRequiresStartupAuthCmd_Template(t *testing.T) { }, expected: ` - uuid-789-1 + uuid-789 - uuid-789-2 + uuid-789-1 chr