From bc1698767eb0bd22983ab7d49a3cf5d2d95ba32c Mon Sep 17 00:00:00 2001 From: Zach Wasserman Date: Mon, 12 Jul 2021 10:18:02 -0700 Subject: [PATCH] Fix Kinesis/Firehose error messages (#1316) Previously we unintentionally logged the *pointer* when we intended to log the *value* of how many records failed. --- changes/1316-kinesis-firehose-errors | 1 + server/logging/firehose.go | 2 +- server/logging/kinesis.go | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changes/1316-kinesis-firehose-errors diff --git a/changes/1316-kinesis-firehose-errors b/changes/1316-kinesis-firehose-errors new file mode 100644 index 0000000000..ebe17b1578 --- /dev/null +++ b/changes/1316-kinesis-firehose-errors @@ -0,0 +1 @@ +* Fix printing of failed record count in AWS Kinesis/Firehose logging plugins. diff --git a/server/logging/firehose.go b/server/logging/firehose.go index 5a24dc254d..44f1413de9 100644 --- a/server/logging/firehose.go +++ b/server/logging/firehose.go @@ -178,7 +178,7 @@ func (f *firehoseLogWriter) putRecordBatch(try int, records []*firehose.Record) return errors.Errorf( "failed to put %d records, retries exhausted. First error: %s", - output.FailedPutCount, errMsg, + *output.FailedPutCount, errMsg, ) } diff --git a/server/logging/kinesis.go b/server/logging/kinesis.go index cdf40330eb..092732f9c4 100644 --- a/server/logging/kinesis.go +++ b/server/logging/kinesis.go @@ -186,7 +186,7 @@ func (k *kinesisLogWriter) putRecords(try int, records []*kinesis.PutRecordsRequ return errors.Errorf( "failed to put %d records, retries exhausted. First error: %s", - output.FailedRecordCount, errMsg, + *output.FailedRecordCount, errMsg, ) }