diff --git a/changes/44791-android-edit-appearance-self-service-preview b/changes/44791-android-edit-appearance-self-service-preview new file mode 100644 index 0000000000..93e89855e7 --- /dev/null +++ b/changes/44791-android-edit-appearance-self-service-preview @@ -0,0 +1 @@ +- Removed the misleading Self-service preview tab from the "Edit appearance" modal for Android apps. Android apps are installed from the Play Store rather than the Fleet self-service web view and updating its appearance will not change anything in Play Store. diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tests.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tests.tsx index 7aa6394be5..ac3de8c7dc 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tests.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tests.tsx @@ -45,6 +45,23 @@ describe("EditIconModal", () => { expect(save).toBeInTheDocument(); }); + it("hides the preview tabs and Self-service view for Android apps", () => { + const render = createCustomRenderer({ withBackendMock: true }); + const ANDROID_PROPS = { + ...MOCK_PROPS, + previewInfo: { + ...MOCK_PROPS.previewInfo, + source: "android_apps", + }, + }; + render(); + + expect(screen.getByText("Preview")).toBeInTheDocument(); + expect(screen.queryByText("Fleet")).not.toBeInTheDocument(); + expect(screen.queryByText("Self-service")).not.toBeInTheDocument(); + expect(screen.getByText("Version")).toBeInTheDocument(); + }); + it("shows the correct software name and preview info in Fleet card", () => { const render = createCustomRenderer({ withBackendMock: true }); render(); diff --git a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx index 12cdd574ff..418813d45b 100644 --- a/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx +++ b/frontend/pages/SoftwarePage/SoftwareTitleDetailsPage/EditIconModal/EditIconModal.tsx @@ -4,6 +4,7 @@ import { Tab, Tabs, TabList, TabPanel } from "react-tabs"; import { IAppStoreApp, + isAndroidSoftwareSource, isIpadOrIphoneSoftwareSource, ISoftwarePackage, InstallerType, @@ -162,6 +163,7 @@ const EditIconModal = ({ const isIosOrIpadosApp = isIpadOrIphoneSoftwareSource( previewInfo?.source || "" ); + const isAndroidApp = isAndroidSoftwareSource(previewInfo?.source || ""); // Fetch current custom icon from API if applicable const shouldFetchCustomIcon = @@ -613,20 +615,24 @@ const EditIconModal = ({ gitopsCompatible={false} />

Preview

- - - - - Fleet - - - Self-service - - - {renderPreviewFleetCard()} - {renderPreviewSelfServiceCard()} - - + {isAndroidApp ? ( + renderPreviewFleetCard() + ) : ( + + + + + Fleet + + + Self-service + + + {renderPreviewFleetCard()} + {renderPreviewSelfServiceCard()} + + + )} );