From c52cc352109342e119fbda59e1cffee095b40b39 Mon Sep 17 00:00:00 2001 From: Luke Heath Date: Fri, 12 Jan 2024 10:32:44 -0600 Subject: [PATCH] Update pull_request_template.md (#16075) Update PR template to include additional steps for PRs containing database migrations. --- .github/pull_request_template.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index ea6aba7765..8ddd9b8aed 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,6 +10,10 @@ If some of the following don't apply, delete the relevant line. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) - [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] Added/updated tests +- [ ] If database migrations are included, checked table schema to confirm autoupdate +- For database migrations: + - [ ] Checked schema for all modified table for columns that will auto-update timestamps during migration. + - [ ] Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects. - [ ] Manual QA for all new/changed functionality - For Orbit and Fleet Desktop changes: - [ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux.