From cab2af30d6859cd793417b219321edb1abd9bc78 Mon Sep 17 00:00:00 2001 From: Ian Littman Date: Tue, 22 Jul 2025 17:41:47 -0500 Subject: [PATCH] Move osquery-perf changes from PR template to story template, include load test environment changes in scope (#31153) This attempts to surface load test environment work (e.g. allowing configuring Cloudfront in a load test environment, or adding osquery-perf improvements) while spec'ing stories rather than catching at the QA stage, allowing us to properly estimate effort and parallelize work. --- .github/ISSUE_TEMPLATE/story.md | 1 + .github/pull_request_template.md | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/story.md b/.github/ISSUE_TEMPLATE/story.md index 7fbad502ae..78528e1b37 100644 --- a/.github/ISSUE_TEMPLATE/story.md +++ b/.github/ISSUE_TEMPLATE/story.md @@ -62,6 +62,7 @@ What else should contributors [keep in mind](https://fleetdm.com/handbook/compan - [ ] Feature guide changes: TODO - [ ] Database schema migrations: TODO - [ ] Load testing: TODO +- [ ] Load testing/osquery-perf improvements: TODO <-- List, or link a subtask for, any osquery-perf or load test environment changes required to comprehensively load test this story if load testing is needed. --> > ℹ️  Please read this issue carefully and understand it. Pay [special attention](https://fleetdm.com/handbook/company/development-groups#developing-from-wireframes) to UI wireframes, especially "dev notes". diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b7a21670d5..cdfa76c61c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -7,7 +7,6 @@ If some of the following don't apply, delete the relevant line. - [ ] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. - [ ] Input data is properly validated, `SELECT *` is avoided, SQL injection is prevented (using placeholders for values in statements) -- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for new osquery data ingestion features. - [ ] If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes - [ ] If database migrations are included, checked table schema to confirm autoupdate - For new Fleet configuration settings