From d1e8d8d2581155fb4fbdb68158d5f993da996a17 Mon Sep 17 00:00:00 2001 From: Victor Lyuboslavsky <2685025+getvictor@users.noreply.github.com> Date: Wed, 28 Jan 2026 07:06:39 -0600 Subject: [PATCH] Fixed CVE false positive on ninxsoft/Mist. (#38849) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Related issue:** Resolves #37111 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. ## Testing - [x] Added/updated automated tests - [x] QA'd all new/changed functionality manually ## Summary by CodeRabbit * **Bug Fixes** * Fixed false positive CVE detection for ninxsoft Mist, preventing incorrect matching against unrelated vulnerability records. ✏️ Tip: You can customize this high-level summary in your review settings. --- changes/37111-ninxsoft-mist-cve | 1 + server/vulnerabilities/nvd/cpe.go | 11 +++++++++++ server/vulnerabilities/nvd/cpe_test.go | 15 +++++++++++++++ 3 files changed, 27 insertions(+) create mode 100644 changes/37111-ninxsoft-mist-cve diff --git a/changes/37111-ninxsoft-mist-cve b/changes/37111-ninxsoft-mist-cve new file mode 100644 index 0000000000..9923a352c2 --- /dev/null +++ b/changes/37111-ninxsoft-mist-cve @@ -0,0 +1 @@ +Fixed CVE false positive on ninxsoft/Mist. diff --git a/server/vulnerabilities/nvd/cpe.go b/server/vulnerabilities/nvd/cpe.go index 480287a246..d3612e4854 100644 --- a/server/vulnerabilities/nvd/cpe.go +++ b/server/vulnerabilities/nvd/cpe.go @@ -444,6 +444,17 @@ var ( s.Name = "integrative-modeling-platform" }, }, + { + // ninxsoft/Mist (macOS installer download tool) is incorrectly matched against + // mist.io/Mist CPEs. Rename the app to prevent incorrect CPE matching with mist:mist. + // See https://github.com/fleetdm/fleet/issues/37111 + matches: func(s *fleet.Software) bool { + return s.BundleIdentifier == "com.ninxsoft.mist" && s.Source == "apps" + }, + mutate: func(s *fleet.Software, logger log.Logger) { + s.Name = "ninxsoft-mist" + }, + }, } ) diff --git a/server/vulnerabilities/nvd/cpe_test.go b/server/vulnerabilities/nvd/cpe_test.go index 911df1afb2..0b84026481 100644 --- a/server/vulnerabilities/nvd/cpe_test.go +++ b/server/vulnerabilities/nvd/cpe_test.go @@ -2428,6 +2428,21 @@ func TestMutateSoftware(t *testing.T) { Source: "homebrew_packages", }, }, + { + name: "ninxsoft Mist (macOS installer download tool)", + s: &fleet.Software{ + Name: "Mist", + Version: "0.30", + Source: "apps", + BundleIdentifier: "com.ninxsoft.mist", + }, + sanitized: &fleet.Software{ + Name: "ninxsoft-mist", + Version: "0.30", + Source: "apps", + BundleIdentifier: "com.ninxsoft.mist", + }, + }, } { t.Run(tc.name, func(t *testing.T) { require.NotPanics(t, func() { mutateSoftware(tc.s, log.NewNopLogger()) })