From d55d2571bb860439ac6d730f696bbf50ade46907 Mon Sep 17 00:00:00 2001 From: Luke Heath Date: Mon, 23 Mar 2026 14:13:17 -0500 Subject: [PATCH] Fix incorrect labels on VPP and ABM tables (#41986) --- frontend/interfaces/team.ts | 6 ++++++ .../AppleBusinessManagerTableConfig.tsx | 7 ++++--- .../VppPage/components/VppTable/TeamsCell/TeamsCell.tsx | 7 ++++--- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/frontend/interfaces/team.ts b/frontend/interfaces/team.ts index 7174d184f8..4ed3c99016 100644 --- a/frontend/interfaces/team.ts +++ b/frontend/interfaces/team.ts @@ -7,6 +7,7 @@ import { import enrollSecretInterface, { IEnrollSecret } from "./enroll_secret"; import { ITeamIntegrations } from "./integration"; import { UserRole } from "./user"; +import { ITokenTeam } from "./mdm"; export default PropTypes.shape({ id: PropTypes.number.isRequired, @@ -144,3 +145,8 @@ export const APP_CONTEXT_NO_TEAM_SUMMARY: ITeamSummary = { export const isAnyTeamSelected = (currentTeamId?: number) => currentTeamId !== undefined && currentTeamId > APP_CONTEXT_NO_TEAM_ID; + +export const getTeamDisplayName = (team: ITokenTeam) => + team.team_id === APP_CONTEXT_NO_TEAM_ID + ? APP_CONTEXT_NO_TEAM_SUMMARY.name + : team.name; diff --git a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AppleBusinessManagerTable/AppleBusinessManagerTableConfig.tsx b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AppleBusinessManagerTable/AppleBusinessManagerTableConfig.tsx index 5069017fb1..3caf394cc5 100644 --- a/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AppleBusinessManagerTable/AppleBusinessManagerTableConfig.tsx +++ b/frontend/pages/admin/IntegrationsPage/cards/MdmSettings/AppleBusinessManagerPage/components/AppleBusinessManagerTable/AppleBusinessManagerTableConfig.tsx @@ -3,6 +3,7 @@ import { CellProps, Column } from "react-table"; import { IMdmAbmToken } from "interfaces/mdm"; import { IHeaderProps, IStringCellProps } from "interfaces/datatable_config"; +import { getTeamDisplayName } from "interfaces/team"; import { IDropdownOption } from "interfaces/dropdownOption"; import HeaderCell from "components/TableContainer/DataTable/HeaderCell"; @@ -90,7 +91,7 @@ export const generateTableConfig = ( }, { id: "macos_team", - accessor: (originalRow) => originalRow.macos_team.name, + accessor: (originalRow) => getTeamDisplayName(originalRow.macos_team), Header: () => { const titleWithToolTip = ( originalRow.ios_team.name, + accessor: (originalRow) => getTeamDisplayName(originalRow.ios_team), Header: () => { const titleWithToolTip = ( originalRow.ipados_team.name, + accessor: (originalRow) => getTeamDisplayName(originalRow.ipados_team), Header: () => { const titleWithToolTip = ( { let italicize = true; if (teams.length === 1) { italicize = false; - text = teams[0].name; + text = getTeamDisplayName(teams[0]); } else { text = `${teams.length} fleets`; } @@ -37,7 +38,7 @@ const condenseTeams = (teams: ITokenTeam[]) => { (teams?.length && teams .slice(-NUM_TEAMS_IN_TOOLTIP) - .map((team) => team.name) + .map((team) => getTeamDisplayName(team)) .reverse()) || []; @@ -87,7 +88,7 @@ const TeamsCell = ({ teams, className }: ITeamsCellProps) => { } if (teams.length === 1) { - return ; + return ; } const cell = generateCell(teams);