From dbcf31d9fdb4a420bd6a51cbc1f3e86f1bfd6f8a Mon Sep 17 00:00:00 2001 From: Ian Littman Date: Thu, 26 Jun 2025 17:22:44 -0500 Subject: [PATCH] Panic rather than silently continuing when ingestion for FMA manifest updates fails on an app (#30346) Fixes #30338. - [x] Manual QA for all new/changed functionality --- cmd/maintained-apps/main.go | 2 +- ee/maintained-apps/ingesters/winget/ingester.go | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/cmd/maintained-apps/main.go b/cmd/maintained-apps/main.go index c8b4a8482c..65dd526e40 100644 --- a/cmd/maintained-apps/main.go +++ b/cmd/maintained-apps/main.go @@ -42,7 +42,7 @@ func main() { for inputDir, ingest := range ingesters { apps, err := ingest(ctx, logger, inputDir, *slugPtr) if err != nil { - level.Error(logger).Log("msg", "failed to ingest apps", "error", err) + panic(err) } for _, app := range apps { diff --git a/ee/maintained-apps/ingesters/winget/ingester.go b/ee/maintained-apps/ingesters/winget/ingester.go index 6044aa8157..1ce88b2b1f 100644 --- a/ee/maintained-apps/ingesters/winget/ingester.go +++ b/ee/maintained-apps/ingesters/winget/ingester.go @@ -83,8 +83,7 @@ func IngestApps(ctx context.Context, logger kitlog.Logger, inputsPath string, sl outApp, err := i.ingestOne(ctx, input) if err != nil { - level.Warn(logger).Log("msg", "failed to ingest app", "err", err, "name", input.Name) - continue + return nil, ctxerr.Wrap(ctx, err, "ingesting winget app") } manifestApps = append(manifestApps, outApp)