upgrade Go version to 1.21.1 (#13877)

For #13715, this:

- Upgrades the Go version to `1.21.1`, infrastructure changes are
addressed separately at https://github.com/fleetdm/fleet/pull/13878
- Upgrades the linter version, as the current version doesn't work well
after the Go upgrade
- Fixes new linting errors (we now get errors for memory aliasing in
loops! 🎉 )

After this is merged people will need to:

1. Update their Go version. I use `gvm` and I did it like:

```
$ gvm install go1.21.1
$ gvm use go1.21.1 --default
```

2. Update the local version of `golangci-lint`:

```
$ go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.54.2
```

3. (optional) depending on your setup, you might need to re-install some
packages, for example:

```
# goimports to automatically import libraries
$  go install golang.org/x/tools/cmd/goimports@latest

# gopls for the language server
$ go install golang.org/x/tools/gopls@latest

# etc...
```

This commit is contained in:

Roberto Dip

2023-09-13 15:59:35 -03:00

committed by

GitHub

parent 845bd6eef1

commit ea6b59f179

36 changed files with 133 additions and 66 deletions

									
										.github/workflows/integration.yml
									
		+1
		-1
	
												View File
												
				@@ -242,7 +242,7 @@ jobs:

				    - name: Install Go

				      uses: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0

				      with:

				        go-version: '^1.19.12'

				        go-version: '^1.21.1'

				    - name: Checkout Code

				      uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3