From ece080fbe3c666169b49accc03230039e5de4429 Mon Sep 17 00:00:00 2001 From: RachelElysia <71795832+RachelElysia@users.noreply.github.com> Date: Fri, 3 Jan 2025 09:30:59 -0500 Subject: [PATCH] Fleet UI: Fix app id link not row id (#25113) --- changes/23302-fma-click-bug | 1 + .../FleetMaintainedAppsTable.tsx | 10 +++++++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 changes/23302-fma-click-bug diff --git a/changes/23302-fma-click-bug b/changes/23302-fma-click-bug new file mode 100644 index 0000000000..fdd4cd4d2f --- /dev/null +++ b/changes/23302-fma-click-bug @@ -0,0 +1 @@ +- Fleet UI: Fixed redirect when clicking on any column in the Fleet Maintained Apps table diff --git a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppsTable/FleetMaintainedAppsTable.tsx b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppsTable/FleetMaintainedAppsTable.tsx index f993128a90..bb0087a33a 100644 --- a/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppsTable/FleetMaintainedAppsTable.tsx +++ b/frontend/pages/SoftwarePage/SoftwareAddPage/SoftwareFleetMaintained/FleetMaintainedAppsTable/FleetMaintainedAppsTable.tsx @@ -47,6 +47,10 @@ interface IFleetMaintainedAppsTableProps { data?: ISoftwareFleetMaintainedAppsResponse; } +interface IRowProps { + original: IFleetMaintainedApp; +} + const FleetMaintainedAppsTable = ({ teamId, isLoading, @@ -118,9 +122,9 @@ const FleetMaintainedAppsTable = ({ [determineQueryParamChange, generateNewQueryParams, router] ); - const handleRowClick = (row: IFleetMaintainedApp) => { + const handleRowClick = (row: IRowProps) => { const path = `${PATHS.SOFTWARE_FLEET_MAINTAINED_DETAILS( - row.id + row.original.id )}?${buildQueryStringFromParams({ team_id: teamId, })}`; @@ -156,7 +160,7 @@ const FleetMaintainedAppsTable = ({ }; return ( - + className={baseClass} columnConfigs={tableHeadersConfig} data={data?.fleet_maintained_apps ?? []}