From ee47556053dcd70fb21fa775e70adebecbaf3e41 Mon Sep 17 00:00:00 2001 From: jacobshandling <61553566+jacobshandling@users.noreply.github.com> Date: Mon, 3 Feb 2025 17:03:22 -0800 Subject: [PATCH] UI - Fix team admin ability to edit MFA (#26002) ## For #25956 - include the `mfa_enabled` field when rendering the edit user modal - Include `mfa_enabled` as a changeable field in the form submission logic ![ezgif-119080b112463](https://github.com/user-attachments/assets/83baafff-d7ec-4732-a5c0-c1878965d8ce) - [x] Changes file added for user-visible changes in `changes/` - [x] A detailed QA plan exists on the associated ticket (if it isn't there, work with the product group's QA engineer to add it) - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling --- changes/25956-fix-buggy-efa-editing | 1 + .../TeamDetailsWrapper/UsersPage/UsersPageTableConfig.tsx | 1 + .../admin/UserManagementPage/helpers/userManagementHelpers.ts | 1 + 3 files changed, 3 insertions(+) create mode 100644 changes/25956-fix-buggy-efa-editing diff --git a/changes/25956-fix-buggy-efa-editing b/changes/25956-fix-buggy-efa-editing new file mode 100644 index 0000000000..c6202ad51e --- /dev/null +++ b/changes/25956-fix-buggy-efa-editing @@ -0,0 +1 @@ +- Fix a bug where team admins are unable to enable or disable MFA for a user diff --git a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPageTableConfig.tsx b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPageTableConfig.tsx index 6cb769b90d..bfe2e4fc89 100644 --- a/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPageTableConfig.tsx +++ b/frontend/pages/admin/TeamManagementPage/TeamDetailsWrapper/UsersPage/UsersPageTableConfig.tsx @@ -217,6 +217,7 @@ const enhanceUsersData = ( role: generateRole(teamId, user.teams), teams: user.teams, sso_enabled: user.sso_enabled, + mfa_enabled: user.mfa_enabled, global_role: user.global_role, actions: generateActionDropdownOptions(), id: user.id, diff --git a/frontend/pages/admin/UserManagementPage/helpers/userManagementHelpers.ts b/frontend/pages/admin/UserManagementPage/helpers/userManagementHelpers.ts index 0020482da4..86613c8b8b 100644 --- a/frontend/pages/admin/UserManagementPage/helpers/userManagementHelpers.ts +++ b/frontend/pages/admin/UserManagementPage/helpers/userManagementHelpers.ts @@ -32,6 +32,7 @@ const generateUpdateData = ( "name", "email", "sso_enabled", + "mfa_enabled", ]; return Object.keys(formData).reduce( (updatedAttributes, attr) => {