From f3755986c12dcea20c3fd91bdbe7ecd0202577ee Mon Sep 17 00:00:00 2001 From: jacobshandling <61553566+jacobshandling@users.noreply.github.com> Date: Fri, 25 Oct 2024 09:15:43 -0700 Subject: [PATCH] Explicitly set "Add profile" message line heights (#23216) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## #23215 - Explicitly set "Add profile" message line heights so they are consistent cross-browser Screenshot 2024-10-24 at 3 34 45 PM Screenshot 2024-10-24 at 3 34 53 PM - [x] Changes file added for user-visible changes in `changes/`, - [x] Manual QA for all new/changed functionality --------- Co-authored-by: Jacob Shandling --- changes/23215-message-spacing | 1 + .../OSSettings/cards/CustomSettings/_styles.scss | 1 + .../ProfileUploader/components/AddProfileModal/_styles.scss | 1 + 3 files changed, 3 insertions(+) create mode 100644 changes/23215-message-spacing diff --git a/changes/23215-message-spacing b/changes/23215-message-spacing new file mode 100644 index 0000000000..3ad12430b2 --- /dev/null +++ b/changes/23215-message-spacing @@ -0,0 +1 @@ +* Explicitly set line heights on "add profile" messages so they are consistent cross-browser \ No newline at end of file diff --git a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/_styles.scss b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/_styles.scss index 14828cfb9d..30a35b38fb 100644 --- a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/_styles.scss +++ b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/_styles.scss @@ -102,6 +102,7 @@ &--message { text-align: center; + line-height: 20px; } } diff --git a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/_styles.scss b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/_styles.scss index 087e2a54d1..b56cde6f4c 100644 --- a/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/_styles.scss +++ b/frontend/pages/ManageControlsPage/OSSettings/cards/CustomSettings/components/ProfileUploader/components/AddProfileModal/_styles.scss @@ -60,6 +60,7 @@ &--message { text-align: center; + line-height: 20px; } }