Commit Graph
588 Commits
Author SHA1 Message Date
Jahziel Villasana-Espinoza 91fe3e26a8 fix: remove temp dir if installer fails to download (#25392)
> For #25373

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [x] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2025-01-29 18:36:47 -05:00
Jahziel Villasana-EspinozaandIan Littman 6235642d2f fix: add retry logic to saving installation results to avoid incorrectly reporting a failure (#25706)
> For #25210

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).

---------

Co-authored-by: Ian Littman <iansltx@gmail.com>
2025-01-29 17:49:20 -05:00
Victor Lyuboslavsky 5c0dfbf6d9 Fleetd can now download software installers from signed CDN URLs. (#25276)
For #24870 subtask

API changes doc: #25293

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [x] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [x] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2025-01-29 10:24:44 -06:00
github-actions[bot]andlucasmrod 356da61e4b Update versions of fleetd components in Fleet's TUF [automated] (#25848)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2025-01-29 08:16:16 -03:00
Lucas Manuel Rodriguez b0b1dd5445 Release fleetd 1.38.1 (#25786) 2025-01-28 19:38:24 -03:00
github-actions[bot]andlucasmrod e786307b3c Update versions of fleetd components in Fleet's TUF [automated] (#25805)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2025-01-28 09:18:12 -03:00
Lucas Manuel Rodriguez 734b4bd23b Release fleetd 1.38.0 (#25763) 2025-01-27 16:34:59 -03:00
Gabriel Hernandez 2a643c9d87 add telemetry for fleet desktop failing to launch because of missing domain (#25752)
For #25689, #19499

We wanted to add some additional telemetry for fleet desktop to know
when it was failing to launch based on the error message from a [recent
bug] https://github.com/fleetdm/fleet/issues/25689. This bug and some
related ones seemed intermittent and we were unable to reproduced so we
are hoping adding this telemetry to give some more analytics on this
issue.
2025-01-27 17:39:41 +00:00
Katheryn Satterlee e2c6ce435b Fix broken link (#25736)
Fixed broken link to goreleaser-orbit.yaml

Docs only change
2025-01-23 15:29:39 -06:00
Lucas Manuel Rodriguez 88a58041a9 Add update_url column to orbit_info (#25532)
Adding new column to ease TUF migration QA and deployment.

![Screenshot 2025-01-17 at 8 24
56 AM](https://github.com/user-attachments/assets/3565fa4c-4bb4-4218-8122-5f3402e02d99)
2025-01-17 11:52:21 -03:00
github-actions[bot]andlucasmrod 732f46cca7 Update versions of fleetd components in Fleet's TUF [automated] (#25534)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2025-01-17 08:28:46 -03:00
Lucas Manuel Rodriguez a46155c688 Update missing old URL (#25405)
Changing this to reduce confusion moving forward. It didn't cause any
issues because fleetd package always passes this flag to the configured
URL (so the default value is never used when running orbit in fleetd).

"tuf.fleetctl.com" in tooling will be modified (copied) soon.
2025-01-14 12:27:56 -03:00
Lucas Manuel Rodriguez 009f54bdda Changes to migrate to new TUF repository (#23588)
# Changes

- orbit >= 1.38.0, when configured to connect to
https://tuf.fleetctl.com (existing fleetd deployments) will now connect
to https://updates.fleetdm.com and start using the metadata in path
`/opt/orbit/updates-metadata.json`.
- orbit >= 1.38.0, when configured to connect to some custom TUF (not
Fleet's TUFs) will copy `/opt/orbit/tuf-metadata.json` to
`/opt/orbit/updates-metadata.json` (if it doesn't exist) and start using
the latter.
- fleetctl `4.63.0` will now generate artifacts using
https://updates.fleetdm.com by default (or a custom TUF if
`--update-url` is set) and generate two (same file) metadata files
`/opt/orbit/updates-metadata.json` and the legacy one to support
downgrades `/opt/orbit/tuf-metadata.json`.
- fleetctl `4.62.0` when configured to use custom TUF (not Fleet's TUF)
will generate just the legacy metadata file
`/opt/orbit/tuf-metadata.json`.

## User stories

See "User stories" in
https://github.com/fleetdm/confidential/issues/8488.

- [x] Update `update.defaultRootMetadata` and `update.DefaultURL` when
the new repository is ready.
- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [X] Added/updated tests
- [X] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [X] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [X] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [X] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2025-01-10 14:27:30 -03:00
Dante Catalfamo f7ac65d715 Revert "Add SystemDrive env var to osqueryd if present in orbit" (#25239)
Reverts fleetdm/fleet#2520

Was asked to revert this PR so we can include it in the next release
instead
2025-01-08 10:28:28 -05:00
Dante Catalfamo 721b732a90 Add SystemDrive env var to osqueryd if present in orbit (#25208) 2025-01-07 16:12:17 -05:00
github-actions[bot]andlucasmrod 7ac39e23c9 Update versions of fleetd components in Fleet's TUF [automated] (#25088)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2025-01-02 11:43:29 -03:00
github-actions[bot]andlucasmrod 4fdba7b82d Update versions of fleetd components in Fleet's TUF [automated] (#24859)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2024-12-18 09:02:18 -03:00
github-actions[bot]andlucasmrod d94f10f147 Update versions of fleetd components in Fleet's TUF [automated] (#24779)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2024-12-16 12:01:56 -03:00
Lucas Manuel Rodriguez 7d0609341e Release fleetd 1.37.0 (#24752) 2024-12-13 17:08:36 -03:00
Lucas Manuel Rodriguez d81f174ab9 Move orbit changes file (#24731) 2024-12-12 18:38:23 -03:00
Ian Littman 07852b4c60 Bump Go version from 1.23.1 to 1.23.4, Alpine on Docker images from 3.20 to 3.21 (#24518)
Kept the Debian-based image at Bullseye.

For #24517.

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality: Validated builds
(Docker and make) all work after this change, except for BitLocker
(requires Windows).
2024-12-09 11:06:07 -06:00
Tim Lee 7985261009 Support legacy cryptsetup versions on ubuntu 20.04 (#24426) 2024-12-05 11:48:50 -07:00
Tim Lee e3d9801f6d add kdialog for kubuntu key escrow (#24405) 2024-12-05 08:44:16 -07:00
Tim Lee 7547dcb74e bugfix: orbit linux zenity progress windows (#24280) 2024-12-05 08:02:03 -07:00
Andrea ScarpinoandZach Wasserman 0028e2ce3f Add nftables table (#23941)
Following the discussion in #15651, this adds the `nftables` table by parsing the binary output.

---------

Co-authored-by: Zach Wasserman <zach@fleetdm.com>
2024-12-04 10:10:09 -07:00
Scott Gress 04010ba5f3 Use goreleaser v2 in CI (#23748) 2024-12-03 16:15:31 -06:00
Martin Angers f399a90901 Merge branch 'main' into feat-automatic-migrate-windows-hosts 2024-12-02 09:34:49 -05:00
Martin Angers c27c859b3a Windows MDM migration: implement fleetd notification and migration (#24185) 2024-12-02 09:14:10 -05:00
github-actions[bot]andlucasmrod 99d51b32f9 Update versions of fleetd components in Fleet's TUF [automated] (#24223)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2024-11-27 15:31:47 -03:00
Tim Lee 806580bd7f Linux agent LVM volume detection on older Ubuntu versions (#24193) 2024-11-27 10:39:25 -07:00
github-actions[bot]andlucasmrod 24f83d880a Update versions of fleetd components in Fleet's TUF [automated] (#24158)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2024-11-27 08:39:00 -03:00
Lucas Manuel Rodriguez 7d04119245 Release fleetd 1.36.0 (#24136) 2024-11-25 16:34:09 -03:00
Tim Lee 7b932e8e49 linux key escrow progress windows (#24069) 2024-11-22 12:30:13 -07:00
Tim Lee ee1c3c5b8d Linux Key Escrow - Agent (#23771) 2024-11-21 09:31:03 -07:00
Tim Lee 161da905b0 zenity package for Linux (#23619) 2024-11-20 09:44:40 -07:00
Lucas Manuel Rodriguez 8a4fafcc4e Upgrade macadmins osquery-extension to v1.2.3 (#23940)
This upgrade should fix #21311, and @mostlikelee not sure if there's an
issue for the Puppet fix you submitted recently.
2024-11-19 14:54:22 -03:00
Victor Lyuboslavsky 698e9e80fe Added activity item for fleetd enrollment with host serial and display name. (#23790)
#22810 

# Demo
[![22810
demo](http://img.youtube.com/vi/le71QQ92suc/0.jpg)](http://www.youtube.com/watch?v=le71QQ92suc)

# Checklist for submitter

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [x] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [x] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2024-11-18 15:51:36 -06:00
Lucas Manuel Rodriguez c080a3b0e1 Check opt.NativeTooling before creating build directory (#23894)
#23893

Changes on top of the PR from the @ilpianista:
https://github.com/fleetdm/fleet/pull/23796
2024-11-18 11:32:55 -03:00
Andrea Scarpino b488b0e1db [fleetctl] fix deb package build (#23796)
I'm trying to setup a GitLab CI job to build the deb packages, but it
fails with:

```
Error: open output file: open build/fleet-osquery_1.35.0_amd64.deb: no such file or directory
```

It happens because I can't mount the `build` volume as I would do on my
local pc. To reproduce:

```
docker run -it fleetdm/fleetctl package --type=deb --fleet-url=my.url --enroll-secret=mysecret
```

`pkg` and `msi` works fine. I can workaround it by creating the `build`
dir first, but I think that's also fleetctl job to create it.

# Checklist for submitter

- [ ] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [ ] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [ ] Added support on fleet's osquery simulator `cmd/osquery-perf` for
new osquery data ingestion features.
- [ ] Added/updated tests
- [ ] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes
- [ ] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [ ] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [ ] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [ ] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [ ] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [ ] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2024-11-18 10:43:41 -03:00
4b4fc976a2 Add team_identifier to macOS software (#23766)
Changes to add `team_identifier` signing information to macOS
applications on the `/api/latest/fleet/hosts/:id/software` API endpoint.

Docs: https://github.com/fleetdm/fleet/pull/23743

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [X] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [X] Added/updated tests
- [X] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes
- [X] If database migrations are included, checked table schema to
confirm autoupdate
- For database migrations:
- [X] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [X] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [ X Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
- [X] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [X] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [X] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [X] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).

---------

Co-authored-by: Tim Lee <timlee@fleetdm.com>
Co-authored-by: Ian Littman <iansltx@gmail.com>
2024-11-15 14:17:04 -03:00
Victor Lyuboslavsky dd2dde0b8f Adding logging to TestRenewEnrollmentProfilePrevented (#23742)
#22363 

The TestRenewEnrollmentProfilePrevented test timed out once in recent
history. I did not find any obvious issues with this test, but I added
logging which may help if it times out again in the future.

Also, I sped the test up.
2024-11-13 09:27:39 -06:00
Dante Catalfamo 33a4887400 Swiftdialog Closed method (#23024) 2024-11-12 15:52:46 -05:00
github-actions[bot]andlucasmrod 2490e105ee Update versions of fleetd components in Fleet's TUF [automated] (#23704)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2024-11-11 20:27:26 -03:00
Ian Littman 8b2d21604e Delete Fleet Desktop auth token when we detect a migrated host (#23658)
#23164

This ensures that "My device" correctly shows the current host
immediately after migration, rather than the old host (Orbit is already
reporting on the current host correctly due to swapped node keys)

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).

QA'd on macOS as there's a runtime guard on this code.
2024-11-09 23:35:49 -06:00
Ian Littman 28cd420b08 Set self-service on initial data pull when premium license is set (#23641)
#21948

This should avoid temporary periods where self-service is missing when
it shouldn't be.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [ ] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [ ] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [ ] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).

Will validate updates and cross-OS compat once code is reviewed and I
hear back on logs to make sure this is the correct fix.
2024-11-08 17:15:29 -06:00
Lucas Manuel Rodriguez 4eabb68f6e Prevent broken build system when Ctrl+C a orbit/desktop windows compilation (#23623)
#23606

A Ctrl+C during a fleetd Windows build could leave a windows syso named
`resource.syso` in Fleet Desktop folder which was preventing macOS/Linux
builds from happening.

Related: https://github.com/josephspurrier/goversioninfo/issues/14

PS: If you already have a lingering `resource.syso` in `orbit/cmd/orbit`
or `orbit/cmd/desktop` then removing it will solve the issue.
2024-11-07 15:55:41 -03:00
Rachael ShawandIan Littman 1e0c482290 #23314: Rename "Transparency" menu item in Fleet Desktop (#23392)
Took a stab at implementing #23314 since it is a text change only.

Documentation changes are
[here](https://github.com/fleetdm/fleet/pull/23375); if this gets merged
I'll make a new PR to the v4.60.0 docs.

---------

Co-authored-by: Ian Littman <iansltx@gmail.com>
2024-11-06 17:00:37 -06:00
github-actions[bot]andlucasmrod 309534038e Update versions of fleetd components in Fleet's TUF [automated] (#23568)
Automated change from [GitHub
action](https://github.com/fleetdm/fleet/actions/workflows/fleetd-tuf.yml).

Co-authored-by: lucasmrod <lucasmrod@users.noreply.github.com>
2024-11-06 08:54:54 -03:00
Victor Lyuboslavsky ea8b58a356 Store/retrieve Fleet URL and enroll secret when MDM profile has been removed (#23559)
#23438

# Demo
<div>
<a href="https://www.loom.com/share/d5c0340512df49acba1f5412789f145b">
<p>[Demo] fleetd connecting to Fleet server when MDM profiles removed
(#23438) - Watch Video</p>
    </a>
<a href="https://www.loom.com/share/d5c0340512df49acba1f5412789f145b">
<img style="max-width:300px;"
src="https://cdn.loom.com/sessions/thumbnails/d5c0340512df49acba1f5412789f145b-6688b64fea2e09ca-full-play.gif">
    </a>
  </div>

# Checklist for submitter
- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [x] Orbit runs on macOS, Linux and Windows. Check if the orbit
feature/bugfix should only apply to one platform (`runtime.GOOS`).
- [x] Manual QA must be performed in the three main OSs, macOS, Windows
and Linux.
- [x] Auto-update manual QA, from released version of component to new
version (see [tools/tuf/test](../tools/tuf/test/README.md)).
2024-11-05 16:53:09 -06:00
Victor Lyuboslavsky 3cf99f8039 Enable staticcheck Go linter. (#23487)
#23486 

Linter: https://staticcheck.dev/
2024-11-05 11:16:24 -06:00