Commit Graph
845 Commits
Author SHA1 Message Date
Lucas Manuel Rodriguez e2e8c32797 Increase sleep time in verify-fleetd-base.yml (#27763)
https://github.com/fleetdm/fleet/actions/runs/14211929711
2025-04-02 14:30:04 -03:00
Ian Littman 6be5cf55cb Fix path for go-version-file in FMA ingest job (#27744)
When Go version switched from being hardcoded to being based off of the
deps file, Fleet being checked out into a subdir wasn't taken into
account, so FMA ingest jobs started failing. This adds the (hopefully)
correct dir to fix the issue and get FMA ingest working again.
2025-04-01 16:19:21 -05:00
Noah Talerman a25afdf7b2 Fleet UI breakpoints: Drafting and implementing (#27733)
- Update story template as a reminder for Product Designers to consider
Fleet's breakpoints: 480, 768, 1024, 1280, and 1440px
- Only need wireframes when there are substantial changes (ex. dropping
columns or wrapping elements)
- Update Product Groups handbook to clarify that Engineers are
responsible for filling in gaps for smaller changes. Engineers bring
proposed changes to their product group's design review meeting.
2025-04-01 16:24:48 -04:00
0293d99800 Remove default EXE install/uninstall scripts, require entering install/uninstall scripts on EXE upload (#27268)
For #27267.

Below is what's shown immediately after selecting an EXE:

<img width="1254" alt="image"
src="https://github.com/user-attachments/assets/a28d8565-de88-448a-bdbc-92aefc34ad55"
/>


TODO:

* Tests
* GitOps requirements changes
* Disabling add button/adding errors when required scripts aren't
specified

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] Added/updated automated tests
- [x] A detailed QA plan exists on the associated ticket (if it isn't
there, work with the product group's QA engineer to add it)
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Luke Heath <luke@fleetdm.com>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
Co-authored-by: RachelElysia <rachel@fleetdm.com>
2025-03-31 13:52:06 -05:00
Scott Gress 59f96651b6 Update to Go 1.24.1 (#27506)
For #26713 

# Details

This PR updates Fleet and its related tools and binaries to use Go
version 1.24.1.

Scanning through the changelog, I didn't see anything relevant to Fleet
that requires action. The only possible breaking change I spotted was:

> As [announced](https://tip.golang.org/doc/go1.23#linux) in the Go 1.23
release notes, Go 1.24 requires Linux kernel version 3.2 or later.

Linux kernel 3.2 was released in January of 2012, so I think we can
commit to dropping support for earlier kernel versions.

The new [tools directive](https://tip.golang.org/doc/go1.24#tools) is
interesting as it means we can move away from using `tools.go` files,
but it's not a required update.

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
- [x] Manual QA for all new/changed functionality
- For Orbit and Fleet Desktop changes:
- [X] Make sure fleetd is compatible with the latest released version of
Fleet
   - [x] Orbit runs on macOS  , Linux   and Windows. 
- [x] Manual QA must be performed in the three main OSs, macOS ,
Windows and Linux .
2025-03-31 11:14:09 -05:00
Noah TalermanandLucas Manuel Rodriguez e93750edab Cleanup scripts (#27307)
- Move duplicate scripts out of `scripts/mdm/` and into
`it-and-security/` so we have one version that we can continue to
iterate and improve.
- Remove no longer used scripts out of `scripts/mdm/`

---------

Co-authored-by: Lucas Manuel Rodriguez <lucas@fleetdm.com>
2025-03-27 16:43:53 -05:00
Lucas Manuel Rodriguez 60f829f6bd Fix code scanning alerts (#27074)
These are fixes to some of the alerts in:
https://github.com/fleetdm/fleet/security/code-scanning
2025-03-27 10:01:20 -03:00
Victor Lyuboslavsky 527428f0b4 Speeding up Go tests in CI. (#27434)
Using `go get .` (~3s) is faster than `go mod download` (~13s) in CI.
2025-03-25 12:03:24 -05:00
Allen Houchins d2189acbd9 Update dogfood-policy-updater-latest-1password-macos.sh (#27395)
Script has been updated to ignore pre-release/beta version strings. 

More info here:
https://fleetdm.slack.com/archives/C071NNMSP2R/p1742568702131279
2025-03-21 10:52:35 -05:00
Scott GressandTim Lee bbe3f18b88 Dismiss old FMA PRs after creating a new one (#27359)
We have a scheduled action to create an "Update Fleet-maintained apps"
PR with the latest updates for FMAs. The bot creates a new PR each time,
even if the previous PRs haven't been merged. Since the latest PR will
always have all the latest updates, it's unnecessary to keep the old
ones around. We should have the bot close the old PRs once the new one
is opened. Additionally it was recommended that assignees be added to
the PR.

This PR updates the action to:

1. Find existing "Update Fleet-maintained apps" PRs created by the bot
2. Get the list of Github IDs of the devs on the software product team
3. Creates a new PR as usual, adding the devs as assignees
4. If the new PR is created successfully, closes the old PRs with
comments linking to the new PR

See a successful run
[here](https://github.com/fleetdm/fleet/actions/runs/13977643317/job/39135240445),
+ the resulting PR [here](https://github.com/fleetdm/fleet/pull/27357)

---------

Co-authored-by: Tim Lee <timlee@fleetdm.com>
2025-03-21 09:32:02 -05:00
Luke Heath 0c81e7ba04 Address code scanning permissions warnings (#27250) 2025-03-20 12:07:41 -05:00
Noah Talerman dea69de8d8 User story template (#27293)
Add a "Contributor API changes" checkbox in the "Engineering" section.
This way we spec contributor API changes before we get to estimation.
2025-03-19 16:04:05 -05:00
Allen Houchins 30012688d1 Added policy automation and new Windows installer (#27244)
- Added script and workflow to keep 1Password policy up to date
- Changed to using .msi instead of .exe for Windows installer
2025-03-19 13:54:25 -05:00
Janis Watts 07f70df43f Updated migration test section (#27256)
Updated migration test section to reflect new fancy github action
instead of script
2025-03-19 10:00:38 -05:00
Victor Lyuboslavsky eae1fd30a1 Add stale issues workflow (#27047)
Add stale issues workflow which:
- marks `~engineering-initiated` issues with `stale` label and comment
if they had no activity in the last 365 days (we have ~74 such issues
right now)
- closes `stale` issues after 14 days with no activity

Examples of "recent" stale issues:
- https://github.com/fleetdm/fleet/issues/13984
- https://github.com/fleetdm/fleet/issues/15571
- https://github.com/fleetdm/fleet/issues/16117
- https://github.com/fleetdm/fleet/issues/16352

Here's an example issue with a `stale` label. I ran the workflow and
marked 27 issues as `stale` that had no activity for 1000 days.
- https://github.com/fleetdm/fleet/issues/4631
2025-03-14 16:11:43 -05:00
Lucas Manuel Rodriguez 5a84fa0d11 Release fleetd 1.40.1 (#27157) 2025-03-14 17:10:15 -03:00
Lucas Manuel Rodriguez b30a008aac Simplify DB test/upgrade tool (#27141)
This PR simplifies the `test/upgrade` tool the QA team uses to test DB
upgrades.

- Removes "online migration" approach because we currently don't support
it (so it removes nginx as dependency).
- Adds a workflow to manually run this on Github actions (in case dev/QA
folks have issues with Docker on macOS, which is a common thing...)
- Adds logging to the output to ease troubleshoot (previous versions was
too quiet making it impossible to troubleshoot).
2025-03-14 17:07:41 -03:00
Lucas Manuel Rodriguez 30f1c329b4 Build orbit on ubuntu-20.04 (#27156)
For #27155.

Reverting to use ubuntu-20.04 to unblock the release of fleetd 1.40.1.
We'll need a proper solution for 1.41.0 given that ubuntu-20.04 will be
removed on April 1st 2025.

- [X] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/Committing-Changes.md#changes-files)
for more information.
2025-03-14 16:17:38 -03:00
Tim Lee baf220a779 Fix: Update FMA Action (#27128) 2025-03-13 16:54:04 -06:00
Noah TalermanandSam Pfluger 3195d0f974 Air guitar process: add issue template & update process (#26808)
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
2025-03-13 11:07:10 -05:00
Jahziel Villasana-EspinozaandIan Littman 4e325bb131 FMAv2 ingestion functionality (#27018)
> For #26083

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Added/updated automated tests
- [x] Manual QA for all new/changed functionality

---------

Co-authored-by: Ian Littman <iansltx@gmail.com>
2025-03-12 17:51:14 -04:00
Lucas Manuel Rodriguez a0be5164e3 Release fleetd 1.40.0 (#27053) 2025-03-12 13:15:38 -03:00
Robert Fairburn f32f80261a Add cloudfront to dogfood (#26962) 2025-03-12 10:59:39 -05:00
Scott Gress caa91dbc04 Update goreleaser-fleet workflow to use ubuntu-22.04-4-cores runner (#26930)
For #26927 

See
[actions/runner-images#11101](https://github.com/actions/runner-images/issues/11101)
and https://github.com/fleetdm/fleet/pull/26466/files. Updating
explicitly to `ubuntu-22.04-4-cores` to not have it float with `latest`.
[Other](https://github.com/fleetdm/fleet/blob/6e097988d5e1172660d81ec668d055d408e7a54e/.github/workflows/goreleaser-orbit.yaml#L81)
[goreleaser](https://github.com/fleetdm/fleet/blob/6e097988d5e1172660d81ec668d055d408e7a54e/.github/workflows/goreleaser-snapshot-fleet.yaml#L40)
workflows use 22.04.
2025-03-10 10:01:36 -05:00
4b3e2a0f69 Create design-qa-considerations.md (#26774)
Co-authored-by: Marko Lisica <83164494+marko-lisica@users.noreply.github.com>
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
Co-authored-by: Sam Pfluger <108141731+Sampfluger88@users.noreply.github.com>
2025-03-07 15:32:41 -06:00
Noah Talerman ba4608455f Capital "D" in "Product Designer" (#26947) 2025-03-07 13:44:09 -06:00
Sarah Gillespie 44a985d06e Update PR template with checklist item regarding potential load test impact of unreleased bug fixes (#26909) 2025-03-07 12:27:46 -06:00
Ian Littman e7d04f2ff0 Clean up Python 3.12 vulns test expectations, fix continue-on-error behavior for integration and vulns suites (#26903)
From what I can tell, continue-on-error has been false for the
integration suites since the suites were renamed to `integration-*`, so
this fixes that issue in addition to continuing to run test suites when
the vulns suite fails (which may be due to vulns feed updates).

This also makes the vulns test more resilient to new CVEs being reported
on Python 3.12.0, which is rather likely to collect new CVEs.

# Checklist for submitter

- [x] Added/updated automated tests
2025-03-06 08:46:07 -06:00
Victor Lyuboslavsky 46719c9fb2 Auto-generate and check Android schema.sql (#26720)
For #26218 

This is an infrastructure change. No functional feature changes.
2025-02-28 16:30:40 -06:00
Luke Heath 658330d4f4 Enable Android in dogfood (#26735) 2025-02-28 16:26:11 -06:00
Scott Gress f7e4a39915 Add help system to Makefile + FDM command (#25028) 2025-02-28 07:42:32 -06:00
Lucas Manuel Rodriguez 74f7548fd1 Add workflow to update timestamp on new repository (#26635)
For #26482.
2025-02-27 18:02:42 -03:00
Lucas Manuel Rodriguez 5e453b7ca6 Check for timestamps on the new TUF repository (#26638)
For #26483.
2025-02-27 17:59:11 -03:00
Lucas Manuel Rodriguez 6e097988d5 Update ubuntu-20.04 to ubuntu-22.04 on CI actions due to deprecation (#26466)
> We will soon start the deprecation process for Ubuntu 20.04. While the
image is being deprecated, you may experience longer queue times during
peak usage hours. Deprecation will begin on 2025-02-01 and the image
will be fully unsupported by 2025-04-01.

From https://github.com/actions/runner-images/issues/11101.

![Screenshot 2025-02-19 at 4 39
10 PM](https://github.com/user-attachments/assets/803e8ed3-31b0-4221-9d29-446a0d305567)
2025-02-21 13:11:50 -03:00
Janis Watts 3ee2c0c3b1 Update fleetd smoke tests (#26467)
Added additional section in fleetd testing to include testing against
the current released version of fleet. Outcome of Incident Postmortem
#26283
2025-02-20 16:57:31 -06:00
Allen HouchinsandNoah Talerman 0a94f81431 Switched from metadata_url to metadata for end user authentication (#26042)
Switched from metadata_url to metadata for end user authentication.

---------

Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
2025-02-20 10:02:24 -06:00
Sam Pfluger cd36118e63 Update labels and slack channels (#26481) 2025-02-20 01:28:15 -06:00
Lucas Manuel Rodriguez 306d1c91c5 Add reminder must rule (#26461)
Related to fleetd critical issue in 1.39.0.
2025-02-19 16:31:43 -03:00
Allen Houchins 330eed346e Update dogfood-policy-updater-latest-macos.sh (#26456)
Added more reviewers
2025-02-19 11:00:22 -06:00
Lucas Manuel Rodriguez e5fd094c68 Release osqueryd 5.16.0 (#26394)
For #26324.
2025-02-18 16:59:09 -03:00
Noah Talerman cdaee64094 User story template (#26364)
We're not ready for 320px yet but we will be soon!
2025-02-14 17:34:21 -05:00
Allen Houchins 83ffe1791b Update dogfood-policy-updater-latest-macos.sh (#26359)
Updated reviewers list to not include the author as a reviewer
2025-02-14 14:52:59 -06:00
Allen Houchins 1ec82f1544 Added troubleshooting logic (#26357)
Added troubleshooting logic to the
dogfood-policy-updater-latest-macos.sh script
2025-02-14 14:39:58 -06:00
Allen Houchins 2afff8242e Update dogfood-policy-updater-latest-macos.sh (#26351)
Updated script to automatically add reviewers to the pull request that
is created.
2025-02-14 14:10:34 -06:00
Tim Lee c582f74fdd Release fleetd 1.39.1 (#26314) 2025-02-13 16:26:18 -07:00
Martin Angers 240f55b9e8 Add script execs and software installs stats to osquery-perf (#26239) 2025-02-11 12:46:53 -05:00
Allen Houchins 94f620a76f Update dogfood-policy-updater-latest-macos.sh (#26248)
Updated variable names in script.
2025-02-10 19:06:33 -06:00
Janis Watts 27d8f8ee4b Update release-qa.md with load test expectations (#26181) 2025-02-08 23:17:57 -06:00
Lucas Manuel Rodriguez a216c9d9e5 Release fleetd 1.39.0 (#26185) 2025-02-07 18:52:06 -03:00
Lucas Manuel Rodriguez 9114d0405b Update TUF status generation to use new TUF repository (#26099)
For #25853.
2025-02-07 08:30:07 -03:00