Files
fleet/.github/workflows/test-fma-darwin-pr-only.yml
Workflow config file is invalid. Please check your config file: getMatrixes: matrix include must be a list of mappings
Allen HouchinsandCopilot Autofix powered by AI 9b5fc40b2e Shard FMA validation workflows and route Windows apps to arch-matched runners (#49348)
**Related issue:** N/A — CI improvement for the FMA validation
workflows.

## Summary

Restructures the Windows and macOS Fleet-maintained app validation
workflows around a cheap Linux detect/shard job, with Windows apps
additionally routed to a CI runner whose native architecture matches the
app's installer.

**Both platforms:**

- Change detection and sharding run on `ubuntu-latest`. Expensive
Windows/macOS runners only spin up when their platform actually has
changed apps — e.g. a Windows-only letter-batch PR no longer boots a
macOS runner just to discover there's nothing to do (and vice versa) —
and they check out at depth 1 instead of full history.
- A new `.github/scripts/partition-fma-apps.sh <windows|darwin>` emits
the job matrix; validation steps move unchanged into reusable workflows
(`test-fma-windows-validate.yml`, `test-fma-darwin-validate.yml`).
- Large PRs shard into parallel jobs (Windows: 25 apps/shard, macOS:
30), and the manual full-run workflows gain a `shard_size` input
(Windows default 20 → ~20 shards over 384 apps; macOS default 25 → ~39
shards over 961 apps). Neither full run could previously finish:
hundreds of sequential installs blow the 6-hour job limit.
- Pre-installed app handling is computed per shard from that shard's
slug list — Windows removals (Chrome, 7-Zip, Firefox, Node.js,
PowerShell, R, Git) and macOS steps (Chrome, Xcode for Icon Composer,
the Fleet Desktop MDM config stub) only run on the runner validating
that app. This also brings the full-run workflows to parity with the PR
gates (they previously only removed Chrome).
- Stable summary jobs (`test-fma-pr-only`, `test-fma`) aggregate the
dynamic matrix results so branch protection / PR gating keeps a fixed
check name.

**Windows arch routing:**

- Each changed `<name>/windows` slug's `installer_arch` is read from
`ee/maintained-apps/inputs/winget/<name>.json`: `arm64` apps →
`windows-11-arm`, x64/x86/neutral apps → `windows-latest` (x64). Missing
input files default to x64 with a warning. This fixes installers that
check the native OS architecture and abort under Prism emulation on the
ARM runner (Inno Setup `ArchitecturesAllowed=x64` — GOG Galaxy, Reqable
— and Docker Desktop). Future arm64 FMAs need no workflow change —
`installer_arch: arm64` in the winget input is enough.
- macOS needs no arch matrix: `macos-latest` is arm64 and x86-only casks
run under Rosetta 2, which matches how customer Macs run them.

# Checklist for submitter

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects, and untrusted
data interpolated into shell scripts/commands is validated against shell
metacharacters.

## Testing

- [x] QA'd all new/changed functionality manually

Manual QA:
- Partition script is shellcheck-clean and tested against the real repo
for both platforms: empty input, mixed-platform slug lists, x86/neutral
routing to the x64 runner, single-slug arrays, missing input file
fallback, arm64/x64 split with sharding (via a synthetic arm64 input),
invalid platform/shard-size rejection, and full-catalog partitions (384
Windows apps → 20 shards, 961 darwin apps → 39 shards, all slugs
accounted for, matrix outputs well under the 1 MB job-output limit).
- All six workflows pass `actionlint` and zizmor 1.25.2 (with the repo's
`.github/zizmor-gate.yml` config) with no findings.
- The rewritten Windows PR gate ran on this PR itself: the Linux detect
job correctly found no changed Windows apps, skipped the Windows
runners, and the `test-fma-pr-only` summary check passed.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **New Features**
* Added sharded validation for maintained macOS and Windows apps to run
tests in parallel.
  * Added configurable `shard_size` for manual validation runs.
  * Introduced reusable validation workflows for Darwin and Windows.
  * Improved Windows testing to be architecture-aware (ARM64 vs x64).
* **Bug Fixes**
* Improved pull request gating to validate only changed apps and report
results more reliably.
* Workflows now gracefully handle scenarios where no matching apps are
found (avoid unnecessary failures).
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
2026-07-15 16:07:36 -05:00

117 lines
4.0 KiB
YAML

name: Test Fleet Maintained Apps - Darwin (PR Only)
on:
pull_request:
types: [opened, synchronize, reopened]
paths:
- ee/maintained-apps/inputs/**
- ee/maintained-apps/outputs/**
- cmd/maintained-apps/validate/**
- .github/workflows/test-fma-darwin-pr-only.yml
- .github/workflows/test-fma-darwin-validate.yml
- .github/scripts/partition-fma-apps.sh
- .github/scripts/detect-new-fmas-in-pr.sh
- .github/scripts/filter-apps-json.sh
workflow_dispatch: # Manual trigger
inputs:
log_level:
description: "Log level (debug, info, warn, error)"
required: false
default: "info"
type: choice
options:
- debug
- info
- warn
- error
permissions:
contents: read
jobs:
# Detect which apps changed and shard them on a cheap Linux runner. The
# (much more expensive) macOS runners below only spin up when there are
# darwin apps to validate — Windows-only FMA PRs no longer boot a macOS
# runner just to discover there is nothing to do. Large PRs are split into
# shards that validate in parallel.
detect-changed-apps:
runs-on: ubuntu-latest
outputs:
has_darwin_apps: ${{ steps.partition.outputs.has_apps }}
matrix: ${{ steps.partition.outputs.matrix }}
steps:
- name: Harden Runner
uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4
with:
egress-policy: audit
- name: Checkout Fleet
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
fetch-depth: 0 # Need full history to compare with base branch
persist-credentials: false
- name: Detect changed apps
id: detect-changed
env:
GITHUB_BASE_REF: ${{ github.event.pull_request.base.ref || github.base_ref || 'main' }}
run: |
# fetch-depth 0 normally brings in the base branch already; fetch it
# explicitly as a fallback so origin/$GITHUB_BASE_REF exists.
git fetch origin "$GITHUB_BASE_REF" || true
bash .github/scripts/detect-new-fmas-in-pr.sh
- name: Shard Darwin apps
id: partition
env:
CHANGED_APPS: ${{ steps.detect-changed.outputs.CHANGED_APPS }}
run: |
bash .github/scripts/partition-fma-apps.sh darwin "${CHANGED_APPS:-[]}" 30
validate:
needs: detect-changed-apps
if: needs.detect-changed-apps.outputs.has_darwin_apps == 'true'
name: ${{ matrix.name }}
strategy:
# Don't cancel the other shards' validation if one fails.
fail-fast: false
matrix:
include: ${{ fromJSON(needs.detect-changed-apps.outputs.matrix) }}
uses: ./.github/workflows/test-fma-darwin-validate.yml
permissions:
contents: read
with:
runner: ${{ matrix.runner }}
slugs: ${{ matrix.slugs }}
log_level: ${{ github.event.inputs.log_level || 'info' }}
# Stable-named summary check (matches the old single-job name) so PR gating
# doesn't depend on the dynamic per-shard matrix job names.
test-fma-pr-only:
needs: [detect-changed-apps, validate]
if: always()
runs-on: ubuntu-latest
steps:
- name: Harden Runner
uses: step-security/harden-runner@9af89fc71515a100421586dfdb3dc9c984fbf411 # v2.19.4
with:
egress-policy: audit
- name: Check validation results
env:
DETECT_RESULT: ${{ needs.detect-changed-apps.result }}
VALIDATE_RESULT: ${{ needs.validate.result }}
run: |
echo "detect-changed-apps: $DETECT_RESULT"
echo "validate: $VALIDATE_RESULT"
if [ "$DETECT_RESULT" != "success" ]; then
echo "Detecting changed apps failed"
exit 1
fi
# validate is skipped when the PR changes no darwin apps.
if [ "$VALIDATE_RESULT" != "success" ] && [ "$VALIDATE_RESULT" != "skipped" ]; then
echo "Validation failed"
exit 1
fi
echo "All Darwin FMA validations passed"