Resolves #36087 (one of several PRs). ## Testing - [x] QA'd all new/changed functionality manually. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Dry-run support when creating secret variables. * **Improvements** * Standardized API models for secret-variables and targets for more consistent behavior. * List secret variables now includes pagination metadata. * More consistent error reporting across secret-variables and targets APIs. * Target search/count behavior refined: pre-selected built-in labels are omitted as expected. * **Tests** * Integration tests updated to validate the new request/response behavior and target-selection logic. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/fleetdm/fleet/pull/46196?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
39 lines
979 B
Go
39 lines
979 B
Go
package service
|
|
|
|
import (
|
|
"github.com/fleetdm/fleet/v4/server/fleet"
|
|
)
|
|
|
|
// SearchTargets searches for the supplied targets in the Fleet instance.
|
|
func (c *Client) SearchTargets(query string, hostIDs, labelIDs []uint) (*fleet.TargetSearchResults, error) {
|
|
req := fleet.SearchTargetsRequest{
|
|
MatchQuery: query,
|
|
Selected: fleet.HostTargets{
|
|
LabelIDs: labelIDs,
|
|
HostIDs: hostIDs,
|
|
// TODO handle TeamIDs
|
|
},
|
|
}
|
|
verb, path := "POST", "/api/latest/fleet/targets"
|
|
var responseBody fleet.SearchTargetsResponse
|
|
err := c.authenticatedRequest(req, verb, path, &responseBody)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
hosts := make([]*fleet.Host, len(responseBody.Targets.Hosts))
|
|
for i, h := range responseBody.Targets.Hosts {
|
|
hosts[i] = h.Host
|
|
}
|
|
|
|
labels := make([]*fleet.Label, len(responseBody.Targets.Labels))
|
|
for i, h := range responseBody.Targets.Labels {
|
|
labels[i] = h.Label
|
|
}
|
|
|
|
return &fleet.TargetSearchResults{
|
|
Hosts: hosts,
|
|
Labels: labels,
|
|
}, nil
|
|
}
|