Sharon Katz
d498c1e312
Closes #42249 Supersedes #42247 (stale draft with merge conflicts) ## Summary - Hides the "Rotate password" button entirely in the Recovery Lock password modal when the user has the Observer role (`canRotatePassword` is false), instead of showing a disabled span with a tooltip - Removes unused `TooltipWrapper` import and orphaned SCSS styles for the disabled state - Consistent with the existing pattern in `ManagedAccountModal` which already hides the button for observers ## Changes - `RecoveryLockPasswordModal.tsx`: Return `null` when `!canRotatePassword` instead of rendering disabled tooltip - `_styles.scss`: Remove `__rotate-button--disabled` styles - Added `RecoveryLockPasswordModal.tests.tsx` with two tests covering button visibility based on role ## How I tested - Added unit tests (following the `ManagedAccountModal.tests.tsx` pattern) that verify: - The "Rotate password" button is **not rendered** when `canRotatePassword={false}` (Observer role) - The "Rotate password" button **is rendered** when `canRotatePassword={true}` (Admin/Maintainer role) - Both tests pass locally - ESLint passed clean on all changed files - Webpack build succeeded; verified the built bundle no longer contains the old tooltip text or disabled-button CSS class ## Test plan - [ ] Log in as an Observer, navigate to a macOS host with Recovery Lock, open the Recovery Lock password modal, and confirm the "Rotate password" button is not visible - [ ] Log in as an Admin/Maintainer and confirm the "Rotate password" button still appears and works <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * The "Rotate password" control in the Recovery Lock Password modal is now hidden when password rotation is unavailable (e.g., for Observer role) instead of being shown as a disabled control. * **Tests** * Added tests verifying the rotate-button visibility behavior based on rotation availability/permissions. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/fleetdm/fleet/pull/45649?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
2 lines
140 B
Plaintext
2 lines
140 B
Plaintext
* Hid the "Rotate password" button in the Recovery Lock password modal for users with the Observer role, instead of showing it as disabled.
|