Allen Houchins
2b5e5049ed
This pull request adds support for PowerShell as a managed Windows app, including its metadata, versioning, install/uninstall scripts, and validation logic in the CI workflow. It also ensures that any pre-installed PowerShell 7 is removed from the test environment before validation. The most important changes are: **PowerShell app definition and metadata:** * Added a new entry for PowerShell in `ee/maintained-apps/inputs/winget/powershell.json` and included its metadata in `ee/maintained-apps/outputs/apps.json`, enabling PowerShell to be managed as a Windows app. [[1]](diffhunk://#diff-7e4899a379d327948f55b7e6ba4c9893501713edd16020b128b68343569fcbfbR1-R10) [[2]](diffhunk://#diff-4c1446cfc02c6bb0bda874481e333c65b84e184fcea52f656b49a6489f73c9c2R1985-R1991) * Created `ee/maintained-apps/outputs/powershell/windows.json` containing version information, SQL queries for existence and patch status, installer/uninstaller scripts, and download URL for PowerShell 7.6.2.0. **CI workflow enhancements for PowerShell:** * Updated `.github/workflows/test-fma-windows-pr-only.yml` to detect changes involving PowerShell, set the appropriate output flags, and conditionally execute PowerShell-specific steps. [[1]](diffhunk://#diff-51641fd1d2cc19348b81fd8310b62ad270ca5082ceddff2d49064e78f126a1eaR102) [[2]](diffhunk://#diff-51641fd1d2cc19348b81fd8310b62ad270ca5082ceddff2d49064e78f126a1eaR116) [[3]](diffhunk://#diff-51641fd1d2cc19348b81fd8310b62ad270ca5082ceddff2d49064e78f126a1eaR155-R162) * Added a workflow step to remove any pre-installed PowerShell 7 from the GitHub Actions runner, ensuring a clean environment for validation. * Ensured that validation and related steps use Windows PowerShell 5.1 (not pwsh) after uninstalling PowerShell 7, to avoid shell availability issues. These changes collectively enable PowerShell to be validated, installed, and uninstalled as part of the managed apps ecosystem and ensure reliable, repeatable CI validation. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added PowerShell as a supported application with full Windows integration, including installation and uninstall management capabilities. * Enhanced deployment scripts to support flexible input handling for app configurations. * Added PowerShell icon to the frontend UI for visual identification. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
Github Actions
Fleet uses Github Actions for continuous integration (CI). This document describes best practices and at patterns for writing and maintaining Fleet's Github Actions workflows.
Bash
By default, Github Actions sets the shell to bash -e for linux and MacOS runners. To help write
safer bash scripts in run jobs and avoid common issues, override the default by adding the following
to the workflow file
defaults:
run:
# fail-fast using bash -eo pipefail. See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference
shell: bash
By specifying the default shell to bash, some extra flags are set. The option pipefail changes
the behaviour when using the pipe | operator such that if any command in a pipeline fails, that
commands return code will be used a the return code for the whole pipeline. Consider the following
example in test-go.yaml
- name: Run Go Tests
run: |
# omitted ...
make test-go 2>&1 | tee /tmp/gotest.log
If the pipefail option was not set, this job would always succeed because tee would always
return success. This is not the intended behavior. Instead, we want the job to fail if make test-go fails.
Concurrency
Github Action runners are limited. If a lot of workflows are queued, they will wait in pending until a runner becomes available. This has caused issue in the past where workflows take an excessively long time to start. To help with this issue, use the following in workflows
# This allows a subsequently queued workflow run to interrupt previous runs
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id}}
cancel-in-progress: true
When a workflow is triggered via a pull request, it will cancel previous running workflows for that
pull request. This is especially useful when changes are pushed to a pull request frequently.
Manually triggered workflows, workflows that run on a schedule, and workflows triggered by pushes to
main are unaffected.