Discharge7443/fleet
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity
Files
a0f60dc7f85960409161c191f469f2ec124f8fbb
fleet/server/service
T
History
Martin Angers a0f60dc7f8 DDMV: fix unresolved Fleet variable in DDM profile behavior (#43556) 
<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #43047 

Follow-up to https://github.com/fleetdm/fleet/pull/43222

# Checklist for submitter

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements), JS
inline code is prevented especially for url redirects, and untrusted
data interpolated into shell scripts/commands is validated against shell
metacharacters.

## Testing

- [x] Added/updated automated tests

- [x] QA'd all new/changed functionality manually
See
https://github.com/fleetdm/fleet/issues/42960#issuecomment-4246769629


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Improved Apple MDM declaration handling: declarations with unresolved
per-device variables are now attempted per host, marked failed when
resolution fails, and omitted from device configuration/activation
manifests.
* Declarations that fail resolution still factor into declaration token
computation to keep token behavior consistent.

* **Tests**
* Updated tests to reflect per-device resolution failures and adjusted
validation flow.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
2026-04-20 14:05:21 -04:00
..
async
Removed duplicate FlippingPoliciesForHost DB calls (#42845)
2026-04-06 10:11:07 -05:00
calendar
Migrated logging and google calendar files to use slog (#40541)
2026-02-26 12:48:54 -06:00
conditional_access_microsoft_proxy
Fixed client-side errors being incorrectly reported as server errors in OTEL telemetry (#40051)
2026-02-19 16:06:00 -06:00
contract
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
externalsvc
…
integrationtest
Converted old activity module into function. Cleaned up activity types. (#40752)
2026-03-03 01:01:42 -06:00
middleware
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
mock
…
osquery_utils
Add Windows Program Files scan for software without registry entries (#42992)
2026-04-11 13:42:50 -06:00
redis_key_value
use redis to block double profile work for apple devices setting up (#42421)
2026-03-30 16:37:18 -05:00
redis_lock
…
redis_policy_set
…
schedule
Fix flaky test: TestTriggerPollPicksUpQueuedRecord (#41155)
2026-03-10 12:55:42 -05:00
testdata
Bugfix: properly enqueue compatible setup experience items for arch/omarchy linux (#41778)
2026-03-17 15:04:33 -04:00
activities_test.go
Move PostJSONWithTimeout to platform/http package and activity cleanup (#40561)
2026-02-26 17:39:10 -06:00
activities.go
Converted old activity module into function. Cleaned up activity types. (#40752)
2026-03-03 01:01:42 -06:00
api_endpoints.go
Implement GET /api/v1/fleet/rest_api (#42883)
2026-04-10 11:12:38 -04:00
appconfig_test.go
Add aliases for more multi-platform setup experience fields (#41599)
2026-03-13 15:17:05 -05:00
appconfig.go
Fixed stale MDM profiles after MDM toggle (#43719)
2026-04-20 09:23:55 -05:00
apple_mdm_cmd_results_test.go
Backend: Auto rotate recovery lock passwords (#42084)
2026-03-26 12:12:41 -06:00
apple_mdm_cmd_results.go
Clean up setup experience cancellation behavior (#43437)
2026-04-14 09:39:26 -05:00
apple_mdm_ddm_test.go
DDMV: Support Fleet variables in DDM (#43222)
2026-04-20 09:14:52 -04:00
apple_mdm_test.go
DDMV: Support Fleet variables in DDM (#43222)
2026-04-20 09:14:52 -04:00
apple_mdm.go
DDMV: fix unresolved Fleet variable in DDM profile behavior (#43556)
2026-04-20 14:05:21 -04:00
build_tags_test.go
…
calendar.go
…
campaigns_test.go
Follow-up changes to observer live query bypass (#41146)
2026-03-11 13:42:33 -03:00
campaigns.go
Follow-up changes to observer live query bypass (#41146)
2026-03-11 13:42:33 -03:00
carves_test.go
Authenticate carve block endpoint before parsing the "data" field (#39353)
2026-02-05 15:55:03 -03:00
carves.go
Authenticate carve block endpoint before parsing the "data" field (#39353)
2026-02-05 15:55:03 -03:00
certificate_authorities_test.go
…
certificate_authorities.go
Fixed GitOps failing to delete a certificate authority (#41693)
2026-03-16 15:51:28 -05:00
certificate_templates_test.go
41542 android cert resend backend (#42099)
2026-03-23 17:01:52 -04:00
certificate_templates.go
…
certificates.go
Added automatic Android cert retry (#42734)
2026-04-01 13:49:24 -05:00
client_android_certificates.go
Update fleetctl client urls and params (#41463)
2026-03-13 08:38:55 -05:00
client_appconfig.go
Update fleetctl client urls and params (#41463)
2026-03-13 08:38:55 -05:00
client_carves.go
…
client_certificate_authorities.go
Fixed GitOps failing to delete a certificate authority (#41693)
2026-03-16 15:51:28 -05:00
client_compat.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
client_debug.go
…
client_hosts.go
…
client_labels.go
Move label request/response types to server/fleet package (#43140)
2026-04-08 11:07:06 -03:00
client_live_query_test.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
client_live_query.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
client_mdm_test.go
…
client_mdm.go
Rename Apple Business Manager in UI (#42584)
2026-04-08 11:14:19 -06:00
client_packs.go
…
client_policies.go
Move policy request and response types to server/fleet/ package (#43068)
2026-04-07 11:04:08 -03:00
client_profiles.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
client_queries.go
Move query and scheduled query request and response types to server/fleet/ (#43236)
2026-04-13 16:02:23 -03:00
client_scripts.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
client_secret_variables.go
…
client_sessions.go
…
client_setup.go
…
client_software.go
Use list FMA endpoint in generate-gitops to match FMAs by ID (#42483)
2026-03-26 15:52:28 -04:00
client_targets.go
Activate deprecation warnings (#41449)
2026-04-06 09:59:32 -05:00
client_teams.go
Update fleetctl client urls and params (#41463)
2026-03-13 08:38:55 -05:00
client_test.go
Fix GitOps policy-software resolution to fall back to hash when URL lookup fails (#42816)
2026-04-02 17:22:14 -04:00
client_trigger.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
client_users.go
Allow the creation of API-only users (#43440)
2026-04-16 11:11:39 -04:00
client.go
Add cache option for software packages to skip re-downloading unchanged content (#42216)
2026-04-14 13:01:33 -05:00
conditional_access_idp_test.go
…
conditional_access_idp.go
Only allow FLEET_DEV_* env vars when --dev is passed, allow overriding configs one at a time in dev (#38652)
2026-01-27 14:32:56 -06:00
conditional_access_microsoft.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
cron_schedules_test.go
…
cron_schedules.go
Trigger vuln processing when it runs on a separate server (#39612)
2026-02-17 09:18:03 -06:00
debug_handler_test.go
…
debug_handler.go
Migrate HTTP request logging from go-kit/log to slog (#39729)
2026-02-14 13:04:41 -06:00
devices_endpoint_test.go
Add conditional access already bypassed check (#39037)
2026-02-02 10:35:55 -05:00
devices_test.go
Update backend error messages (#40364)
2026-02-25 13:54:45 -06:00
devices_url_auth_test.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
devices.go
Fixed 500 and 402 on My Device page. (#41748)
2026-03-16 16:09:43 -05:00
endpoint_campaigns.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
endpoint_middleware_test.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
endpoint_middleware.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
endpoint_setup.go
Use fleetctl new templates for new instances (#42768)
2026-04-03 09:58:03 -05:00
endpoint_utils_test.go
Add CSP to fleet(currently disabled - needs frontend work) (#41395)
2026-03-12 18:06:54 -04:00
endpoint_utils.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
frontend_test.go
Add CSP to fleet(currently disabled - needs frontend work) (#41395)
2026-03-12 18:06:54 -04:00
frontend.go
Add CSP to fleet(currently disabled - needs frontend work) (#41395)
2026-03-12 18:06:54 -04:00
full_test.go
…
global_policies_test.go
Make dynamic default policy type for ApplyPolicySpecs (#43197)
2026-04-08 09:56:38 -04:00
global_policies.go
Make dynamic default policy type for ApplyPolicySpecs (#43197)
2026-04-08 09:56:38 -04:00
global_schedule_test.go
Move NewActivity to activity bounded context (#39521)
2026-02-25 14:11:03 -06:00
global_schedule.go
Add renameto tags to prepare for deprecating team and query API params (#39847)
2026-02-17 10:00:59 -06:00
handler_deprecated_paths.go
Deprecate URLs with "team" and "query" terminology (#40520)
2026-02-25 22:20:35 -06:00
handler_test.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
handler.go
Allow the creation of API-only users (#43440)
2026-04-16 11:11:39 -04:00
hosts_reports_test.go
Performance improvements for Host Reports (41540)
2026-03-26 07:04:18 -04:00
hosts_test.go
Implement clear passcode backend (#43072)
2026-04-07 15:23:59 -05:00
hosts.go
Move label request/response types to server/fleet package (#43140)
2026-04-08 11:07:06 -03:00
http_auth_test.go
Move NewActivity to activity bounded context (#39521)
2026-02-25 14:11:03 -06:00
integration_android_certificate_templates_test.go
Reset verified certificates to pending during Android host re-enrollment (#43443)
2026-04-15 07:36:45 -05:00
integration_android_software_test.go
Rename Apple Business Manager in UI (#42584)
2026-04-08 11:14:19 -06:00
integration_certificate_authorities_test.go
use redis to block double profile work for apple devices setting up (#42421)
2026-03-30 16:37:18 -05:00
integration_core_test.go
DDMV: Support Fleet variables in DDM (#43222)
2026-04-20 09:14:52 -04:00
integration_desktop_test.go
Request body limits (#39080)
2026-02-05 10:29:53 -05:00
integration_ds_only_test.go
…
integration_enterprise_test.go
Allow the creation of API-only users (#43440)
2026-04-16 11:11:39 -04:00
integration_enterprise_vulns_test.go
Remove duplicate RHEL kernel in os_version (#39746)
2026-02-12 09:13:24 -07:00
integration_install_test.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
integration_live_queries_test.go
Renamed activity tables and moved host activities cleanup to activity bounded context. (#41194)
2026-03-08 21:54:06 -05:00
integration_logger_test.go
Move query and scheduled query request and response types to server/fleet/ (#43236)
2026-04-13 16:02:23 -03:00
integration_mdm_commands_test.go
make clear passcode activity global as well (#43483)
2026-04-13 13:30:41 -06:00
integration_mdm_ddm_test.go
DDMV: fix unresolved Fleet variable in DDM profile behavior (#43556)
2026-04-20 14:05:21 -04:00
integration_mdm_dep_test.go
ACME MDM -> main (#42926)
2026-04-02 15:56:31 -05:00
integration_mdm_lifecycle_test.go
Added EUA to the Fleet MSI installer (#43295)
2026-04-13 12:17:23 -05:00
integration_mdm_profiles_test.go
use redis to block double profile work for apple devices setting up (#42421)
2026-03-30 16:37:18 -05:00
integration_mdm_release_worker_test.go
use redis to block double profile work for apple devices setting up (#42421)
2026-03-30 16:37:18 -05:00
integration_mdm_setup_experience_test.go
Clean up setup experience cancellation behavior (#43437)
2026-04-14 09:39:26 -05:00
integration_mdm_test.go
Clean up setup experience cancellation behavior (#43437)
2026-04-14 09:39:26 -05:00
integration_smtp_test.go
Final slog migration PR: test infrastructure + tools + remaining standalone files (#40727)
2026-02-28 05:52:21 -06:00
integration_software_titles_test.go
Move label request/response types to server/fleet package (#43140)
2026-04-08 11:07:06 -03:00
integration_sso_test.go
Fix TOCTOU race in last global admin protection (#42172)
2026-04-01 15:00:08 -03:00
integration_vpp_install_test.go
Clean up setup experience cancellation behavior (#43437)
2026-04-14 09:39:26 -05:00
invites_test.go
…
invites.go
…
jitter_test.go
…
jitter.go
…
labels_test.go
Make orbit and Fleet Desktop not depend on server/service/ packages (#42231)
2026-03-26 10:59:42 -03:00
labels_util.go
…
labels.go
Move label request/response types to server/fleet package (#43140)
2026-04-08 11:07:06 -03:00
linux_mdm_test.go
…
linux_mdm.go
…
live_queries.go
Migrated to slog method signatures in service files (#40468)
2026-02-26 07:16:44 -06:00
mail_test.go
Run multiple independent Fleet dev servers in parallel (#41865)
2026-03-18 13:58:58 -05:00
maintained_apps_test.go
Fix addFleetMaintainedAppEndpoint to accept fleet_id param (#41805)
2026-03-17 09:59:03 -05:00
maintained_apps.go
merge main
2026-03-18 14:49:08 -04:00
mdm_profiles_test.go
…
mdm_profiles.go
…
mdm_scep.go
Final slog migration PR: test infrastructure + tools + remaining standalone files (#40727)
2026-02-28 05:52:21 -06:00
mdm_test.go
Fixed stale MDM profiles after MDM toggle (#43719)
2026-04-20 09:23:55 -05:00
mdm.go
Fixed stale MDM profiles after MDM toggle (#43719)
2026-04-20 09:23:55 -05:00
mem_failing_policies_set_test.go
…
metrics_appconfig.go
…
metrics_change_email.go
…
metrics_invites.go
…
metrics_labels.go
…
metrics_sessions.go
extend the expiration date for the auth token cookie (#41261)
2026-03-10 17:15:09 +00:00
metrics_users.go
…
metrics.go
…
microsoft_mdm_test.go
Insert hmwp and windows command entries at once (#42566)
2026-03-27 22:17:34 -04:00
microsoft_mdm.go
Added EUA to the Fleet MSI installer (#43295)
2026-04-13 12:17:23 -05:00
orbit_eua_test.go
Added EUA to the Fleet MSI installer (#43295)
2026-04-13 12:17:23 -05:00
orbit_test.go
Removed duplicate FlippingPoliciesForHost DB calls (#42845)
2026-04-06 10:11:07 -05:00
orbit.go
Clean up setup experience cancellation behavior (#43437)
2026-04-14 09:39:26 -05:00
osquery_test.go
incorporate display name into setup experience ordering and enforce 1 at a time execution (#42393)
2026-04-06 11:51:39 -05:00
osquery.go
incorporate display name into setup experience ordering and enforce 1 at a time execution (#42393)
2026-04-06 11:51:39 -05:00
packs_test.go
Move NewActivity to activity bounded context (#39521)
2026-02-25 14:11:03 -06:00
packs.go
Add renameto tags to prepare for deprecating team and query API params (#39847)
2026-02-17 10:00:59 -06:00
queries_test.go
Added license checks when targeting queries by label (33045) (#41255)
2026-03-09 16:54:53 -04:00
queries.go
Move query and scheduled query request and response types to server/fleet/ (#43236)
2026-04-13 16:02:23 -03:00
scheduled_queries_test.go
…
scheduled_queries.go
Move query and scheduled query request and response types to server/fleet/ (#43236)
2026-04-13 16:02:23 -03:00
scim.go
…
scripts_encoding_test.go
…
scripts_encoding.go
…
scripts_test.go
Move NewActivity to activity bounded context (#39521)
2026-02-25 14:11:03 -06:00
scripts.go
Update backend error messages (#40364)
2026-02-25 13:54:45 -06:00
secret_variables_test.go
…
secret_variables.go
…
service_appconfig_test.go
Move NewActivity to activity bounded context (#39521)
2026-02-25 14:11:03 -06:00
service_appconfig.go
Use OSV for ubuntu vulnerability scanning (#42063)
2026-04-03 15:59:32 -05:00
service_campaign_test.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
service_campaigns.go
slog migration: service layer + subsystem libraries (#40661)
2026-02-26 17:40:46 -06:00
service_errors.go
Fixed client-side errors being incorrectly reported as server errors in OTEL telemetry (#40051)
2026-02-19 16:06:00 -06:00
service_users.go
…
service.go
Improved performance of distributed read endpoint (#42810)
2026-04-03 07:13:56 -05:00
sessions_test.go
Enable JIT provisioning for Technician role (#41286)
2026-03-10 10:15:01 -03:00
sessions.go
add expiration to auth token via sso login (#42094)
2026-03-24 12:17:21 +00:00
setup_experience_test.go
Clean up setup experience cancellation behavior (#43437)
2026-04-14 09:39:26 -05:00
setup_experience.go
Clean up setup experience cancellation behavior (#43437)
2026-04-14 09:39:26 -05:00
software_installers_test.go
Add cache option for software packages to skip re-downloading unchanged content (#42216)
2026-04-14 13:01:33 -05:00
software_installers.go
Return bad request instead of 413 when installer size is too big (#42676)
2026-03-30 15:16:35 -03:00
software_test.go
…
software_title_icons_test.go
Backend: Support labels_include_all for installers/apps (#41324)
2026-03-18 13:27:53 -04:00
software_title_icons.go
Update fleetctl client urls and params (#41463)
2026-03-13 08:38:55 -05:00
software_titles_test.go
…
software_titles.go
Pin FMA major version in GitOps (#43053)
2026-04-06 12:36:47 -04:00
software.go
Return light software metadata when listing hosts filtered by software present only on a different team (#42519)
2026-03-30 21:33:21 -07:00
status.go
…
targets_test.go
…
targets.go
Follow-up changes to observer live query bypass (#41146)
2026-03-11 13:42:33 -03:00
team_policies_test.go
Feat/31914 patch policy (#41518)
2026-03-13 16:47:09 -04:00
team_policies.go
Move policy request and response types to server/fleet/ package (#43068)
2026-04-07 11:04:08 -03:00
team_schedule_test.go
Move NewActivity to activity bounded context (#39521)
2026-02-25 14:11:03 -06:00
team_schedule.go
Move query and scheduled query request and response types to server/fleet/ (#43236)
2026-04-13 16:02:23 -03:00
teams_test.go
Move NewActivity to activity bounded context (#39521)
2026-02-25 14:11:03 -06:00
teams.go
Add renameto tags to prepare for deprecating team and query API params (#39847)
2026-02-17 10:00:59 -06:00
testing_client.go
Implement clear passcode backend (#43072)
2026-04-07 15:23:59 -05:00
testing_utils.go
Implement GET /api/v1/fleet/rest_api (#42883)
2026-04-10 11:12:38 -04:00
translator.go
…
transport_error.go
Improved OpenTelemetry error handling (#38757)
2026-01-26 17:07:32 -06:00
transport_setup.go
…
transport_test.go
SHAA: hosts summary and hosts filtering (#42149)
2026-03-20 16:26:14 -04:00
transport.go
SHAA: hosts summary and hosts filtering (#42149)
2026-03-20 16:26:14 -04:00
trigger.go
…
user_roles.go
…
users_test.go
Allow the creation of API-only users (#43440)
2026-04-16 11:11:39 -04:00
users.go
Allow the creation of API-only users (#43440)
2026-04-16 11:11:39 -04:00
validation_setup.go
…
vpp_test.go
Immediately reject duplicate Android web-clips (#42704)
2026-03-31 09:34:12 -04:00
vpp.go
merge main
2026-03-19 13:02:42 -04:00
vulnerabilities_test.go
…
vulnerabilities.go
Update backend error messages (#40364)
2026-02-25 13:54:45 -06:00
windows_mdm_profiles_test.go
Added support for NDES CA for Windows hosts (#41356)
2026-03-12 15:36:44 -05:00
windows_mdm_profiles.go
Fixed a server panic when uploading an MDM profile to a team on a free license (#42834)
2026-04-02 13:18:15 -05:00