George Karrandtest
1dcad647f9
**Related issue:** Resolves #47581 # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## What / why In dark mode, the status-filter dropdown's selected-value icon on the Hosts page rendered near-black and was barely visible at rest (only appearing on hover/open). The leading filter icon is rendered two different ways, and both were broken in dark mode: 1. **SVG icon** (`iconName="filter-alt"` — PoliciesFilter, HostsFilterBlock) renders `.dropdown__custom-value .dropdown__icon`. The base `Dropdown` only applied a theme-aware `fill` on hover/open; at rest it fell back to a near-black default. Added a rest-state rule (`fill: $ui-fleet-black-75`) so the icon is theme-aware at rest. Light mode resolves to the same color as before (no visual change); dark mode now uses the light shade. 2. **Black PNG** (`icon-filter-v2-black-16x16@2x.png` via `::before` — DiskEncryptionStatusFilter, BootstrapPackageStatusFilter) is a hardcoded black glyph that never adapts to the theme. Added `filter: invert(1)` scoped to `body.dark-mode` so it becomes a light glyph in dark mode only. Frontend/SCSS-only change. ## Testing - [ ] Added/updated automated tests - [x] QA'd all new/changed functionality manually Verify in **dark mode** on the Hosts page: - Controls → OS settings → Disk encryption → click a status (lands on `/hosts/manage?...&os_settings_disk_encryption=enforcing`) — the "Enforcing" filter icon is clearly visible at rest. - Bootstrap package status filter and policy pass/fail filter icons are also visible at rest. - Light mode appearance is unchanged. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Bug Fixes** - Improved visibility of selected status-filter icons in dark mode. - Updated disk encryption, bootstrap package, and policy status filters on the Hosts page with clearer, theme-aware icons. - Improved contrast and consistency for dropdown icons across dark-mode views, preventing selected icons from appearing nearly black or difficult to see. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: test <test@test.com>
2 lines
202 B
Plaintext
2 lines
202 B
Plaintext
- Fixed the status-filter dropdown's selected-value icon (e.g. the disk encryption, bootstrap package, and policy status filters on the Hosts page) rendering near-black and barely visible in dark mode.
|