Merge pull request #83 from macadmins/openssl-fix

Openssl fix

build_python_framework_pkgs.zsh

@@ -139,6 +139,15 @@ build_framework() {
         "$TOOLSDIR/$TYPE/payload${FRAMEWORKDIR}/Python3.framework"
 }
 
+install_sitecustomize() {
+    # Drop a sitecustomize.py that points OpenSSL at certifi's CA bundle via
+    # SSL_CERT_FILE at interpreter startup. Works around macadmins/python#38:
+    # python.org's framework has the OpenSSL CA path compiled in to
+    # /Library/Frameworks/... which doesn't match our relocated install.
+    local site_packages="$TOOLSDIR/$TYPE/payload${FRAMEWORKDIR}/Python3.framework/Versions/${PYTHON_BIN_VERSION}/lib/python${PYTHON_BIN_VERSION}/site-packages"
+    /bin/cp "${TOOLSDIR}/managed_python_sitecustomize.py" "$site_packages/sitecustomize.py"
+}
+
 codesign_framework() {
     local identity="${APPLICATION_ID:--}"   # `-` means ad-hoc
     local framework_root="$TOOLSDIR/$TYPE/payload${FRAMEWORKDIR}/Python3.framework"
@@ -274,6 +283,7 @@ download_tool munki-pkg "$MP_SHA" \
     "https://github.com/munki/munki-pkg/archive/${MP_SHA}.zip" \
     "$MP_ZIP" "$MP_BINDIR"
 build_framework
+install_sitecustomize
 codesign_framework
 build_pkg
 notarize_and_staple

managed_python_sitecustomize.py

@@ -0,0 +1,48 @@
+"""
+Site-customization for the macadmins Python framework.
+
+Why this file exists:
+    The python.org Python.framework is built with OpenSSL's default CA-bundle
+    path hardcoded to /Library/Frameworks/Python.framework/Versions/<X.Y>/etc/
+    openssl/cert.pem. Our framework installs under /Library/ManagedFrameworks/
+    Python/Python3.framework/..., so that hardcoded path doesn't exist on
+    target machines. Stdlib SSL (urllib.request, http.client.HTTPSConnection,
+    ssl.SSLContext with default verify paths, etc.) then fails to find a CA
+    bundle and certificate validation errors out.
+
+    A regular python.org install ships /Applications/Python 3.X/Install
+    Certificates.command that fixes this by symlinking the expected path to
+    certifi's bundled cacert.pem. We can't do the equivalent because the
+    expected path is outside our framework — touching it would conflict with
+    a python.org install if the user has one.
+
+What it does:
+    Sets SSL_CERT_FILE to certifi's bundled cert path during interpreter
+    startup. OpenSSL reads SSL_CERT_FILE ahead of its compiled-in path, so
+    stdlib SSL operations get a working CA bundle.
+
+    Falls back to certifi only when SSL_CERT_FILE is unset OR points at a
+    path that doesn't exist on disk. A valid user override (e.g. a corporate
+    CA bundle at `export SSL_CERT_FILE=/opt/corp/ca.pem`) is preserved;
+    a stale or typo'd path gets corrected to certifi.
+
+References:
+    macadmins/python#38
+    gregneagle/relocatable-python#13
+"""
+import os
+import os.path
+
+
+def _ssl_cert_file_is_valid():
+    path = os.environ.get("SSL_CERT_FILE")
+    return bool(path) and os.path.isfile(path)
+
+
+if not _ssl_cert_file_is_valid():
+    try:
+        import certifi
+    except ImportError:
+        pass
+    else:
+        os.environ["SSL_CERT_FILE"] = certifi.where()