udate review comments
This commit is contained in:
+3
-3
@@ -206,10 +206,10 @@ public class BraveStatsBottomSheetDialogFragment extends BottomSheetDialogFragme
|
||||
@Override
|
||||
public void onResume() {
|
||||
super.onResume();
|
||||
if (!hasPermission(getActivity(), PermissionConstants.NOTIFICATION_PERMISSION)) {
|
||||
statsNotificationView.setVisibility(View.VISIBLE);
|
||||
} else {
|
||||
if (hasPermission(getActivity(), PermissionConstants.NOTIFICATION_PERMISSION)) {
|
||||
statsNotificationView.setVisibility(View.GONE);
|
||||
} else {
|
||||
statsNotificationView.setVisibility(View.VISIBLE);
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -2,7 +2,6 @@
|
||||
<shape xmlns:android="http://schemas.android.com/apk/res/android">
|
||||
|
||||
<solid android:color="@color/brave_stats_bg_color" />
|
||||
|
||||
|
||||
<corners
|
||||
android:topLeftRadius="24dp"
|
||||
|
||||
@@ -1,14 +1,15 @@
|
||||
<?xml version="1.0" encoding="utf-8"?><!--* Copyright (c) 2022 The Brave Authors. All rights reserved.
|
||||
<?xml version="1.0" encoding="utf-8"?>
|
||||
<!--* Copyright (c) 2022 The Brave Authors. All rights reserved.
|
||||
* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at http://mozilla.org/MPL/2.0/. -->
|
||||
|
||||
<androidx.constraintlayout.widget.ConstraintLayout xmlns:android="http://schemas.android.com/apk/res/android"
|
||||
xmlns:app="http://schemas.android.com/apk/res-auto"
|
||||
xmlns:tools="http://schemas.android.com/tools"
|
||||
android:layout_width="match_parent"
|
||||
android:layout_height="152dp"
|
||||
android:layout_marginStart="20dp"
|
||||
android:layout_marginEnd="20dp"
|
||||
android:layout_height="wrap_content"
|
||||
android:layout_marginHorizontal="20dp"
|
||||
android:layout_marginBottom="32dp"
|
||||
android:background="@drawable/ic_stats_notification_background">
|
||||
|
||||
@@ -23,7 +24,6 @@
|
||||
android:src="@drawable/ic_baseline_close_24"
|
||||
android:contentDescription="@null" />
|
||||
|
||||
|
||||
<ImageView
|
||||
android:id="@+id/imageView"
|
||||
android:layout_width="wrap_content"
|
||||
@@ -44,7 +44,7 @@
|
||||
android:fontFamily="sans-serif-medium"
|
||||
android:text="@string/stats_notification_privacy_updates_description"
|
||||
android:textColor="@android:color/white"
|
||||
android:textSize="17sp"
|
||||
android:textSize="16sp"
|
||||
app:layout_constraintEnd_toEndOf="parent"
|
||||
app:layout_constraintStart_toEndOf="@+id/imageView"
|
||||
app:layout_constraintTop_toTopOf="@+id/imageView" />
|
||||
@@ -53,12 +53,13 @@
|
||||
android:id="@+id/notification_on_button"
|
||||
android:layout_width="0dp"
|
||||
android:layout_height="44dp"
|
||||
android:layout_marginStart="24dp"
|
||||
android:layout_marginHorizontal="24dp"
|
||||
android:layout_marginTop="16dp"
|
||||
android:layout_marginEnd="24dp"
|
||||
android:layout_marginBottom="24dp"
|
||||
android:background="@drawable/stats_notification_on_button_bg"
|
||||
app:layout_constraintEnd_toEndOf="parent"
|
||||
app:layout_constraintStart_toStartOf="parent"
|
||||
app:layout_constraintBottom_toBottomOf="parent"
|
||||
app:layout_constraintTop_toBottomOf="@+id/imageView">
|
||||
|
||||
<TextView
|
||||
@@ -72,4 +73,4 @@
|
||||
android:textColor="@android:color/white" />
|
||||
</FrameLayout>
|
||||
|
||||
</androidx.constraintlayout.widget.ConstraintLayout>
|
||||
</androidx.constraintlayout.widget.ConstraintLayout>
|
||||
|
||||
Reference in New Issue
Block a user