Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[Android] New signature for AutocompleteMediator#loadUrlForOmniboxMatch

Browse Source 
Chromium change:
https://source.chromium.org/chromium/chromium/src/+/5799acb4fd93d6b94dc5834f1887af52503b49d2

Remove unused `skipCheck` parameter from updateDestinationUrl call.

  🫧
🫧🧽🧼🫧
    🫧

Bug: 1490333
This commit is contained in:
Artem Samoilenko
2023-11-27 11:31:27 -05:00
committed by mkarolin
parent b140285fe2
commit 10f1e48f70
2 changed files with 37 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/omnibox/suggestions/BraveAutocompleteMediatorBase.java
+18 -5
View File
@@ -18,8 +18,11 @@ import org.chromium.misc_metrics.mojom.MiscAndroidMetrics;
import org.chromium.url.GURL;
class BraveAutocompleteMediatorBase {
void loadUrlForOmniboxMatch(int matchIndex, @NonNull AutocompleteMatch suggestion,
@NonNull GURL url, long inputStart, boolean inVisibleSuggestionList,
void loadUrlForOmniboxMatch(
int matchIndex,
@NonNull AutocompleteMatch suggestion,
@NonNull GURL url,
long inputStart,
boolean openInNewTab) {
Context context =
(Context)
@@ -44,9 +47,19 @@ class BraveAutocompleteMediatorBase {
}
}
BraveReflectionUtil.InvokeMethod(AutocompleteMediator.class, this, "loadUrlForOmniboxMatch",
int.class, matchIndex, AutocompleteMatch.class, suggestion, GURL.class, url,
long.class, inputStart, boolean.class, inVisibleSuggestionList, boolean.class,
BraveReflectionUtil.InvokeMethod(
AutocompleteMediator.class,
this,
"loadUrlForOmniboxMatch",
int.class,
matchIndex,
AutocompleteMatch.class,
suggestion,
GURL.class,
url,
long.class,
inputStart,
boolean.class,
openInNewTab);
}
}
android/javatests/org/chromium/chrome/browser/BytecodeTest.java
+19 -8
View File
@@ -562,14 +562,25 @@ public class BytecodeTest {
true,
boolean.class,
Intent.class));
Assert.assertTrue(methodExists(
"org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator",
"createViewProvider", true, ViewProvider.class, Context.class,
MVCListAdapter.ModelList.class));
Assert.assertTrue(methodExists(
"org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator",
"loadUrlForOmniboxMatch", true, void.class, int.class, AutocompleteMatch.class,
GURL.class, long.class, boolean.class, boolean.class));
Assert.assertTrue(
methodExists(
"org/chromium/chrome/browser/omnibox/suggestions/AutocompleteCoordinator",
"createViewProvider",
true,
ViewProvider.class,
Context.class,
MVCListAdapter.ModelList.class));
Assert.assertTrue(
methodExists(
"org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator",
"loadUrlForOmniboxMatch",
true,
void.class,
int.class,
AutocompleteMatch.class,
GURL.class,
long.class,
boolean.class));
// Check for method type declaration changes here
Assert.assertTrue(