Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr149][Android] Changes for TabbedAppMenuPropertiesDelegate c-tor

Browse Source 
Chromium changes:
https://chromium.googlesource.com/chromium/src/+/bafb125de13ea5ef6b6bf0a39398f836c834efc2

commit bafb125de13ea5ef6b6bf0a39398f836c834efc2
Author: Yanling <yanlinghu@google.com>
Date:   Mon Apr 20 11:56:14 2026 -0700

    [Feed] Part2 of remove web feed feature: Delete Web Feed small UI components and associated IPHs

    this CL cleans up various small UI components, including removing
    related In-Product Help (IPH) features and preference keys.

    1. Removed WebFeedMainMenuItem, WebFeedFollowIntroController,
    WebFeedFollowIntroView,WebFeedRecommendationFollowAcceleratorController,
    ClickableTextBubble and WebFeedSnackbarController.

    2. Removed IPH Features: Deletion reference: https://crrev.com/c/7067894
    - IPH_WebFeedFollow
      * Added in: https://crrev.com/c/2817518
    - IPH_WebFeedAwareness
      * Added in: https://crrev.com/c/3632953
    - IPH_WebFeedPostFollowDialogWithUIUpdate
      * Added in: https://crrev.com/c/4867332
    - IPH_WebFeedPostFollowDialog
      * Added in: https://crrev.com/c/4867332

    3. Removed Chrome Preference Keys:
    - WEB_FEED_INTRO_LAST_SHOWN_TIME_MS
    - WEB_FEED_INTRO_WEB_FEED_ID_SHOWN_TIME_MS_PREFIX
    - WEB_FEED_INTRO_WEB_FEED_ID_SHOWN_COUNT_PREFIX
      * Added in: https://crrev.com/c/2817518 and https://crrev.com/c/3692349
      * Deletion reference: https://crrev.com/c/7561272
      * Followed deprecation instructions from ChromePreferenceKeys.java: https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/preferences/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceKeys.java;l=36-39;drc=30c17203494464b1b107c90273c1358db359e04a

    Cq-Include-Trybots: luci.chrome.try:android-internal-binary-size;luci.chrome.try:android-internal-rel;luci.chrome.try:android-internal-dbg
    Bug: 407797637
    Change-Id: I0e3669255394f6121f5d5b4352171767d0f43fa3
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7757080
    Reviewed-by: Theresa Wellington <twellington@chromium.org>
    Reviewed-by: Xi Han <hanxi@chromium.org>
    Commit-Queue: Yanling Hu <yanlinghu@google.com>
    Cr-Commit-Position: refs/heads/main@{#1617671}
This commit is contained in:
Artem Samoilenko
2026-05-22 16:25:07 -04:00
committed by Max Karolinskiy
parent ed7896dca4
commit 166a0147a5
3 changed files with 0 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegate.java
-3
View File
@@ -39,7 +39,6 @@ import org.chromium.chrome.browser.bookmarks.BookmarkModel;
import org.chromium.chrome.browser.brave_leo.BraveLeoPrefUtils;
import org.chromium.chrome.browser.brave_news.BraveNewsPolicy;
import org.chromium.chrome.browser.crypto_wallet.BraveWalletPolicy;
import org.chromium.chrome.browser.feed.webfeed.WebFeedSnackbarController;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.homepage.HomepageManager;
import org.chromium.chrome.browser.hub.HubManager;
@@ -235,7 +234,6 @@ public class BraveTabbedAppMenuPropertiesDelegate extends TabbedAppMenuPropertie
AppMenuDelegate appMenuDelegate,
OneshotSupplier<LayoutStateProvider> layoutStateProvider,
NullableObservableSupplier<BookmarkModel> bookmarkModelSupplier,
WebFeedSnackbarController.FeedLauncher feedLauncher,
ModalDialogManager modalDialogManager,
SnackbarManager snackbarManager,
@NonNull
@@ -255,7 +253,6 @@ public class BraveTabbedAppMenuPropertiesDelegate extends TabbedAppMenuPropertie
appMenuDelegate,
layoutStateProvider,
bookmarkModelSupplier,
feedLauncher,
modalDialogManager,
snackbarManager,
incognitoReauthControllerOneshotSupplier,
android/javatests/org/chromium/chrome/browser/BytecodeTest.java
-2
View File
@@ -78,7 +78,6 @@ import org.chromium.chrome.browser.data_sharing.DataSharingTabManager;
import org.chromium.chrome.browser.feed.FeedActionDelegate;
import org.chromium.chrome.browser.feed.FeedSurfaceCoordinator;
import org.chromium.chrome.browser.feed.SnapScrollHelper;
import org.chromium.chrome.browser.feed.webfeed.WebFeedSnackbarController;
import org.chromium.chrome.browser.findinpage.FindToolbarManager;
import org.chromium.chrome.browser.fullscreen.BrowserControlsManager;
import org.chromium.chrome.browser.fullscreen.FullscreenManager;
@@ -1417,7 +1416,6 @@ public class BytecodeTest {
AppMenuDelegate.class,
OneshotSupplier.class,
NullableObservableSupplier.class,
WebFeedSnackbarController.FeedLauncher.class,
ModalDialogManager.class,
SnackbarManager.class,
OneshotSupplier.class,
android/junit/src/org/chromium/chrome/browser/tabbed_mode/BraveTabbedAppMenuPropertiesDelegateUnitTest.java
-3
View File
@@ -54,7 +54,6 @@ import org.chromium.chrome.browser.enterprise.util.ManagedBrowserUtilsJni;
import org.chromium.chrome.browser.feed.FeedFeatures;
import org.chromium.chrome.browser.feed.webfeed.WebFeedBridge;
import org.chromium.chrome.browser.feed.webfeed.WebFeedBridgeJni;
import org.chromium.chrome.browser.feed.webfeed.WebFeedSnackbarController;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.hub.HubManager;
import org.chromium.chrome.browser.hub.Pane;
@@ -150,7 +149,6 @@ public class BraveTabbedAppMenuPropertiesDelegateUnitTest {
@Mock private ManagedBrowserUtils.Natives mManagedBrowserUtilsJniMock;
@Mock private Profile mProfile;
@Mock private AppMenuDelegate mAppMenuDelegate;
@Mock private WebFeedSnackbarController.FeedLauncher mFeedLauncher;
@Mock private ModalDialogManager mDialogManager;
@Mock private SnackbarManager mSnackbarManager;
@Mock private OfflinePageUtils.Internal mOfflinePageUtils;
@@ -279,7 +277,6 @@ public class BraveTabbedAppMenuPropertiesDelegateUnitTest {
mAppMenuDelegate,
mLayoutStateProviderSupplier,
mBookmarkModelSupplier,
mFeedLauncher,
mDialogManager,
mSnackbarManager,
mIncognitoReauthControllerSupplier,