Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr149] chrome/browser/ui/test/ was componentized.

Browse Source 
We don't need to add test_browser_dialog_mac.h|mm into
brave_browser_tests directly because they are now built by
chrome/browser/ui/test:dialog target which is pulled into our executable
via

//brave/test:brave_browser_tests --[public]-->
//brave/test:browser_tests_runner --[public]-->
//brave/test:browser_test_support --[public]-->
//chrome/test:test_support --[public]-->
//chrome/test:test_support_ui --[public]-->
//chrome/browser/ui/test:dialog

Chromium change:
https://source.chromium.org/chromium/chromium/src/+/e0cd9afb25e911c62c8c096ef55816bd9e3b665e

commit e0cd9afb25e911c62c8c096ef55816bd9e3b665e
Author: Tiago Vignatti <tvignatti@igalia.com>
Date:   Thu Apr 9 07:28:31 2026 -0700

    Componentize chrome/browser/ui/test/

    This changes create chrome/browser/ui/test/BUILD.gn with dedicated
    targets for all test files in this directory, which were previously
    scattered across chrome/test/BUILD.gn and chrome/browser/ui/BUILD.gn.
    Some of the files were duplicated in multiple targets, and has now
    fixed.

    New targets:
    - :dialog — moved from //chrome/test:test_support and de-duplicated from
      browser_tests/interactive_ui_tests
    - :closed_waiter — moved from //chrome/test:test_support_ui
    - :test_support — de-duplicated and moved from browser_tests,
      interactive_ui_tests, and //chrome/browser/ui:test_support
    - :confirm_bubble — moved from //chrome/browser/ui:test_support
    - :browser_tests — browser test files
    - :interactive_ui_tests — interactive UI test files
    - :app_window — moved from //chrome/browser/ui:test_support

    Bug: 353332589
This commit is contained in:
Max Karolinskiy
2026-05-22 16:24:54 -04:00
parent e5dd72c66a
commit 1d51d34e40
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/BUILD.gn
+1 -5
View File
@@ -1143,11 +1143,7 @@ test("brave_browser_tests") {
]
if (is_mac) {
sources += [
"//brave/browser/brave_app_controller_mac_browsertest.mm",
"//chrome/browser/ui/test/test_browser_dialog_mac.h",
"//chrome/browser/ui/test/test_browser_dialog_mac.mm",
]
sources += [ "//brave/browser/brave_app_controller_mac_browsertest.mm" ]
}
if (is_win) {