Enable screen protection by default on desktop (currently enabled via Griffin) (#31885)

* Enable screen protection by default on desktop: this feature has been enabled via Griffin on
Desktop on all channels for a long time.

* Disable upstream tests that fail because of screen farbling

* Add more upstream test exclusions

* Reorder test disablements

chromium_src/third_party/blink/common/features.cc

@@ -54,7 +54,12 @@ BASE_FEATURE(kRestrictWebSocketsPool,
 
 // Enables protection against fingerprinting on screen dimensions.
 BASE_FEATURE(kBraveBlockScreenFingerprinting,
-             base::FEATURE_DISABLED_BY_DEFAULT);
+#if BUILDFLAG(IS_WIN) || BUILDFLAG(IS_MAC) || BUILDFLAG(IS_LINUX)
+             base::FEATURE_ENABLED_BY_DEFAULT
+#else
+             base::FEATURE_DISABLED_BY_DEFAULT
+#endif
+);
 
 // Enables protection against fingerprinting via high-resolution time stamps.
 BASE_FEATURE(kBraveRoundTimeStamps,

test/filters/browser_tests-linux.filter

@@ -59,6 +59,18 @@
 # This test fails because we disable PermissionElement origin trial.
 -All/PermissionElementOriginTrialBrowserTest.WithOriginTrialToken/BaseEnabled_BlinkDisabled
 
+# These tests fail because Brave enables screen farbling
+# (kBraveBlockScreenFingerprinting) by default on desktop, which modifies
+# screen dimension values returned to web content.
+-HeadlessModeProtocolBrowserTest_OzoneScreenSizeOverride.OzoneScreenSizeOverride
+-MultiscreenWindowManagementPermissionContextTest.IsExtendedCrossOriginAllow
+-MultiscreenWindowManagementPermissionContextTest.IsExtendedCrossOriginDeny
+-MultiscreenWindowManagementPermissionContextTest.IsExtendedSameOriginAllow
+-WindowManagementTest.OnCurrentScreenChangeEvent
+-WindowManagementTest.OnScreensChangeEvent
+-WindowManagementTest.ScreenDetailedOnChange
+-WindowManagementTest.ScreenDetailedOnHdrHeadroomChange
+
 # Tests below this point have not been diagnosed or had issues created yet.
 -AccessCodeCastHandlerBrowserTest.*
 -AdsPageLoadMetricsObserverBrowserTest.*
@@ -76,9 +88,6 @@
 -IndividualNetworkContextsPrefetchProxyBrowserTest.*
 -LayoutInstabilityTest.*
 -LocalNetworkAccessWithFeatureEnabledBrowserTest.SpecialSchemeChromeDistiller
--MultiscreenWindowPlacementPermissionContextTest.IsExtendedCrossOriginAllow
--MultiscreenWindowPlacementPermissionContextTest.IsExtendedCrossOriginDeny
--MultiscreenWindowPlacementPermissionContextTest.IsExtendedSameOriginAllow
 -NewTabUIBrowserTest.*
 -NewTabUIProcessPerTabTest.*
 -OzonePlatformTest.*

test/filters/browser_tests-windows.filter

@@ -186,3 +186,8 @@
 -WebAppTagWebAppTest.WebAppTaskCreatedForTab
 -WebSocketBrowserTestWithAllowFileAccessFromFiles.CheckFileOrigin
 -WebUIBubbleManagerBrowserTest.*
+
+# This test fails because Brave enables screen farbling
+# (kBraveBlockScreenFingerprinting) by default on desktop, which modifies
+# screen dimension values returned to web content.
+-ScreenDetailsTest.FullscreenSize

test/filters/browser_tests.filter

@@ -2685,6 +2685,29 @@
 # This test fails because dragging is not enabled on Brave's NTP.
 -MultiContentsViewBrowserTest.DragAndDropDisabledForChromePages
 
+# These tests fail because Brave enables screen farbling
+# (kBraveBlockScreenFingerprinting) by default on desktop, which modifies
+# screen dimension values returned to web content.
+-All/ReduceScreenSizeMetricsTest.*
+-HeadlessModeProtocolBrowserTest_AddScreenGetScreenDetails.AddScreenGetScreenDetails
+-HeadlessModeProtocolBrowserTest_DispatchMouseEventScreenCoordinates.DispatchMouseEventScreenCoordinates
+-HeadlessModeProtocolBrowserTest_LargeBrowserWindowSize.LargeBrowserWindowSize
+-HeadlessModeProtocolBrowserTest_MultipleScreenDetails.MultipleScreenDetails
+-HeadlessModeProtocolBrowserTest_RemoveScreenGetScreenDetails.RemoveScreenGetScreenDetails
+-HeadlessModeProtocolBrowserTest_ScreenDetailsMultipleScreens.ScreenDetailsMultipleScreens
+-HeadlessModeProtocolBrowserTest_ScreenDetailsMultipleScreensScaled.ScreenDetailsMultipleScreensScaled
+-HeadlessModeProtocolBrowserTest_ScreenDetailsRotationAngle.ScreenDetailsRotationAngle
+-HeadlessModeProtocolBrowserTest_ScreenDetailsWorkArea.ScreenDetailsWorkArea
+-HeadlessModeProtocolBrowserTest_ScreenDetailsWorkAreaScaled.ScreenDetailsWorkAreaScaled
+-HeadlessModeProtocolBrowserTest_WindowOuterSize.WindowOuterSize
+-HeadlessModeProtocolBrowserTest_WindowScreenAvail.WindowScreenAvail
+-HeadlessModeProtocolBrowserTest_WindowSizeSwitchHandling.WindowSizeSwitchHandling
+-HeadlessModeProtocolBrowserTest_WindowSizeSwitchLargerThanScreen.WindowSizeSwitchLargerThanScreen
+-HeadlessModeProtocolBrowserTest_MAYBE_RequestFullscreenOnSecondaryScreen.RequestFullscreenOnSecondaryScreen
+-HeadlessModeProtocolBrowserTest_MAYBE_StartFullscreenSwitch.StartFullscreenSwitch
+-HeadlessModeProtocolBrowserTest_MAYBE_StartFullscreenSwitchScaled.StartFullscreenSwitchScaled
+-ScreenDetailsTest.GetScreenDetailsBasic
+
 # Tests below this point have not been diagnosed or had issues created yet.
 -_/WebrtcLoggingPrivateApiStartEventLoggingTestPolicyEnabled.*
 -AdsPageLoadMetricsObserverBrowserTest.*