Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr145] BrowserRootView::tabstrip() removed

Browse Source 
The removal of this accessor was causing failures to an existing
override replacing calls for `ConvertPointToTarget`, which was making
use of this accessor. This change corrects the way to how this object is
retrieved in the override.

Chromium changes:
https://chromium.googlesource.com/chromium/src/+/98134b0b68889c778dde25b32e506d3a0bb634b8

commit 98134b0b68889c778dde25b32e506d3a0bb634b8
Author: dljames <dljames@chromium.org>
Date:   Mon Jan 5 12:10:46 2026 -0800

    [Vertical Tabs] Remove usage of TabStrip from BrowserRootView 2

    Removes usage of TabStrip from BrowserRootView entirely. The same
    behavior can be achieved by using TabStripRegionView the tabstrip
    agnostic interface. Making this change will utlimately remove the need
    for BrowserView::tab_strip() in the future allowing the code to work
    as-is when swapping between VerticalTabs and HorizontalTabs.

    To achieve this, TabStripRegionView now extends
    BrowserRootView::DropTarget. This allows BrowserRootView to forward drop
    events through the interface and into the TabStrip implementations. This
    allows tabs to appear as if they extend to the full height / width of
    their container even though the bounds are stricter.

    Change-Id: I1bf7948e632fe1122189eccd2dd89ea8f8679b79
    Bug: 465190040
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7304863
    Reviewed-by: David Pennington <dpenning@chromium.org>
    Commit-Queue: Darryl James <dljames@chromium.org>
    Reviewed-by: Steven Luong <stluong@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1564542}
This commit is contained in:
Claudio DeSouza
2026-01-29 13:40:59 -05:00
committed by Max Karolinskiy
parent 83a2a8db4e
commit 2b39fb25cf
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
chromium_src/chrome/browser/ui/views/frame/browser_root_view.cc
+2 -1
View File
@@ -11,7 +11,8 @@
#define ConvertPointToTarget(THIS, TARGET_GETTER, POINT) \
if (views::View* target_v = TARGET_GETTER; \
tabs::utils::ShouldShowBraveVerticalTabs(browser_view_->browser()) && \
(target_v == tabstrip() || !THIS->Contains(target_v))) { \
(target_v == browser_view_->tab_strip_view() || \
!THIS->Contains(target_v))) { \
ConvertPointToScreen(THIS, POINT); \
ConvertPointFromScreen(target_v, POINT); \
} else { \