Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[cr137] [Android] Fix Private 'new tab group' menu option

Browse Source 
Chromium change:
https://chromium.googlesource.com/chromium/src/+/39ca7116fe0ebd90b44a8fff3d2c12a819db8b1c

[Tab Group Entry Points] Fix Incognito 'new tab group' menu option

- The incognito version of this functionality was disabled,
	and this CL should fix it
- Rename TabGroupCreationUiFlow to TabGroupCreationUiFlowDelegate

Bug: 413062615
This commit is contained in:
Artem Samoilenko
2025-05-13 15:53:19 -04:00
committed by Max Karolinskiy
parent c2231c573e
commit 3168e19950
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/BraveIncognitoTabSwitcherPane.java
+2 -2
View File
@@ -37,7 +37,7 @@ public class BraveIncognitoTabSwitcherPane extends IncognitoTabSwitcherPane {
@NonNull UserEducationHelper userEducationHelper,
@NonNull ObservableSupplier<EdgeToEdgeController> edgeToEdgeSupplier,
@NonNull ObservableSupplier<CompositorViewHolder> compositorViewHolderSupplier,
@NonNull TabGroupCreationUiFlow tabGroupCreationUiFlow) {
@NonNull TabGroupCreationUiDelegate tabGroupCreationUiDelegate) {
super(
context,
factory,
@@ -48,7 +48,7 @@ public class BraveIncognitoTabSwitcherPane extends IncognitoTabSwitcherPane {
userEducationHelper,
edgeToEdgeSupplier,
compositorViewHolderSupplier,
tabGroupCreationUiFlow);
tabGroupCreationUiDelegate);
ResourceButtonData newReferenceButtonData =
new ResourceButtonData(
android/features/tab_ui/java/src/org/chromium/chrome/browser/tasks/tab_management/BraveTabSwitcherPaneBase.java
+2 -2
View File
@@ -29,7 +29,7 @@ public abstract class BraveTabSwitcherPaneBase extends TabSwitcherPaneBase {
@NonNull UserEducationHelper userEducationHelper,
@NonNull ObservableSupplier<EdgeToEdgeController> edgeToEdgeSupplier,
@NonNull ObservableSupplier<CompositorViewHolder> compositorViewHolderSupplier,
@NonNull TabGroupCreationUiFlow tabGroupCreationUiFlow) {
@NonNull TabGroupCreationUiDelegate tabGroupCreationUiDelegate) {
super(
context,
factory,
@@ -38,7 +38,7 @@ public abstract class BraveTabSwitcherPaneBase extends TabSwitcherPaneBase {
userEducationHelper,
edgeToEdgeSupplier,
compositorViewHolderSupplier,
tabGroupCreationUiFlow);
tabGroupCreationUiDelegate);
}
@Override
android/javatests/org/chromium/chrome/browser/BytecodeTest.java
+2 -2
View File
@@ -121,7 +121,7 @@ import org.chromium.chrome.browser.tabmodel.IncognitoStateProvider;
import org.chromium.chrome.browser.tabmodel.TabCreatorManager;
import org.chromium.chrome.browser.tabmodel.TabModelSelector;
import org.chromium.chrome.browser.tasks.HomeSurfaceTracker;
import org.chromium.chrome.browser.tasks.tab_management.TabGroupCreationUiFlow;
import org.chromium.chrome.browser.tasks.tab_management.TabGroupCreationUiDelegate;
import org.chromium.chrome.browser.tasks.tab_management.TabSwitcherPaneCoordinatorFactory;
import org.chromium.chrome.browser.theme.ThemeColorProvider;
import org.chromium.chrome.browser.theme.TopUiThemeColorProvider;
@@ -1827,7 +1827,7 @@ public class BytecodeTest {
UserEducationHelper.class,
ObservableSupplier.class,
ObservableSupplier.class,
TabGroupCreationUiFlow.class));
TabGroupCreationUiDelegate.class));
Assert.assertTrue(
constructorsMatch(