Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #15521 from brave/26107_crash_tipping_banner

Browse Source 
Tipping Banner crash  when tipChoices are not available
This commit is contained in:
Sujit Acharya
2022-10-19 18:59:29 +05:30
committed by GitHub
parent 5bd5ababc5 67014ab6a6
commit 3196eaea0f
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/java/org/chromium/chrome/browser/rewards/BraveRewardsCustomTipFragment.java
+6 -1
View File
@@ -163,7 +163,12 @@ public class BraveRewardsCustomTipFragment extends Fragment {
* decimal points always roundedOff to floor value.
*/
private double getBatValue(String inputValue) {
double rawValue = Double.parseDouble(inputValue);
double rawValue = 0;
try {
rawValue = Double.parseDouble(inputValue);
} catch (NumberFormatException e) {
}
if (!isBatCurrencyMode) {
// from USD to BAT
rawValue = rawValue / exchangeRate;
android/java/org/chromium/chrome/browser/rewards/BraveRewardsTippingPanelFragment.java
+11
View File
@@ -68,6 +68,10 @@ public class BraveRewardsTippingPanelFragment extends Fragment implements BraveR
private final int TIP_SENT_REQUEST_CODE = 2;
private final int FADE_OUT_DURATION = 500;
private static final int DEFAULT_VALUE_OPTION_1 = 1;
private static final int DEFAULT_VALUE_OPTION_2 = 5;
private static final int DEFAULT_VALUE_OPTION_3 = 10;
private static final String CUSTOM_TIP_CONFIRMATION_FRAGMENT_TAG =
"custom_tip_confirmation_fragment";
private static final String CUSTOM_TIP_FRAGMENT_TAG = "custom_tip_fragment";
@@ -175,6 +179,13 @@ public class BraveRewardsTippingPanelFragment extends Fragment implements BraveR
private void initRadioButtons(View view) {
mTipChoices = mBraveRewardsNativeWorker.GetTipChoices();
// when native not giving tip choices initialize with default values
if (mTipChoices.length < 3) {
mTipChoices = new double[3];
mTipChoices[0] = DEFAULT_VALUE_OPTION_1;
mTipChoices[1] = DEFAULT_VALUE_OPTION_2;
mTipChoices[2] = DEFAULT_VALUE_OPTION_3;
}
double rate = mBraveRewardsNativeWorker.GetWalletRate();
int recurrentAmount = (int) mBraveRewardsNativeWorker.GetPublisherRecurrentDonationAmount(