[cr148] ShowTabSearchBubble dropped section arg
This argument was not being used in Brave, so it is of no consequence. Chromium changes: https://chromium.googlesource.com/chromium/src/+/bb4630838cd0fd2567b306b6c481750fdf2b95dd commit bb4630838cd0fd2567b306b6c481750fdf2b95dd Author: Emily Shack <emshack@chromium.org> Date: Mon Mar 9 16:23:28 2026 -0700 [TabOrganization] Deprecate tab index pref Deprecates kTabSearchTabIndex and any reference to tab search sections, following up to the removal of auto tab groups and declutter from tab search. Bug: 488463961 Change-Id: I5c9ecc7024e2125ddd524f381451c59a8cda1ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7630127 Reviewed-by: Alex Gough <ajgo@chromium.org> Commit-Queue: Emily Shack <emshack@chromium.org> Reviewed-by: Darryl James <dljames@chromium.org> Cr-Commit-Position: refs/heads/main@{#1596690}
This commit is contained in:
@@ -18,10 +18,9 @@ void BraveTabSearchBubbleHost::SetBubbleArrow(
|
||||
}
|
||||
|
||||
bool BraveTabSearchBubbleHost::ShowTabSearchBubble(
|
||||
bool triggered_by_keyboard_shortcut,
|
||||
tab_search::mojom::TabSearchSection section) {
|
||||
bool result = TabSearchBubbleHost::ShowTabSearchBubble(
|
||||
triggered_by_keyboard_shortcut, section);
|
||||
bool triggered_by_keyboard_shortcut) {
|
||||
bool result =
|
||||
TabSearchBubbleHost::ShowTabSearchBubble(triggered_by_keyboard_shortcut);
|
||||
if (!arrow_ || !result) {
|
||||
return result;
|
||||
}
|
||||
|
||||
@@ -19,9 +19,7 @@ class BraveTabSearchBubbleHost : public TabSearchBubbleHost {
|
||||
|
||||
// TabSearchBubbleHost:
|
||||
bool ShowTabSearchBubble(
|
||||
bool triggered_by_keyboard_shortcut = false,
|
||||
tab_search::mojom::TabSearchSection section =
|
||||
tab_search::mojom::TabSearchSection::kNone) override;
|
||||
bool triggered_by_keyboard_shortcut = false) override;
|
||||
|
||||
private:
|
||||
std::optional<views::BubbleBorder::Arrow> arrow_;
|
||||
|
||||
Reference in New Issue
Block a user