Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[CodeHealth] Clang tidy browser with use-equals-default III

Browse Source 
This change corrects the constructors of several classes under
browser/, using clang-tidy's modernize-use-equals-default.
This commit is contained in:
Claudio DeSouza
2022-08-16 14:04:56 +01:00
parent 5596dbe780
commit 40f3306959
18 changed files with 25 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/extensions/api/brave_action_api.cc
+6 -7
View File
@@ -29,12 +29,12 @@ class BraveActionAPIDependencyManager : public DependencyManager {
static base::NoDestructor<BraveActionAPIDependencyManager> factory;
return factory.get();
}
BraveActionAPIDependencyManager() {}
BraveActionAPIDependencyManager() = default;
BraveActionAPIDependencyManager(const BraveActionAPIDependencyManager&) =
delete;
BraveActionAPIDependencyManager& operator=(
const BraveActionAPIDependencyManager&) = delete;
~BraveActionAPIDependencyManager() override {}
~BraveActionAPIDependencyManager() override = default;
#ifndef NDEBUG
void DumpContextDependencies(void* context) const override {}
@@ -83,9 +83,9 @@ namespace extensions {
//
// BraveActionAPI::Observer
//
BraveActionAPI::Observer::Observer() { }
BraveActionAPI::Observer::Observer() = default;
BraveActionAPI::Observer::~Observer() { }
BraveActionAPI::Observer::~Observer() = default;
//
// BraveActionAPI
@@ -146,10 +146,9 @@ bool BraveActionAPI::ShowActionUI(
return true;
}
BraveActionAPI::BraveActionAPI() {}
BraveActionAPI::BraveActionAPI() = default;
BraveActionAPI::~BraveActionAPI() {
}
BraveActionAPI::~BraveActionAPI() = default;
void BraveActionAPI::AddObserver(Observer* observer) {
observers_.AddObserver(observer);
browser/extensions/brave_component_loader.cc
+1 -1
View File
@@ -58,7 +58,7 @@ BraveComponentLoader::BraveComponentLoader(ExtensionSystem* extension_system,
base::Unretained(this)));
}
BraveComponentLoader::~BraveComponentLoader() {}
BraveComponentLoader::~BraveComponentLoader() = default;
void BraveComponentLoader::OnComponentRegistered(std::string extension_id) {
brave_component_updater::BraveOnDemandUpdater::GetInstance()->OnDemandUpdate(
browser/extensions/brave_extension_provider.cc
+2 -2
View File
@@ -41,9 +41,9 @@ bool IsBlacklisted(const extensions::Extension* extension) {
namespace extensions {
BraveExtensionProvider::BraveExtensionProvider() {}
BraveExtensionProvider::BraveExtensionProvider() = default;
BraveExtensionProvider::~BraveExtensionProvider() {}
BraveExtensionProvider::~BraveExtensionProvider() = default;
std::string BraveExtensionProvider::GetDebugPolicyProviderName() const {
#if defined(NDEBUG)
browser/extensions/brave_extension_service.cc
+1 -2
View File
@@ -28,8 +28,7 @@ BraveExtensionService::BraveExtensionService(Profile* profile,
blocklist, autoupdate_enabled, extensions_enabled, ready) {
}
BraveExtensionService::~BraveExtensionService() {
}
BraveExtensionService::~BraveExtensionService() = default;
void BraveExtensionService::AddComponentExtension(const Extension* extension) {
ExtensionService::AddComponentExtension(extension);
browser/extensions/brave_theme_event_router.cc
+1 -1
View File
@@ -22,7 +22,7 @@ BraveThemeEventRouter::BraveThemeEventRouter(Profile* profile)
observer_.Observe(ui::NativeTheme::GetInstanceForNativeUi());
}
BraveThemeEventRouter::~BraveThemeEventRouter() {}
BraveThemeEventRouter::~BraveThemeEventRouter() = default;
void BraveThemeEventRouter::OnNativeThemeUpdated(
ui::NativeTheme* observed_theme) {
browser/extensions/brave_theme_event_router_browsertest.cc
+1 -1
View File
@@ -22,7 +22,7 @@ namespace extensions {
class MockBraveThemeEventRouter : public BraveThemeEventRouter {
public:
using BraveThemeEventRouter::BraveThemeEventRouter;
~MockBraveThemeEventRouter() override {}
~MockBraveThemeEventRouter() override = default;
MOCK_METHOD0(Notify, void());
};
browser/extensions/brave_webtorrent_navigation_throttle_unittest.cc
+2 -2
View File
@@ -43,8 +43,8 @@ namespace {
class MockBrowserClient : public content::ContentBrowserClient {
public:
MockBrowserClient() {}
~MockBrowserClient() override {}
MockBrowserClient() = default;
~MockBrowserClient() override = default;
// Only construct an BraveWebTorrentNavigationThrottle so that we can test it
// in isolation.
browser/extensions/ethereum_remote_client_unittest.cc
+1 -1
View File
@@ -30,7 +30,7 @@ class BraveWalletUnitTest : public testing::Test {
public:
BraveWalletUnitTest()
: testing_profile_manager_(TestingBrowserProcess::GetGlobal()) {}
~BraveWalletUnitTest() override {}
~BraveWalletUnitTest() override = default;
protected:
void SetUp() override {
browser/farbling/brave_enumeratedevices_farbling_browsertest.cc
+1 -1
View File
@@ -58,7 +58,7 @@ class BraveEnumerateDevicesFarblingBrowserTest : public InProcessBrowserTest {
BraveEnumerateDevicesFarblingBrowserTest& operator=(
const BraveEnumerateDevicesFarblingBrowserTest&) = delete;
~BraveEnumerateDevicesFarblingBrowserTest() override {}
~BraveEnumerateDevicesFarblingBrowserTest() override = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
browser/farbling/brave_navigator_devicememory_farbling_browsertest.cc
+1 -1
View File
@@ -48,7 +48,7 @@ class BraveDeviceMemoryFarblingBrowserTest : public InProcessBrowserTest {
BraveDeviceMemoryFarblingBrowserTest& operator=(
const BraveDeviceMemoryFarblingBrowserTest&) = delete;
~BraveDeviceMemoryFarblingBrowserTest() override {}
~BraveDeviceMemoryFarblingBrowserTest() override = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
browser/farbling/brave_navigator_keyboard_api_browsertest.cc
+1 -1
View File
@@ -47,7 +47,7 @@ class BraveNavigatorKeyboardAPIBrowserTest : public InProcessBrowserTest {
BraveNavigatorKeyboardAPIBrowserTest& operator=(
const BraveNavigatorKeyboardAPIBrowserTest&) = delete;
~BraveNavigatorKeyboardAPIBrowserTest() override {}
~BraveNavigatorKeyboardAPIBrowserTest() override = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
browser/farbling/brave_navigator_languages_farbling_browsertest.cc
+1 -1
View File
@@ -66,7 +66,7 @@ class BraveNavigatorLanguagesFarblingBrowserTest : public InProcessBrowserTest {
BraveNavigatorLanguagesFarblingBrowserTest& operator=(
const BraveNavigatorLanguagesFarblingBrowserTest&) = delete;
~BraveNavigatorLanguagesFarblingBrowserTest() override {}
~BraveNavigatorLanguagesFarblingBrowserTest() override = default;
void SetUpOnMainThread() override {
InProcessBrowserTest::SetUpOnMainThread();
browser/ftx/ftx_service_factory.cc
+1 -1
View File
@@ -31,7 +31,7 @@ FTXServiceFactory::FTXServiceFactory()
"FTXService",
BrowserContextDependencyManager::GetInstance()) {}
FTXServiceFactory::~FTXServiceFactory() {}
FTXServiceFactory::~FTXServiceFactory() = default;
KeyedService* FTXServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
browser/gemini/gemini_service_factory.cc
+1 -2
View File
@@ -32,8 +32,7 @@ GeminiServiceFactory::GeminiServiceFactory()
BrowserContextDependencyManager::GetInstance()) {
}
GeminiServiceFactory::~GeminiServiceFactory() {
}
GeminiServiceFactory::~GeminiServiceFactory() = default;
KeyedService* GeminiServiceFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
browser/geolocation/brave_geolocation_permission_context_delegate.cc
+1 -1
View File
@@ -20,7 +20,7 @@ BraveGeolocationPermissionContextDelegate::
profile_(Profile::FromBrowserContext(browser_context)) {}
BraveGeolocationPermissionContextDelegate::
~BraveGeolocationPermissionContextDelegate() {}
~BraveGeolocationPermissionContextDelegate() = default;
bool BraveGeolocationPermissionContextDelegate::DecidePermission(
const permissions::PermissionRequestID& id,
browser/importer/brave_external_process_importer_host.cc
+1 -1
View File
@@ -51,7 +51,7 @@ class WebstoreInstallerForImporting
using WebstoreInstallWithPrompt::WebstoreInstallWithPrompt;
private:
~WebstoreInstallerForImporting() override {}
~WebstoreInstallerForImporting() override = default;
std::unique_ptr<ExtensionInstallPrompt::Prompt>
CreateInstallPrompt() const override {
browser/infobars/brave_confirm_p3a_infobar_delegate.cc
+1 -1
View File
@@ -45,7 +45,7 @@ BraveConfirmP3AInfoBarDelegate::BraveConfirmP3AInfoBarDelegate(
PrefService* local_state)
: ConfirmInfoBarDelegate(), local_state_(local_state) {}
BraveConfirmP3AInfoBarDelegate::~BraveConfirmP3AInfoBarDelegate() {}
BraveConfirmP3AInfoBarDelegate::~BraveConfirmP3AInfoBarDelegate() = default;
infobars::InfoBarDelegate::InfoBarIdentifier
BraveConfirmP3AInfoBarDelegate::GetIdentifier() const {
browser/infobars/sync_v2_migrate_infobar_delegate.cc
+1 -2
View File
@@ -76,8 +76,7 @@ SyncV2MigrateInfoBarDelegate::SyncV2MigrateInfoBarDelegate(Browser* browser,
browser_(browser) {
}
SyncV2MigrateInfoBarDelegate::~SyncV2MigrateInfoBarDelegate() {
}
SyncV2MigrateInfoBarDelegate::~SyncV2MigrateInfoBarDelegate() = default;
infobars::InfoBarDelegate::InfoBarIdentifier
SyncV2MigrateInfoBarDelegate::GetIdentifier() const {