[Android] Remove base chrome layout

Chromium change:
https://chromium.googlesource.com/chromium/src/+/76fac7530c580e7183de4aa7ecd34b837e38fb17

Fix incorrect anchor placement for Omnibox Suggestions Dropdown

The placement of the Anchor view for the Omnibox Suggestions Dropdown
was being computed based on a view with a different on-screen origin
(different (0,0) coordinates) than the view hosting the dropdown.
This mismatch caused visible gaps in multiple scenarios.

This change ensures that the parent view, which hosts both the Omnibox
Suggestions Dropdown and the anchor view, is used for positioning.
This approach eliminates the current issue and prevents similar
alignment problems in the future.

The change directly fixes the problem with Edge To Edge Everywhere.
This commit is contained in:
Artem Samoilenko
2025-02-26 19:48:56 +00:00
committed by Claudio DeSouza
parent 435c879bd4
commit 4176d4014a
4 changed files with 1 additions and 12 deletions
@@ -112,7 +112,6 @@ public class FullScreenCustomTabActivity extends CustomTabActivity {
() -> mTabController,
() -> mMinimizationManagerHolder.getMinimizationManager(),
() -> mCustomTabFeatureOverridesManager,
getBaseChromeLayout(),
getEdgeToEdgeManager());
return mBaseCustomTabRootUiCoordinator;
}
@@ -5,10 +5,7 @@
package org.chromium.chrome.browser.customtabs;
import android.view.View;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.appcompat.app.AppCompatActivity;
import org.chromium.base.supplier.ObservableSupplier;
@@ -84,7 +81,6 @@ public class FullScreenCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoo
@NonNull Supplier<CustomTabActivityTabController> tabController,
@NonNull Supplier<CustomTabMinimizeDelegate> minimizeDelegateSupplier,
@NonNull Supplier<CustomTabFeatureOverridesManager> featureOverridesManagerSupplier,
@Nullable View baseChromeLayout,
@NonNull EdgeToEdgeManager edgeToEdgeManager) {
super(
activity,
@@ -121,7 +117,6 @@ public class FullScreenCustomTabRootUiCoordinator extends BaseCustomTabRootUiCoo
tabController,
minimizeDelegateSupplier,
featureOverridesManagerSupplier,
baseChromeLayout,
edgeToEdgeManager);
}
@@ -6,7 +6,6 @@
package org.chromium.chrome.browser.tabbed_mode;
import android.os.Bundle;
import android.view.View;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
@@ -107,8 +106,7 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator {
@NonNull BackPressManager backPressManager,
@Nullable Bundle savedInstanceState,
@Nullable MultiInstanceManager multiInstanceManager,
@Nullable ObservableSupplier<Integer> overviewColorSupplier,
@Nullable View baseChromeLayout,
@NonNull ObservableSupplier<Integer> overviewColorSupplier,
@NonNull ManualFillingComponentSupplier manualFillingComponentSupplier,
@NonNull EdgeToEdgeManager edgeToEdgeManager) {
super(
@@ -156,7 +154,6 @@ public class BraveTabbedRootUiCoordinator extends TabbedRootUiCoordinator {
savedInstanceState,
multiInstanceManager,
overviewColorSupplier,
baseChromeLayout,
manualFillingComponentSupplier,
edgeToEdgeManager);
@@ -181,7 +181,6 @@ public class BraveToolbarManager extends ToolbarManager {
boolean initializeWithIncognitoColors,
@Nullable BackPressManager backPressManager,
@Nullable ObservableSupplier<Integer> overviewColorSupplier,
@Nullable View baseChromeLayout,
ObservableSupplier<ReadAloudController> readAloudControllerSupplier,
@Nullable DesktopWindowStateManager desktopWindowStateManager) {
super(
@@ -225,7 +224,6 @@ public class BraveToolbarManager extends ToolbarManager {
initializeWithIncognitoColors,
backPressManager,
overviewColorSupplier,
baseChromeLayout,
readAloudControllerSupplier,
desktopWindowStateManager);