[cr147] Fix ExtensionsAPIProvider stub
`RegisterManifestHandlers` now takes an argument, which is of no relevance for the override in place. Chromium changes: https://chromium.googlesource.com/chromium/src/+/408aa6609b730ac50fc290c68c7120bd12ec576f commit 408aa6609b730ac50fc290c68c7120bd12ec576f Author: Ehtesham Zahid <ehteshamzahid313@gmail.com> Date: Mon Feb 23 08:24:29 2026 -0800 [Extensions] Use dependency injection for ManifestHandlerRegistry This CL refactors ExtensionsAPIProvider::RegisterManifestHandlers() to accept a ManifestHandlerRegistry pointer. This eliminates the need for individual providers and handlers to call the global ManifestHandlerRegistry::Get() singleton. By injecting the dependency from ExtensionsClient::DoInitialize, we make the extensions startup sequence more explicit and reduce reliance on global state. Fulfills a TODO by devlin@. Bug: 485145030 Test: autoninja -C out/Default chrome Test: Manually verified extension icons and permissions in chrome://extensions Change-Id: I5002625d0e97068720c52e7b212274741de18348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7582039 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by: Solomon Kinard <solomonkinard@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1588719}
This commit is contained in:
@@ -57,7 +57,8 @@ void BraveExtensionsAPIProvider::RegisterPermissions(
|
||||
// No brave-specific permissions.
|
||||
}
|
||||
|
||||
void BraveExtensionsAPIProvider::RegisterManifestHandlers() {
|
||||
void BraveExtensionsAPIProvider::RegisterManifestHandlers(
|
||||
ManifestHandlerRegistry* registry) {
|
||||
// No brave-specific manifest handlers.
|
||||
}
|
||||
|
||||
|
||||
@@ -30,7 +30,7 @@ class BraveExtensionsAPIProvider : public ExtensionsAPIProvider {
|
||||
bool IsAPISchemaGenerated(const std::string& name) override;
|
||||
std::string_view GetAPISchema(const std::string& name) override;
|
||||
void RegisterPermissions(PermissionsInfo* permissions_info) override;
|
||||
void RegisterManifestHandlers() override;
|
||||
void RegisterManifestHandlers(ManifestHandlerRegistry* registry) override;
|
||||
|
||||
private:
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user