Discharge7443/brave-core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Changed prefs to kDontAskForCrashReporting to prevent double negative

Browse Source
This commit is contained in:
Simon Hong
2021-09-15 11:50:49 +09:00
parent 2d94955a90
commit 4a75322a08
6 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
browser/brave_local_state_prefs.cc
+1 -1
View File
@@ -98,7 +98,7 @@ void RegisterLocalStatePrefs(PrefRegistrySimple* registry) {
dark_mode::RegisterBraveDarkModeLocalStatePrefs(registry);
registry->RegisterBooleanPref(kDefaultBrowserPromptEnabled, true);
registry->RegisterBooleanPref(kAskCrashReportPermission, true);
registry->RegisterBooleanPref(kDontAskForCrashReporting, false);
#endif
#if BUILDFLAG(ENABLE_WIDEVINE)
browser/brave_prefs_browsertest.cc
+2 -2
View File
@@ -162,7 +162,7 @@ IN_PROC_BROWSER_TEST_F(BraveProfilePrefsBrowserTest,
IN_PROC_BROWSER_TEST_F(BraveLocalStatePrefsBrowserTest, DefaultLocalStateTest) {
EXPECT_TRUE(g_browser_process->local_state()->GetBoolean(
kDefaultBrowserPromptEnabled));
EXPECT_TRUE(
g_browser_process->local_state()->GetBoolean(kAskCrashReportPermission));
EXPECT_FALSE(
g_browser_process->local_state()->GetBoolean(kDontAskForCrashReporting));
}
#endif
browser/metrics/metrics_reporting_util.cc
+1 -1
View File
@@ -38,7 +38,7 @@ bool ShouldShowCrashReportPermissionAskDialog() {
#endif
PrefService* local_prefs = g_browser_process->local_state();
if (!local_prefs->GetBoolean(kAskCrashReportPermission))
if (local_prefs->GetBoolean(kDontAskForCrashReporting))
return false;
if (IsMetricsReportingPolicyManaged())
browser/ui/views/crash_report_permission_ask_dialog_view.cc
+1 -1
View File
@@ -238,7 +238,7 @@ void CrashReportPermissionAskDialogView::OnAcceptButtonClicked() {
void CrashReportPermissionAskDialogView::OnWindowClosing() {
g_browser_process->local_state()->SetBoolean(
kAskCrashReportPermission, !dont_ask_again_checkbox_->GetChecked());
kDontAskForCrashReporting, dont_ask_again_checkbox_->GetChecked());
// On macOS, this dialog is not destroyed properly when session crashed bubble
// is launched directly.
common/pref_names.cc
+1 -1
View File
@@ -94,7 +94,7 @@ const char kImportDialogExtensions[] = "import_dialog_extensions";
const char kImportDialogPayments[] = "import_dialog_payments";
const char kMRUCyclingEnabled[] = "brave.mru_cycling_enabled";
const char kTabsSearchShow[] = "brave.tabs_search_show";
const char kAskCrashReportPermission[] = "brave.ask_crash_report_permission";
const char kDontAskForCrashReporting[] = "brave.dont_ask_for_crash_reporting";
#if BUILDFLAG(ENABLE_BRAVE_VPN)
const char kBraveVPNShowButton[] = "brave.brave_vpn.show_button";
common/pref_names.h
+1 -1
View File
@@ -91,7 +91,7 @@ extern const char kSafetynetStatus[];
extern const char kDefaultBrowserLaunchingCount[];
extern const char kTabsSearchShow[];
extern const char kAskCrashReportPermission[];
extern const char kDontAskForCrashReporting[];
#if BUILDFLAG(ENABLE_BRAVE_VPN)
extern const char kBraveVPNShowButton[];